Re: [Mesa-dev] Patch for freedreno features

[Jason Ekstrand]

On Jan 3, 2017 9:54 AM, "Romain Failliot" 
wrote:

2017-01-03 10:47 GMT-05:00 Rob Clark :
> Hmm, well I guess in future, git-format-patch and attach that to bz..
> but no worries this time, I went ahead and pushed it w/ --author as
> Jan suggested

Thanks!

I'm sorry, I misunderstood, I thought you preferred the patch to be in
the mailing list (but I did use git format-patch, so... 1 out of 2 :D
)
Next time I'll do as you said! (and actually I do prefer bz over emails)


If you plan on making substantial contributions in the future, getting
git-send-email working is a good idea.  The Mesa project as a whole uses
the mailing list for patch submission and review.  Sometimes someone will
pull a patch from a bug but it's definitely not the recommended method.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Patch for freedreno features

[Romain Failliot]

2017-01-03 10:47 GMT-05:00 Rob Clark :
> Hmm, well I guess in future, git-format-patch and attach that to bz..
> but no worries this time, I went ahead and pushed it w/ --author as
> Jan suggested

Thanks!

I'm sorry, I misunderstood, I thought you preferred the patch to be in
the mailing list (but I did use git format-patch, so... 1 out of 2 :D
)
Next time I'll do as you said! (and actually I do prefer bz over emails)

-- 
Romain "Creak" Failliot
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Patch for freedreno features

[Rob Clark]

On Mon, Jan 2, 2017 at 1:18 PM, Romain Failliot
 wrote:
> 2017-01-01 16:15 GMT-05:00 Rob Clark :
>> well, I was trying to not loose authorship/etc from the patch
>> (although tbh I've lost track of who the original author was)..
>> http://www.mesa3d.org/devinfo.html#submitting has some suggestions.
>
> I went there, I don't think it's a git problem. I think it's the
> default setup of sendmail that in't good (maybe it's not configured,
> or it only allows internal emails, idk).
> And I'm not that good at changing sendmail settings.

Hmm, well I guess in future, git-format-patch and attach that to bz..
but no worries this time, I went ahead and pushed it w/ --author as
Jan suggested

BR,
-R
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Patch for freedreno features

[Romain Failliot]

2017-01-01 16:15 GMT-05:00 Rob Clark :
> well, I was trying to not loose authorship/etc from the patch
> (although tbh I've lost track of who the original author was)..
> http://www.mesa3d.org/devinfo.html#submitting has some suggestions.

I went there, I don't think it's a git problem. I think it's the
default setup of sendmail that in't good (maybe it's not configured,
or it only allows internal emails, idk).
And I'm not that good at changing sendmail settings.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Patch for freedreno features

[Jan Vesely]

On Sun, 2017-01-01 at 16:15 -0500, Rob Clark wrote:
> On Sat, Dec 31, 2016 at 1:31 PM, Romain Failliot
>  wrote:
> > I tried to use git send-email but it doesn't seem to work (although
> > the output says otherwise).
> > 
> > So eventually it's simpler to just copy/paste the patch generated by
> > git format-patch:
> 
> well, I was trying to not loose authorship/etc from the patch
> (although tbh I've lost track of who the original author was)..

just FYI
you can use git commit --author="foo bar " to set arbitrary
authorship at commit time. works with git commit --amend as well.

Jan

> http://www.mesa3d.org/devinfo.html#submitting has some suggestions.
> 
> BR,
> -R
> 
> > ---
> >  docs/features.txt | 38 +++---
> >  1 file changed, 19 insertions(+), 19 deletions(-)
> > 
> > diff --git a/docs/features.txt b/docs/features.txt
> > index c27d521..63b45af 100644
> > --- a/docs/features.txt
> > +++ b/docs/features.txt
> > @@ -33,7 +33,7 @@ are exposed in the 3.0 context as extensions.
> >  Feature Status
> >  ---
> > 
> > 
> > -GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> > llvmpipe, softpipe, swr
> > +GL 3.0, GLSL 1.30 --- all DONE: freedreno, i965, nv50, nvc0, r600,
> > radeonsi, llvmpipe, softpipe, swr
> > 
> >glBindFragDataLocation, glGetFragDataLocation DONE
> >GL_NV_conditional_render (Conditional rendering)  DONE ()
> > @@ -60,12 +60,12 @@ GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0,
> > r600, radeonsi, llvmpipe, soft
> >glVertexAttribI commands  DONE
> >Depth format cube texturesDONE ()
> >GLX_ARB_create_context (GLX 1.4 is required)  DONE
> > -  Multisample anti-aliasing DONE
> > (llvmpipe (*), softpipe (*), swr (*))
> > +  Multisample anti-aliasing DONE
> > (freedreno (*), llvmpipe (*), softpipe (*), swr (*))
> > 
> > -(*) llvmpipe, softpipe, and swr have fake Multisample anti-aliasing support
> > +(*) freedreno, llvmpipe, softpipe, and swr have fake Multisample
> > anti-aliasing support
> > 
> > 
> > -GL 3.1, GLSL 1.40 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> > llvmpipe, softpipe, swr
> > +GL 3.1, GLSL 1.40 --- all DONE: freedreno, i965, nv50, nvc0, r600,
> > radeonsi, llvmpipe, softpipe, swr
> > 
> >Forward compatible context support/deprecations   DONE ()
> >GL_ARB_draw_instanced (Instanced drawing) DONE ()
> > @@ -82,34 +82,34 @@ GL 3.2, GLSL 1.50 --- all DONE: i965, nv50, nvc0,
> > r600, radeonsi, llvmpipe, soft
> > 
> >Core/compatibility profiles   DONE
> >Geometry shaders  DONE ()
> > -  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (swr)
> > -  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (swr)
> > -  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (swr)
> > -  GL_ARB_provoking_vertex (Provoking vertex)DONE (swr)
> > -  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (swr)
> > +  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (freedreno, 
> > swr)
> > +  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (freedreno, 
> > swr)
> > +  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (freedreno, 
> > swr)
> > +  GL_ARB_provoking_vertex (Provoking vertex)DONE (freedreno, 
> > swr)
> > +  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (freedreno, 
> > swr)
> >GL_ARB_texture_multisample (Multisample textures) DONE (swr)
> > -  GL_ARB_depth_clamp (Frag depth clamp) DONE (swr)
> > -  GL_ARB_sync (Fence objects)   DONE (swr)
> > +  GL_ARB_depth_clamp (Frag depth clamp) DONE (freedreno, 
> > swr)
> > +  GL_ARB_sync (Fence objects)   DONE (freedreno, 
> > swr)
> >GLX_ARB_create_context_profileDONE
> > 
> > 
> >  GL 3.3, GLSL 3.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> > llvmpipe, softpipe
> > 
> > -  GL_ARB_blend_func_extendedDONE (swr)
> > +  GL_ARB_blend_func_extendedDONE
> > (freedreno/a3xx, swr)
> >GL_ARB_explicit_attrib_location   DONE (all
> > drivers that support GLSL)
> > -  GL_ARB_occlusion_query2   DONE (swr)
> > +  GL_ARB_occlusion_query2   DONE (freedreno, 
> > swr)
> >GL_ARB_sampler_objectsDONE (all drivers)
> > -  GL_ARB_shader_bit_encodingDONE (swr)
> > -  GL_ARB_texture_rgb10_a2ui DONE (swr)
> > -  GL_ARB_texture_swizzleDONE 

Re: [Mesa-dev] Patch for freedreno features

[Rob Clark]

On Sat, Dec 31, 2016 at 1:31 PM, Romain Failliot
 wrote:
> I tried to use git send-email but it doesn't seem to work (although
> the output says otherwise).
>
> So eventually it's simpler to just copy/paste the patch generated by
> git format-patch:

well, I was trying to not loose authorship/etc from the patch
(although tbh I've lost track of who the original author was)..
http://www.mesa3d.org/devinfo.html#submitting has some suggestions.

BR,
-R

> ---
>  docs/features.txt | 38 +++---
>  1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/docs/features.txt b/docs/features.txt
> index c27d521..63b45af 100644
> --- a/docs/features.txt
> +++ b/docs/features.txt
> @@ -33,7 +33,7 @@ are exposed in the 3.0 context as extensions.
>  Feature Status
>  ---
> 
>
> -GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> llvmpipe, softpipe, swr
> +GL 3.0, GLSL 1.30 --- all DONE: freedreno, i965, nv50, nvc0, r600,
> radeonsi, llvmpipe, softpipe, swr
>
>glBindFragDataLocation, glGetFragDataLocation DONE
>GL_NV_conditional_render (Conditional rendering)  DONE ()
> @@ -60,12 +60,12 @@ GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0,
> r600, radeonsi, llvmpipe, soft
>glVertexAttribI commands  DONE
>Depth format cube texturesDONE ()
>GLX_ARB_create_context (GLX 1.4 is required)  DONE
> -  Multisample anti-aliasing DONE
> (llvmpipe (*), softpipe (*), swr (*))
> +  Multisample anti-aliasing DONE
> (freedreno (*), llvmpipe (*), softpipe (*), swr (*))
>
> -(*) llvmpipe, softpipe, and swr have fake Multisample anti-aliasing support
> +(*) freedreno, llvmpipe, softpipe, and swr have fake Multisample
> anti-aliasing support
>
>
> -GL 3.1, GLSL 1.40 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> llvmpipe, softpipe, swr
> +GL 3.1, GLSL 1.40 --- all DONE: freedreno, i965, nv50, nvc0, r600,
> radeonsi, llvmpipe, softpipe, swr
>
>Forward compatible context support/deprecations   DONE ()
>GL_ARB_draw_instanced (Instanced drawing) DONE ()
> @@ -82,34 +82,34 @@ GL 3.2, GLSL 1.50 --- all DONE: i965, nv50, nvc0,
> r600, radeonsi, llvmpipe, soft
>
>Core/compatibility profiles   DONE
>Geometry shaders  DONE ()
> -  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (swr)
> -  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (swr)
> -  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (swr)
> -  GL_ARB_provoking_vertex (Provoking vertex)DONE (swr)
> -  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (swr)
> +  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (freedreno, swr)
> +  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (freedreno, swr)
> +  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (freedreno, swr)
> +  GL_ARB_provoking_vertex (Provoking vertex)DONE (freedreno, swr)
> +  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (freedreno, swr)
>GL_ARB_texture_multisample (Multisample textures) DONE (swr)
> -  GL_ARB_depth_clamp (Frag depth clamp) DONE (swr)
> -  GL_ARB_sync (Fence objects)   DONE (swr)
> +  GL_ARB_depth_clamp (Frag depth clamp) DONE (freedreno, swr)
> +  GL_ARB_sync (Fence objects)   DONE (freedreno, swr)
>GLX_ARB_create_context_profileDONE
>
>
>  GL 3.3, GLSL 3.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
> llvmpipe, softpipe
>
> -  GL_ARB_blend_func_extendedDONE (swr)
> +  GL_ARB_blend_func_extendedDONE
> (freedreno/a3xx, swr)
>GL_ARB_explicit_attrib_location   DONE (all
> drivers that support GLSL)
> -  GL_ARB_occlusion_query2   DONE (swr)
> +  GL_ARB_occlusion_query2   DONE (freedreno, swr)
>GL_ARB_sampler_objectsDONE (all drivers)
> -  GL_ARB_shader_bit_encodingDONE (swr)
> -  GL_ARB_texture_rgb10_a2ui DONE (swr)
> -  GL_ARB_texture_swizzleDONE (swr)
> +  GL_ARB_shader_bit_encodingDONE (freedreno, swr)
> +  GL_ARB_texture_rgb10_a2ui DONE (freedreno, swr)
> +  GL_ARB_texture_swizzleDONE (freedreno, swr)
>GL_ARB_timer_queryDONE (swr)
> -  GL_ARB_instanced_arrays   DONE (swr)
> -  GL_ARB_vertex_type_2_10_10_10_rev

Re: [Mesa-dev] Patch for freedreno features

[Romain Failliot]

I tried to use git send-email but it doesn't seem to work (although
the output says otherwise).

So eventually it's simpler to just copy/paste the patch generated by
git format-patch:

---
 docs/features.txt | 38 +++---
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/docs/features.txt b/docs/features.txt
index c27d521..63b45af 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -33,7 +33,7 @@ are exposed in the 3.0 context as extensions.
 Feature Status
 ---


-GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
llvmpipe, softpipe, swr
+GL 3.0, GLSL 1.30 --- all DONE: freedreno, i965, nv50, nvc0, r600,
radeonsi, llvmpipe, softpipe, swr

   glBindFragDataLocation, glGetFragDataLocation DONE
   GL_NV_conditional_render (Conditional rendering)  DONE ()
@@ -60,12 +60,12 @@ GL 3.0, GLSL 1.30 --- all DONE: i965, nv50, nvc0,
r600, radeonsi, llvmpipe, soft
   glVertexAttribI commands  DONE
   Depth format cube texturesDONE ()
   GLX_ARB_create_context (GLX 1.4 is required)  DONE
-  Multisample anti-aliasing DONE
(llvmpipe (*), softpipe (*), swr (*))
+  Multisample anti-aliasing DONE
(freedreno (*), llvmpipe (*), softpipe (*), swr (*))

-(*) llvmpipe, softpipe, and swr have fake Multisample anti-aliasing support
+(*) freedreno, llvmpipe, softpipe, and swr have fake Multisample
anti-aliasing support


-GL 3.1, GLSL 1.40 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
llvmpipe, softpipe, swr
+GL 3.1, GLSL 1.40 --- all DONE: freedreno, i965, nv50, nvc0, r600,
radeonsi, llvmpipe, softpipe, swr

   Forward compatible context support/deprecations   DONE ()
   GL_ARB_draw_instanced (Instanced drawing) DONE ()
@@ -82,34 +82,34 @@ GL 3.2, GLSL 1.50 --- all DONE: i965, nv50, nvc0,
r600, radeonsi, llvmpipe, soft

   Core/compatibility profiles   DONE
   Geometry shaders  DONE ()
-  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (swr)
-  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (swr)
-  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (swr)
-  GL_ARB_provoking_vertex (Provoking vertex)DONE (swr)
-  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (swr)
+  GL_ARB_vertex_array_bgra (BGRA vertex order)  DONE (freedreno, swr)
+  GL_ARB_draw_elements_base_vertex (Base vertex offset) DONE (freedreno, swr)
+  GL_ARB_fragment_coord_conventions (Frag shader coord) DONE (freedreno, swr)
+  GL_ARB_provoking_vertex (Provoking vertex)DONE (freedreno, swr)
+  GL_ARB_seamless_cube_map (Seamless cubemaps)  DONE (freedreno, swr)
   GL_ARB_texture_multisample (Multisample textures) DONE (swr)
-  GL_ARB_depth_clamp (Frag depth clamp) DONE (swr)
-  GL_ARB_sync (Fence objects)   DONE (swr)
+  GL_ARB_depth_clamp (Frag depth clamp) DONE (freedreno, swr)
+  GL_ARB_sync (Fence objects)   DONE (freedreno, swr)
   GLX_ARB_create_context_profileDONE


 GL 3.3, GLSL 3.30 --- all DONE: i965, nv50, nvc0, r600, radeonsi,
llvmpipe, softpipe

-  GL_ARB_blend_func_extendedDONE (swr)
+  GL_ARB_blend_func_extendedDONE
(freedreno/a3xx, swr)
   GL_ARB_explicit_attrib_location   DONE (all
drivers that support GLSL)
-  GL_ARB_occlusion_query2   DONE (swr)
+  GL_ARB_occlusion_query2   DONE (freedreno, swr)
   GL_ARB_sampler_objectsDONE (all drivers)
-  GL_ARB_shader_bit_encodingDONE (swr)
-  GL_ARB_texture_rgb10_a2ui DONE (swr)
-  GL_ARB_texture_swizzleDONE (swr)
+  GL_ARB_shader_bit_encodingDONE (freedreno, swr)
+  GL_ARB_texture_rgb10_a2ui DONE (freedreno, swr)
+  GL_ARB_texture_swizzleDONE (freedreno, swr)
   GL_ARB_timer_queryDONE (swr)
-  GL_ARB_instanced_arrays   DONE (swr)
-  GL_ARB_vertex_type_2_10_10_10_rev DONE (swr)
+  GL_ARB_instanced_arrays   DONE (freedreno, swr)
+  GL_ARB_vertex_type_2_10_10_10_rev DONE (freedreno, swr)


 GL 4.0, GLSL 4.00 --- all DONE: i965/gen8+, nvc0, r600, radeonsi

-  GL_ARB_draw_buffers_blend DONE
(i965/gen6+, nv50, llvmpipe, softpipe, swr)
+  GL_ARB_draw_buffers_blend DONE
(freedreno, i965/gen6+, nv50, llvmpipe, softpipe, 

Re: [Mesa-dev] Patch for freedreno features

[Romain Failliot]

I'll try to do the git patch!

I know features.txt isn't the official support source and it is more
for the devs to follow on their work, so it's really up to up if you
want to add freedreno in features.txt. I simply don't have a device
for each driver, that's why I'm parsing features.txt in mesamatrix.

brb with a patch!

Thanks!

2016-12-31 12:08 GMT-05:00 Rob Clark :
> hey, I don't suppose you could send a git patch?  I can push (although
> tbh glxinfo is the authoritative source when it comes to which
> extensions are supported on which generations of adreno)
>
> BR,
> -R
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Patch for freedreno features

[Rob Clark]

hey, I don't suppose you could send a git patch?  I can push (although
tbh glxinfo is the authoritative source when it comes to which
extensions are supported on which generations of adreno)

BR,
-R

On Fri, Dec 30, 2016 at 2:09 PM, Romain Failliot
 wrote:
> Hi!
>
> There's a patch by Rob Clark that sits in bugzilla for while now:
> https://bugs.freedesktop.org/show_bug.cgi?id=95460
>
> I've just updated it to HEAD. It would be nice to merge it, especially
> since there hasn't been much changes in features.txt for a while.
>
> Cheers!
>
> --
> Romain "Creak" Failliot
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev