Re: [EXTERNAL] Re: Zink MR signoff tags
For simple MR without rb/ab is good, but for large MR, part of them are reviewed, and part of are not. I would suggest for large MR, the reviewed commits's title can styled with for example: ``` xlib(ab): Some change acked of xlib ``` ``` xlib(rb): Some change reviewed of xlib ``` For changes both with ab/rb, use rb
Re: [EXTERNAL] Re: Zink MR signoff tags
Same for the X11 backends (xlib, glx, egl/x11, wsi/x11). On Tue, Oct 18, 2022 at 6:14 PM Karol Herbst wrote: > and for Nouveau while I am at it. > > Unless somebody screams and still wants them. > > On Wed, Oct 19, 2022 at 12:12 AM Karol Herbst wrote: > > > > Same for Rusticl > > > > On Mon, Oct 17, 2022 at 10:28 PM Jesse Natalie > wrote: > > > > > > Jumping on the bandwagon, I'm going to adopt this for Microsoft-owned > code as well (src/gallium/d3d12, src/microsoft/*). > > > > > > -Jesse > > > > > > -Original Message- > > > From: mesa-dev On Behalf Of > Gert Wollny > > > Sent: Friday, October 7, 2022 2:37 AM > > > To: erik.faye-lund ; Alyssa Rosenzweig < > aly...@collabora.com>; Mike Blumenkrantz > > > Cc: ML mesa-dev > > > Subject: [EXTERNAL] Re: Zink MR signoff tags > > > > > > On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > > > > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > > > > + for not requiring rb/ab tags ... > > > > > > > > I think it's time to think about making this change all over Mesa as > > > > well. We're deeply in bed with GitLab by now, so I don't think > there's > > > > a realistic chance that this isn't going to just be duplicate info > any > > > > time soon... > > > > > > Agreed, I'll certainly do this for r600 from now on. > > > > > > - Gert > >
Re: [EXTERNAL] Re: Zink MR signoff tags
and for Nouveau while I am at it. Unless somebody screams and still wants them. On Wed, Oct 19, 2022 at 12:12 AM Karol Herbst wrote: > > Same for Rusticl > > On Mon, Oct 17, 2022 at 10:28 PM Jesse Natalie wrote: > > > > Jumping on the bandwagon, I'm going to adopt this for Microsoft-owned code > > as well (src/gallium/d3d12, src/microsoft/*). > > > > -Jesse > > > > -Original Message- > > From: mesa-dev On Behalf Of Gert > > Wollny > > Sent: Friday, October 7, 2022 2:37 AM > > To: erik.faye-lund ; Alyssa Rosenzweig > > ; Mike Blumenkrantz > > Cc: ML mesa-dev > > Subject: [EXTERNAL] Re: Zink MR signoff tags > > > > On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > > > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > > > + for not requiring rb/ab tags ... > > > > > > I think it's time to think about making this change all over Mesa as > > > well. We're deeply in bed with GitLab by now, so I don't think there's > > > a realistic chance that this isn't going to just be duplicate info any > > > time soon... > > > > Agreed, I'll certainly do this for r600 from now on. > > > > - Gert
Re: [EXTERNAL] Re: Zink MR signoff tags
Same for Rusticl On Mon, Oct 17, 2022 at 10:28 PM Jesse Natalie wrote: > > Jumping on the bandwagon, I'm going to adopt this for Microsoft-owned code as > well (src/gallium/d3d12, src/microsoft/*). > > -Jesse > > -Original Message- > From: mesa-dev On Behalf Of Gert > Wollny > Sent: Friday, October 7, 2022 2:37 AM > To: erik.faye-lund ; Alyssa Rosenzweig > ; Mike Blumenkrantz > Cc: ML mesa-dev > Subject: [EXTERNAL] Re: Zink MR signoff tags > > On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > > + for not requiring rb/ab tags ... > > > > I think it's time to think about making this change all over Mesa as > > well. We're deeply in bed with GitLab by now, so I don't think there's > > a realistic chance that this isn't going to just be duplicate info any > > time soon... > > Agreed, I'll certainly do this for r600 from now on. > > - Gert
RE: [EXTERNAL] Re: Zink MR signoff tags
Jumping on the bandwagon, I'm going to adopt this for Microsoft-owned code as well (src/gallium/d3d12, src/microsoft/*). -Jesse -Original Message- From: mesa-dev On Behalf Of Gert Wollny Sent: Friday, October 7, 2022 2:37 AM To: erik.faye-lund ; Alyssa Rosenzweig ; Mike Blumenkrantz Cc: ML mesa-dev Subject: [EXTERNAL] Re: Zink MR signoff tags On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... Agreed, I'll certainly do this for r600 from now on. - Gert
Re: Zink MR signoff tags
On Wed, 2022-10-05 at 17:21 +0200, Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think > there's a realistic chance that this isn't going to just be duplicate > info any time soon... Agreed, I'll certainly do this for r600 from now on. - Gert
Re: Zink MR signoff tags
That's a good idea. Marek On Wed, Oct 5, 2022, 11:22 Erik Faye-Lund wrote: > On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... > > > I kinda like the s-o-b tags but those > > don't require fiddly rebases, just -s in the right place.. > > > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > >Hi, > > >After some vigorous and robust discussion with Erik, we've > > > decided that > > >zink will no longer require any rb/ab/etb tags to be applied to > > > patches in > > >MRs. > > >Following in Turnip's footsteps, any MR that receives sufficient > > > reviewage > > >in gitlab comments can be merged directly with no further action > > >necessary. > > >Mike > > -- > Erik Faye-Lund > Principal Engineer > > Collabora Ltd. > Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United > Kingdom > Registered in England & Wales, no. 5513718 > >
Re: Zink MR signoff tags
> > + for not requiring rb/ab tags ... > > I think it's time to think about making this change all over Mesa as > well. We're deeply in bed with GitLab by now, so I don't think there's > a realistic chance that this isn't going to just be duplicate info any > time soon... I agree, but I don't want to be the one on the hook for the politics if people disagree (as I think some do). > > I kinda like the s-o-b tags but those > > don't require fiddly rebases, just -s in the right place.. > > > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > > Hi, > > > After some vigorous and robust discussion with Erik, we've > > > decided that > > > zink will no longer require any rb/ab/etb tags to be applied to > > > patches in > > > MRs. > > > Following in Turnip's footsteps, any MR that receives sufficient > > > reviewage > > > in gitlab comments can be merged directly with no further action > > > necessary. > > > Mike
Re: Zink MR signoff tags
On Wed, 2022-10-05 at 08:20 -0400, Alyssa Rosenzweig wrote: > + for not requiring rb/ab tags ... I think it's time to think about making this change all over Mesa as well. We're deeply in bed with GitLab by now, so I don't think there's a realistic chance that this isn't going to just be duplicate info any time soon... > I kinda like the s-o-b tags but those > don't require fiddly rebases, just -s in the right place.. > > On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: > > Hi, > > After some vigorous and robust discussion with Erik, we've > > decided that > > zink will no longer require any rb/ab/etb tags to be applied to > > patches in > > MRs. > > Following in Turnip's footsteps, any MR that receives sufficient > > reviewage > > in gitlab comments can be merged directly with no further action > > necessary. > > Mike -- Erik Faye-Lund Principal Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom Registered in England & Wales, no. 5513718
Re: Zink MR signoff tags
+ for not requiring rb/ab tags ... I kinda like the s-o-b tags but those don't require fiddly rebases, just -s in the right place.. On Tue, Oct 04, 2022 at 10:44:31PM -0500, Mike Blumenkrantz wrote: >Hi, >After some vigorous and robust discussion with Erik, we've decided that >zink will no longer require any rb/ab/etb tags to be applied to patches in >MRs. >Following in Turnip's footsteps, any MR that receives sufficient reviewage >in gitlab comments can be merged directly with no further action >necessary. >Mike
Zink MR signoff tags
Hi, After some vigorous and robust discussion with Erik, we've decided that zink will no longer require any rb/ab/etb tags to be applied to patches in MRs. Following in Turnip's footsteps, any MR that receives sufficient reviewage in gitlab comments can be merged directly with no further action necessary. Mike
