Re: [Mesa-dev] Moving v3d_format to broadcom
Hi Andreas, that might indeed be something we want to do for Vulkan. I think moving the defines is fine, however I think that before we start moving data structures and types around we should probably have a very good understanding of what we'll need for Vulkan, and that probably requires that we have a functional enough driver first so we are certain that the data structures we currently have in the GL driver match exactly and optimally what we need for Vulkan and we are not just early guessing. The other reason is that in early stages of development it is just easier to copy what you need and modify it on the go as you make progress in the driver without having to care too much about whether they are shared structures/types affecting another driver and then refactor or generlaize the aspects that you realize can be shared across both drivers a bit later in the process when things are more mature and we have a better understanding of what we can share effectively. Does this make sense to you? Iago On Mon, 2019-12-09 at 18:18 +0100, abergme...@gmx.net wrote: > Anyone objecting to moving struct v3d_format and native defines from > Gallium to Broadcom? > > > I think it would make sense to use it similarly in Vulkan. > > > > > > Cheers > > > Andreas > > ___mesa-dev mailing > listmesa-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On Tue, Dec 10, 2019 at 4:59 PM Dylan Baker wrote: > Quoting Zebediah Figura (2019-12-10 10:58:45) > > On 12/10/19 12:21 PM, Matt Turner wrote: > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker > wrote: > > >> > > >> Hi everyone, > > >> > > >> I think its time we discussed whether we're going to continue to do > patch review > > >> on the mailing list, or if it it should all go through gitlab. I > think we should > > >> stop using the mailing list, here are some reasons: > > >> > > >> 1) Most development is happening on gitlab at this point, patches on > the mailing > > >> list are often overlooked > > >> 2) The mailing list bypasses CI which potentially breaks the build > > >> 3) Probably more reasons I'm forgetting. > > > > > > I think effectively we're already there. > > > > > > What concrete change would you propose? > > > > Removing mention of the mailing list from documentation would be nice. > > Also, currently the README implies that the mailing list is not only > > acceptable but preferred: "Note that Mesa uses email mailing-lists for > > patches submission, review and discussions." > > This would be a good start, I don't know what else to do to stop people > from > sending patches, maybe mailman has some kind of hook we can add to spot > patches > and mention that gitlab is preferred? No idea. > I think updating README type docs is sufficient and I think it's probably time we did that. If someone sends a patch to the ML anyway, we should just go ahead and review it and suggest that next time they open an MR next time. I don't think we need a hook or to do anything more forceful. If the odd patch ends up on the mailing list, it won't hurt anyone. As far about "OMG what if a drive-by person sends a patch!" goes I don't think that's all that likely. New contributors are far more likely to understand the PR model from experience with GitHub than they are to know how to send patches. (Unless they're already a long-time contributor to other systems level Linux projects but new to Mesa). If it does happen, we shouldn't make a big stink about it. We should just review the patch and suggest a pull request for next time. If the patch needs more than just rubber-stamp review, maybe say "I've got some comments, mind making a PR so we can discuss it there?" If people are all that concerned about CI, we can say that if you are pushing patches on behalf of someone else, you should create a MR and merge it that way. --Jason ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On 11/12/19 8:54 am, Alex Deucher wrote: On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: Do we have those and does anyone notice? I personally rarely look at the list now unless I'm CC'd on something. That seems really bad for drive by contributors. But frankly I wouldn't submit to a mailing list as a drive by, it's more work to get subscribed to mail man (so my patch goes through), set up get-send-email, and send the patches, then unsubscribe when I'm done than it would be to sign up for gitlab.fdo using one of the "sign-in-with" options. If you're not subscribed you go into limbo until a list maintainer approves your patch, and I think any follow ups. That seems even worse as most people probably aren't aware of that behavior. Maybe I'm the only one who feels that way though. I've still seen a few. The only ones I've seen recently are from some new ? AMD devs and a few patches from Jonathan Gray who is a long time contributor. Having merge request run though basic CI before merging is enough reason to no longer suggest people use the mailing list for patch submission. I've created a MR to update the docs. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3045 Most drive by contributors generally don't subscribe to the list. Since most lists are moderated, the mail usually makes it through whether they are subscribed or not. That how most projects work. I'm not subscribed to every kernel subsystem list, but my messages usually make it through. If we are proposing to do away with the mailing list, what is the plan for non-patch discussions? Opening issues in gitlab? I don't think this was the suggestion. For non-patch review discussions the list still makes sense. The great thing now is that without patches being sent to the list its easier to actually notice these discussions. Alex Dylan Quoting Alex Deucher (2019-12-10 07:30:43) How do we deal with drive by fixes? E.g., some random user submits a fix but doesn't want to create a gitlab account just to submit a fix? Whoever reviews the patch should submit an MR? Alex On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is happening on gitlab at this point, patches on the mailing list are often overlooked 2) The mailing list bypasses CI which potentially breaks the build 3) Probably more reasons I'm forgetting. Please discuss, Dylan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
Quoting Alex Deucher (2019-12-10 13:54:02) > On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: > > > > Do we have those and does anyone notice? I personally rarely look at the > > list > > now unless I'm CC'd on something. That seems really bad for drive by > > contributors. > > > > But frankly I wouldn't submit to a mailing list as a drive by, it's more > > work to > > get subscribed to mail man (so my patch goes through), set up > > get-send-email, > > and send the patches, then unsubscribe when I'm done than it would be to > > sign up > > for gitlab.fdo using one of the "sign-in-with" options. If you're not > > subscribed > > you go into limbo until a list maintainer approves your patch, and I think > > any > > follow ups. That seems even worse as most people probably aren't aware of > > that > > behavior. Maybe I'm the only one who feels that way though. > > I've still seen a few. Most drive by contributors generally don't > subscribe to the list. Since most lists are moderated, the mail > usually makes it through whether they are subscribed or not. That how > most projects work. I'm not subscribed to every kernel subsystem > list, but my messages usually make it through. If we are proposing to > do away with the mailing list, what is the plan for non-patch > discussions? Opening issues in gitlab? > > Alex I think having non-patch discussions on the mailing list still makes sense, especially since gitlab issues can be klunky and no-one's suggested a good alternative. I'm opened to alternatives that aren't slack :) Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
Quoting Zebediah Figura (2019-12-10 10:58:45) > On 12/10/19 12:21 PM, Matt Turner wrote: > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > >> > >> Hi everyone, > >> > >> I think its time we discussed whether we're going to continue to do patch > >> review > >> on the mailing list, or if it it should all go through gitlab. I think we > >> should > >> stop using the mailing list, here are some reasons: > >> > >> 1) Most development is happening on gitlab at this point, patches on the > >> mailing > >> list are often overlooked > >> 2) The mailing list bypasses CI which potentially breaks the build > >> 3) Probably more reasons I'm forgetting. > > > > I think effectively we're already there. > > > > What concrete change would you propose? > > Removing mention of the mailing list from documentation would be nice. > Also, currently the README implies that the mailing list is not only > acceptable but preferred: "Note that Mesa uses email mailing-lists for > patches submission, review and discussions." This would be a good start, I don't know what else to do to stop people from sending patches, maybe mailman has some kind of hook we can add to spot patches and mention that gitlab is preferred? No idea. > Relatedly, is GitLab preferred also for piglit? The HACKING file there > also specifically prescribes using the mailing list, but I've noticed > that patches submitted to the mailing list by myself and another new > contributor have gone unreviewed for several weeks. I think it is preferred at this point. Maybe we should update both mesa and piglit at the same time. Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On 11/12/19 5:58 am, Zebediah Figura wrote: On 12/10/19 12:21 PM, Matt Turner wrote: On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is happening on gitlab at this point, patches on the mailing list are often overlooked 2) The mailing list bypasses CI which potentially breaks the build 3) Probably more reasons I'm forgetting. I think effectively we're already there. What concrete change would you propose? Removing mention of the mailing list from documentation would be nice. Also, currently the README implies that the mailing list is not only acceptable but preferred: "Note that Mesa uses email mailing-lists for patches submission, review and discussions." I've sent a merge request: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3045 Relatedly, is GitLab preferred also for piglit? The HACKING file there also specifically prescribes using the mailing list, but I've noticed that patches submitted to the mailing list by myself and another new contributor have gone unreviewed for several weeks. Yes we should update the piglit docs also. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: > > Do we have those and does anyone notice? I personally rarely look at the list > now unless I'm CC'd on something. That seems really bad for drive by > contributors. > > But frankly I wouldn't submit to a mailing list as a drive by, it's more work > to > get subscribed to mail man (so my patch goes through), set up get-send-email, > and send the patches, then unsubscribe when I'm done than it would be to sign > up > for gitlab.fdo using one of the "sign-in-with" options. If you're not > subscribed > you go into limbo until a list maintainer approves your patch, and I think any > follow ups. That seems even worse as most people probably aren't aware of that > behavior. Maybe I'm the only one who feels that way though. I've still seen a few. Most drive by contributors generally don't subscribe to the list. Since most lists are moderated, the mail usually makes it through whether they are subscribed or not. That how most projects work. I'm not subscribed to every kernel subsystem list, but my messages usually make it through. If we are proposing to do away with the mailing list, what is the plan for non-patch discussions? Opening issues in gitlab? Alex > > Dylan > > Quoting Alex Deucher (2019-12-10 07:30:43) > > How do we deal with drive by fixes? E.g., some random user submits a > > fix but doesn't want to create a gitlab account just to submit a fix? > > Whoever reviews the patch should submit an MR? > > > > Alex > > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > > > > > Hi everyone, > > > > > > I think its time we discussed whether we're going to continue to do patch > > > review > > > on the mailing list, or if it it should all go through gitlab. I think we > > > should > > > stop using the mailing list, here are some reasons: > > > > > > 1) Most development is happening on gitlab at this point, patches on the > > > mailing > > >list are often overlooked > > > 2) The mailing list bypasses CI which potentially breaks the build > > > 3) Probably more reasons I'm forgetting. > > > > > > Please discuss, > > > Dylan > > > ___ > > > mesa-dev mailing list > > > mesa-dev@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Querying Vulkan driver Options
From: Lionel Landwerlin >> - In case the options are different (which is quite likely), how do we query >> the available options? >> >> For OpenGL we have glXGetScreenDriver/glXGetDriverConfig >> >> For EGL we have eglGetDisplayDriverName/eglGetDisplayDriverConfig [2] >> >> What about Vulkan? How can we query such options? > >I guess you'll have to add an extension to provide the same feature. Do we have any documentation or high level steps on writing a Vulkan extension? >From mesa side, providing a Merge Request with the necessary changes is enough? Kind regards, Jean Hertel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
Do we have those and does anyone notice? I personally rarely look at the list now unless I'm CC'd on something. That seems really bad for drive by contributors. But frankly I wouldn't submit to a mailing list as a drive by, it's more work to get subscribed to mail man (so my patch goes through), set up get-send-email, and send the patches, then unsubscribe when I'm done than it would be to sign up for gitlab.fdo using one of the "sign-in-with" options. If you're not subscribed you go into limbo until a list maintainer approves your patch, and I think any follow ups. That seems even worse as most people probably aren't aware of that behavior. Maybe I'm the only one who feels that way though. Dylan Quoting Alex Deucher (2019-12-10 07:30:43) > How do we deal with drive by fixes? E.g., some random user submits a > fix but doesn't want to create a gitlab account just to submit a fix? > Whoever reviews the patch should submit an MR? > > Alex > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > > > Hi everyone, > > > > I think its time we discussed whether we're going to continue to do patch > > review > > on the mailing list, or if it it should all go through gitlab. I think we > > should > > stop using the mailing list, here are some reasons: > > > > 1) Most development is happening on gitlab at this point, patches on the > > mailing > >list are often overlooked > > 2) The mailing list bypasses CI which potentially breaks the build > > 3) Probably more reasons I'm forgetting. > > > > Please discuss, > > Dylan > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
Adding Daniel (since he could actually turn patchwork off), but I doubt anyone in mesa is using patchwork at this point, I think all of the people who were interested have moved to gitlab. We could probably dump it even if we decide to keep the list. Just my 2¢. Dylan Quoting Marek Olšák (2019-12-09 20:29:48) > Do we plan to remove the patchwork action on push? > > Marek > > On Mon, Dec 9, 2019 at 9:10 PM Roland Scheidegger wrote: > > So, I'm guilty of being one of the few still using the mailing list... > But in any case, certainly I can switch to using MRs if everybody > prefers that now (meaning, I'm really indifferent to this). > > Roland > > > Am 10.12.19 um 00:07 schrieb Dylan Baker: > > Hi everyone, > > > > I think its time we discussed whether we're going to continue to do > patch > review > > on the mailing list, or if it it should all go through gitlab. I think > we > should > > stop using the mailing list, here are some reasons: > > > > 1) Most development is happening on gitlab at this point, patches on the > mailing > > list are often overlooked > > 2) The mailing list bypasses CI which potentially breaks the build > > 3) Probably more reasons I'm forgetting. > > > > Please discuss, > > Dylan > > > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://nam04.safelinks.protection.outlook.com/?url= > https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev > data= > > 02%7C01%7Csroland%40vmware.com%7C1cb75dae042b4427ab2408d77cfc9cdc%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637115296743272638 > sdata=BmiwnAd%2BBZaZqqTwIYn0zqPOQ8jQ1pIzOqtyGhxuEN0%3Dreserved=0 > > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > Hi everyone, > > I think its time we discussed whether we're going to continue to do patch > review > on the mailing list, or if it it should all go through gitlab. I think we > should > stop using the mailing list, here are some reasons: > > 1) Most development is happening on gitlab at this point, patches on the > mailing >list are often overlooked > 2) The mailing list bypasses CI which potentially breaks the build > 3) Probably more reasons I'm forgetting. I think effectively we're already there. What concrete change would you propose? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
On 12/10/19 12:21 PM, Matt Turner wrote: On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is happening on gitlab at this point, patches on the mailing list are often overlooked 2) The mailing list bypasses CI which potentially breaks the build 3) Probably more reasons I'm forgetting. I think effectively we're already there. What concrete change would you propose? Removing mention of the mailing list from documentation would be nice. Also, currently the README implies that the mailing list is not only acceptable but preferred: "Note that Mesa uses email mailing-lists for patches submission, review and discussions." Relatedly, is GitLab preferred also for piglit? The HACKING file there also specifically prescribes using the mailing list, but I've noticed that patches submitted to the mailing list by myself and another new contributor have gone unreviewed for several weeks. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?
How do we deal with drive by fixes? E.g., some random user submits a fix but doesn't want to create a gitlab account just to submit a fix? Whoever reviews the patch should submit an MR? Alex On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > Hi everyone, > > I think its time we discussed whether we're going to continue to do patch > review > on the mailing list, or if it it should all go through gitlab. I think we > should > stop using the mailing list, here are some reasons: > > 1) Most development is happening on gitlab at this point, patches on the > mailing >list are often overlooked > 2) The mailing list bypasses CI which potentially breaks the build > 3) Probably more reasons I'm forgetting. > > Please discuss, > Dylan > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
