Re: [Mesa3d-dev] Remove color index rendering?

[Brian Paul]

On Fri, Feb 26, 2010 at 7:19 PM, Ian Romanick  wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Ian Romanick wrote:
>> While we're on the topic of removing dead weight, can we remove support
>> for color index rendering?  None of the hardware drivers support color
>> index rendering, and color index rendering is deprecated in OpenGL 3.0
>> (and removed in 3.1).
>>
>> Can it please die in a fire?
>
> I have just pushed a branch that removes color-index rendering.  It is
> available for review in the remove_ci_rendering branch of
> git://anongit.freedesktop.org/~idr/mesa.git.  I have done on minimal
> testing so far, but I intend to do more over the weekend.  It took most
> of the week just to get all the changes made.
>
> There are 38 individual patches.  The patches remove a total of 2,304
> lines of code.  I tried to make it easier to review by keeping the
> individual changes small.
>
> There are probably some additional changes that could be made.  There is
> still a bit of index tracking in TNL and other related places.  I think
> some of this can be removed.  Such removals would be more invasive (grep
> for MAT_*_INDEX),

I think you mean the MAT_INDEX_* tokens there.  We can weed out some
of that little stuff over time.


> and may impact our adherence to the spec.  For
> example, some queries would return incorrect values.
>
> In any case, I'm satisfied with this set of removals for now.

The branch looks good.  Just one minor thing: please document CI
removal in the 7.8 release notes file.

-Brian

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Ian Romanick]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Ian Romanick wrote:
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
> 
> Can it please die in a fire?

I have just pushed a branch that removes color-index rendering.  It is
available for review in the remove_ci_rendering branch of
git://anongit.freedesktop.org/~idr/mesa.git.  I have done on minimal
testing so far, but I intend to do more over the weekend.  It took most
of the week just to get all the changes made.

There are 38 individual patches.  The patches remove a total of 2,304
lines of code.  I tried to make it easier to review by keeping the
individual changes small.

There are probably some additional changes that could be made.  There is
still a bit of index tracking in TNL and other related places.  I think
some of this can be removed.  Such removals would be more invasive (grep
for MAT_*_INDEX), and may impact our adherence to the spec.  For
example, some queries would return incorrect values.

In any case, I'm satisfied with this set of removals for now.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuIgUMACgkQX1gOwKyEAw8E+gCdGWJYc1sGhvkeT/Ikg57LcSQb
mNMAn3ks/Xa6Z1z2ziOvqlCP/742OCO+
=oXSE
-END PGP SIGNATURE-

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Kristian Høgsberg]

On Fri, Feb 19, 2010 at 10:43 PM, Corbin Simpson
 wrote:
> Can we doc it and comment it out? IME somebody will pop out and claim a use
> for it.

With git, which lets you search and query history fast and easily,
there's never really and excuse for commenting/#ifdef'ing something
out.  If somebody wants to revive CI rendering, digging it out from
git is going to be the least of his problems.

Kristian

> Posting from a mobile, pardon my terseness. ~ C.
>
> On Feb 19, 2010 5:19 PM, "Ian Romanick"  wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
>
> Can it please die in a fire?
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkt/Kd8ACgkQX1gOwKyEAw+zpQCgj+Yr0Bo3e6O3BijR5KYEds48
> DfIAniZibZEaXZsO0qYa9OW5745LM9xL
> =tcrK
> -END PGP SIGNATURE-
>
> --
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> ___
> Mesa3d-dev mailing list
> Mesa3d-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
>
> --
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> ___
> Mesa3d-dev mailing list
> Mesa3d-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
>
>

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Nathan Kidd]

On 10-02-19 07:16 PM, Ian Romanick wrote:
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
>
> Can it please die in a fire?

As a workaround if someone really wants CI rendering, one can use 
VirtualGL to provide a CI visual on RGB-only hardware.

-Nathan


--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Eric Anholt]

On Fri, 19 Feb 2010 16:16:32 -0800, Ian Romanick  wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
> 
> Can it please die in a fire?

I don't see any plausible justification for CI rendering support.  I'd
love to see it die.


pgpW8J11XpatF.pgp
Description: PGP signature
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Brian Paul]

On Fri, Feb 19, 2010 at 5:16 PM, Ian Romanick  wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
>
> Can it please die in a fire?

I think it can probably go.  I haven't tested CI mode rendering in
many years.  Who knows if it even works any more.

-Brian

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Ian Romanick]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Corbin Simpson wrote:
> Can we doc it and comment it out? IME somebody will pop out and claim a
> use for it.

Search the Mesa source for all of the occurances of 'if
(ctx->Visual.rgbMode)' and you'll see most of the reason I want to
remove it.  Commenting it out or ifdef'ing it out will actually make the
situation much, much worse.

Part of the reason I want to do this is that I'm working on an extension
that allows the creation of a context without a visual / fbconfig.  I
have this mostly working, and I should have patches out early this week.
 The biggest hurdle has been "fixing" all of the places that use
ctx->Visual.  90% or more of those places are checking rgbMode.

Ideally, I'd like ctx->Visual to be completely removed.  99.9% of all
places that use ctx->Visual should actually use ctx->DrawBuffer->Visual.
 I suspect that this accounts for some of the FBO rendering problems
that have been reported over the years.

> Posting from a mobile, pardon my terseness. ~ C.
> 
>> On Feb 19, 2010 5:19 PM, "Ian Romanick" > > wrote:
>>
> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
> 
> Can it please die in a fire?

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuBt+QACgkQX1gOwKyEAw+8DACfSXYLr9mh1k06Ri+29NBjNKfn
wSYAnjRD3Eu4ZpeSkgOiBIOk7h1d2pJw
=LhpN
-END PGP SIGNATURE-

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Ian Romanick]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Patrice Mandin wrote:
> Le Fri, 19 Feb 2010 16:16:32 -0800
> Ian Romanick  a écrit:
> 
>> While we're on the topic of removing dead weight, can we remove support
>> for color index rendering?  None of the hardware drivers support color
>> index rendering, and color index rendering is deprecated in OpenGL 3.0
>> (and removed in 3.1).
>>
>> Can it please die in a fire?
> 
> Well, I think it could be done for Gallium backends. Nvidia hw supports
> color indexed textures from nv04 (TNT) to nv30 (Geforce FX). It was
> removed since nv40.
> 
> Do you want it to be removed in all hardware backends (i.e. also dri
> ones) ?

I'm talking about rendering *to* a color index target.  As far as I'm
aware, none of the hardware drivers have ever supported this.  Color
index textures are an orthogonal issue, and they can stay.

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuBtiwACgkQX1gOwKyEAw/0FQCgkFgSZsGnnZZFoe/b+EAUC2hZ
SvkAnjsKwvUMYJspDVmwq2s/lo3FSFb+
=mJcX
-END PGP SIGNATURE-

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Patrice Mandin]

Le Fri, 19 Feb 2010 16:16:32 -0800
Ian Romanick  a écrit:

> While we're on the topic of removing dead weight, can we remove support
> for color index rendering?  None of the hardware drivers support color
> index rendering, and color index rendering is deprecated in OpenGL 3.0
> (and removed in 3.1).
> 
> Can it please die in a fire?

Well, I think it could be done for Gallium backends. Nvidia hw supports
color indexed textures from nv04 (TNT) to nv30 (Geforce FX). It was
removed since nv40.

Do you want it to be removed in all hardware backends (i.e. also dri
ones) ?

-- 
Patrice Mandin
WWW: http://pmandin.atari.org/
Programmeur Linux, Atari
Spécialité: Développement, jeux




--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Re: [Mesa3d-dev] Remove color index rendering?

[Corbin Simpson]

Can we doc it and comment it out? IME somebody will pop out and claim a use
for it.

Posting from a mobile, pardon my terseness. ~ C.

On Feb 19, 2010 5:19 PM, "Ian Romanick"  wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

While we're on the topic of removing dead weight, can we remove support
for color index rendering?  None of the hardware drivers support color
index rendering, and color index rendering is deprecated in OpenGL 3.0
(and removed in 3.1).

Can it please die in a fire?
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt/Kd8ACgkQX1gOwKyEAw+zpQCgj+Yr0Bo3e6O3BijR5KYEds48
DfIAniZibZEaXZsO0qYa9OW5745LM9xL
=tcrK
-END PGP SIGNATURE-

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Mesa3d-dev] Remove color index rendering?

[Ian Romanick]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

While we're on the topic of removing dead weight, can we remove support
for color index rendering?  None of the hardware drivers support color
index rendering, and color index rendering is deprecated in OpenGL 3.0
(and removed in 3.1).

Can it please die in a fire?
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt/Kd8ACgkQX1gOwKyEAw+zpQCgj+Yr0Bo3e6O3BijR5KYEds48
DfIAniZibZEaXZsO0qYa9OW5745LM9xL
=tcrK
-END PGP SIGNATURE-

--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev