Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-15 Thread Zhenhua Luo 
Thanks, Otavio.

We will check patches of the undocumented changes and rework those patches. 


Best Regards, 

Zhenhua

> -Original Message-
> From: Otavio Salvador [mailto:otavio.salva...@ossystems.com.br]
> Sent: Saturday, October 14, 2017 1:21 AM
> To: Zhenhua Luo <zhenhua@nxp.com>
> Cc: C.r. Guo <chunrong@nxp.com>; meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c
> 
> On Fri, Oct 13, 2017 at 12:34 AM, Zhenhua Luo <zhenhua@nxp.com> wrote:
> > Thanks for your review and suggestion.
> >
> > Currently the github is just for source code publish instead of a 
> > collaboration
> platform for LSDK, we may migrate to a new SCM tool in the near future.
> Regarding the individual patch, I agree with you to manage the general fix 
> patch
> in git tree instead of in Yocto, actually we are working with the internal 
> package
> maintainer on submitting and merging the patch, the testing effort is also
> needed in LSDK environment before sync the patch to github. To ensure our
> release schedule, can we keep it as individual patch firstly and add a 
> Upstream-
> Status field in the patch to track the status, we will update Yocto recipe if 
> the
> patch is merged and synced to github.
> 
> I thought the move to github will allow for a more collaborative work.
> Sad it is not the case.
> 
> Please see the several no documented changes made and please work on a new
> patchset.
> 
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-13 Thread Otavio Salvador 
On Fri, Oct 13, 2017 at 12:34 AM, Zhenhua Luo  wrote:
> Thanks for your review and suggestion.
>
> Currently the github is just for source code publish instead of a 
> collaboration platform for LSDK, we may migrate to a new SCM tool in the near 
> future. Regarding the individual patch, I agree with you to manage the 
> general fix patch in git tree instead of in Yocto, actually we are working 
> with the internal package maintainer on submitting and merging the patch, the 
> testing effort is also needed in LSDK environment before sync the patch to 
> github. To ensure our release schedule, can we keep it as individual patch 
> firstly and add a Upstream-Status field in the patch to track the status, we 
> will update Yocto recipe if the patch is merged and synced to github.

I thought the move to github will allow for a more collaborative work.
Sad it is not the case.

Please see the several no documented changes made and please work on a
new patchset.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-12 Thread Zhenhua Luo 
Hi Otavio, 

Thanks for your review and suggestion. 

Currently the github is just for source code publish instead of a collaboration 
platform for LSDK, we may migrate to a new SCM tool in the near future. 
Regarding the individual patch, I agree with you to manage the general fix 
patch in git tree instead of in Yocto, actually we are working with the 
internal package maintainer on submitting and merging the patch, the testing 
effort is also needed in LSDK environment before sync the patch to github. To 
ensure our release schedule, can we keep it as individual patch firstly and add 
a Upstream-Status field in the patch to track the status, we will update Yocto 
recipe if the patch is merged and synced to github. 


Best Regards, 

Zhenhua

> -Original Message-
> From: meta-freescale-boun...@yoctoproject.org [mailto:meta-freescale-
> boun...@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Friday, October 13, 2017 3:59 AM
> To: C.r. Guo <chunrong@nxp.com>
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c
> 
> On Wed, Oct 11, 2017 at 11:57 PM, C.r. Guo <chunrong@nxp.com> wrote:
> > Thanks for your comments.
> >
> > Currently the github is for publishing the source code of LSDK after fully 
> > testing.
> I will submit the patch in the internal tree firstly, when testing is done, 
> the github
> tree will be synced and related recipe will be updated accordingly.
> >
> > We plan to support LSDK 17.09 in NXP BSP of Yocto 2.4,  can we apply the
> individual patch in Yocto layer firstly? We can begin the testing for new  
> NXP BSP
> as early as  possible.
> 
> If the patch is good enough for you to send for us to include on OE layer, it 
> must
> be good enough to be merged on github. Also it makes no sense to get the
> github setup if nobody can send patches and QorIQ team does not adopt a more
> collaborative approach ...
> 
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
> --
> ___
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-12 Thread Otavio Salvador 
On Wed, Oct 11, 2017 at 11:57 PM, C.r. Guo  wrote:
> Thanks for your comments.
>
> Currently the github is for publishing the source code of LSDK after fully 
> testing. I will submit the patch in the internal tree firstly, when testing 
> is done, the github  tree will be synced and related recipe will be updated 
> accordingly.
>
> We plan to support LSDK 17.09 in NXP BSP of Yocto 2.4,  can we apply the 
> individual patch in Yocto layer firstly? We can begin the testing for new  
> NXP BSP as early as  possible.

If the patch is good enough for you to send for us to include on OE
layer, it must be good enough to be merged on github. Also it makes no
sense to get the github setup if nobody can send patches and QorIQ
team does not adopt a more collaborative approach ...

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-11 Thread C.r. Guo 
Hi Otavio, 

Thanks for your comments. 

Currently the github is for publishing the source code of LSDK after fully 
testing. I will submit the patch in the internal tree firstly, when testing is 
done, the github  tree will be synced and related recipe will be updated 
accordingly.

We plan to support LSDK 17.09 in NXP BSP of Yocto 2.4,  can we apply the 
individual patch in Yocto layer firstly? We can begin the testing for new  NXP 
BSP as early as  possible. 


Thanks,   

Chunrong

-Original Message-
From: Otavio Salvador [mailto:otavio.salva...@ossystems.com.br] 
Sent: Wednesday, October 11, 2017 9:00 PM
To: Chunrong Guo <b40...@freescale.com>
Cc: meta-freescale@yoctoproject.org; C.r. Guo <chunrong@nxp.com>
Subject: Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

On Tue, Oct 10, 2017 at 6:42 AM, Chunrong Guo <b40...@freescale.com> wrote:
> From: Chunrong Guo <chunrong@nxp.com>
>
> This includes the following changes:
> 1afb40c - Make SRK table default option
> 1650003 - Make ls1088_ls2088.sh executable 4ae056a - Generate SRK hash 
> value
> c3e7c34 - LS1088 QSPI: Change in address in input file fe4e0da - 
> LS104x_1012: Add signing of bootscript_decap in case of NAND
> 8f42212 - LS1088 SD: Add input files for LS1088ardb SD
> 88b3f45 - Merge pull request #73 in SDK/cst from 
> ~B57223/cst-create-pbi:master to master
> 63bfb68 - To enable blob, added input file
> d124628 - LS1021ATWR: Change SPL hdr load address 12c489f - 
> LS2088_1088: Add uni_sign input files for sd boot
> 04ac1a0 - LS2088_1088: Sample uni_pbi input file for sd boot
> 23bf3b7 - LS2088_1088: Modify tool to add pbi commands for sd secure
> 46f4045 - Enable cmd line flag "--u" urand option for gen_otpmk_drbg
>
> Signed-off-by: Chunrong Guo <b40...@freescale.com>

There are also pending patches here; it makes sense to apply this to github and 
just update the hash here.


-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-11 Thread Otavio Salvador 
On Tue, Oct 10, 2017 at 6:42 AM, Chunrong Guo  wrote:
> From: Chunrong Guo 
>
> This includes the following changes:
> 1afb40c - Make SRK table default option
> 1650003 - Make ls1088_ls2088.sh executable
> 4ae056a - Generate SRK hash value
> c3e7c34 - LS1088 QSPI: Change in address in input file
> fe4e0da - LS104x_1012: Add signing of bootscript_decap in case of NAND
> 8f42212 - LS1088 SD: Add input files for LS1088ardb SD
> 88b3f45 - Merge pull request #73 in SDK/cst from 
> ~B57223/cst-create-pbi:master to master
> 63bfb68 - To enable blob, added input file
> d124628 - LS1021ATWR: Change SPL hdr load address
> 12c489f - LS2088_1088: Add uni_sign input files for sd boot
> 04ac1a0 - LS2088_1088: Sample uni_pbi input file for sd boot
> 23bf3b7 - LS2088_1088: Modify tool to add pbi commands for sd secure
> 46f4045 - Enable cmd line flag "--u" urand option for gen_otpmk_drbg
>
> Signed-off-by: Chunrong Guo 

There are also pending patches here; it makes sense to apply this to
github and just update the hash here.


-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

[meta-freescale] [PATCH 03/20] cst :update to 1afb40c

2017-10-10 Thread Chunrong Guo 
From: Chunrong Guo 

This includes the following changes:
1afb40c - Make SRK table default option
1650003 - Make ls1088_ls2088.sh executable
4ae056a - Generate SRK hash value
c3e7c34 - LS1088 QSPI: Change in address in input file
fe4e0da - LS104x_1012: Add signing of bootscript_decap in case of NAND
8f42212 - LS1088 SD: Add input files for LS1088ardb SD
88b3f45 - Merge pull request #73 in SDK/cst from ~B57223/cst-create-pbi:master 
to master
63bfb68 - To enable blob, added input file
d124628 - LS1021ATWR: Change SPL hdr load address
12c489f - LS2088_1088: Add uni_sign input files for sd boot
04ac1a0 - LS2088_1088: Sample uni_pbi input file for sd boot
23bf3b7 - LS2088_1088: Modify tool to add pbi commands for sd secure
46f4045 - Enable cmd line flag "--u" urand option for gen_otpmk_drbg

Signed-off-by: Chunrong Guo 
---
 ...rbg-fails-compilation-due-to-uninitialize.patch | 28 ++
 recipes-devtools/cst/cst_git.bb|  6 +++--
 2 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 
recipes-devtools/cst/cst/0001-gen_otpmk_drbg-fails-compilation-due-to-uninitialize.patch

diff --git 
a/recipes-devtools/cst/cst/0001-gen_otpmk_drbg-fails-compilation-due-to-uninitialize.patch
 
b/recipes-devtools/cst/cst/0001-gen_otpmk_drbg-fails-compilation-due-to-uninitialize.patch
new file mode 100644
index 000..0dc5c3a
--- /dev/null
+++ 
b/recipes-devtools/cst/cst/0001-gen_otpmk_drbg-fails-compilation-due-to-uninitialize.patch
@@ -0,0 +1,28 @@
+From 6eb82ed1ba56c398e89f04fb848c5f3c4543e772 Mon Sep 17 00:00:00 2001
+From: Chunrong Guo 
+Date: Wed, 20 Sep 2017 13:22:34 +0800
+Subject: [PATCH] gen_otpmk_drbg: fails compilation due to uninitialized
+ variables
+
+Upstream-Status: Submitted
+Signed-off-by: Chunrong Guo 
+---
+ tools/key_generation/gen_otpmk_drbg.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/key_generation/gen_otpmk_drbg.c 
b/tools/key_generation/gen_otpmk_drbg.c
+index 6465367..33e5ea6 100644
+--- a/tools/key_generation/gen_otpmk_drbg.c
 b/tools/key_generation/gen_otpmk_drbg.c
+@@ -142,7 +142,7 @@ int main(int argc, char *argv[])
+ {
+   char otpmk_in[2];
+   int c, i, l, ret;
+-  char *string;
++  char *string = NULL;
+   char urand_flag = 0;
+ 
+   printf("\n\t##");
+-- 
+2.7.4
+
diff --git a/recipes-devtools/cst/cst_git.bb b/recipes-devtools/cst/cst_git.bb
index fcae0c7..dc0ae5e 100644
--- a/recipes-devtools/cst/cst_git.bb
+++ b/recipes-devtools/cst/cst_git.bb
@@ -9,8 +9,10 @@ RDEPENDS_${PN} = "bash"
 
 inherit kernel-arch
 
-SRC_URI = "git://github.com/qoriq-open-source/cst.git;nobranch=1"
-SRCREV = "6424157985568df3f42a46e24222e38671455ddb"
+SRC_URI = "git://github.com/qoriq-open-source/cst.git;nobranch=1 \
+file://0001-gen_otpmk_drbg-fails-compilation-due-to-uninitialize.patch \
+"
+SRCREV = "1afb40c13097fc9e8a641aa5d0420498fea01c65"
 
 S = "${WORKDIR}/git"
 
-- 
1.9.0

-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale