[meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. Signed-off-by: Ross Burton ross.bur...@intel.com --- .../xserver-xf86-config/chiefriver/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/crownbay-noemgd/xorg.conf | 26 .../xserver-xf86-config/crownbay/xorg.conf |5 --- .../crystalforest-gladden/xorg.conf| 26 .../crystalforest-server/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/emenlow-noemgd/xorg.conf |5 --- .../xserver-xf86-config/emenlow/xorg.conf |5 --- .../xserver-xf86-config/fri2-noemgd/xorg.conf | 26 .../xserver-xf86-config/fri2/xorg.conf |5 --- .../xserver-xf86-config/jasperforest/xorg.conf | 32 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/n450/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xorg-xserver/xserver-xf86-config/nuc/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/romley-ivb/xorg.conf | 26 .../xserver-xf86-config/romley/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sugarbay/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sys940x-noemgd/xorg.conf | 26 .../xserver-xf86-config/sys940x/xorg.conf |5 --- 24 files changed, 350 deletions(-) delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay-noemgd/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-gladden/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-server/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-fri2/recipes-graphics/xorg-xserver/xserver-xf86-config/fri2-noemgd/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config/jasperforest/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config/nuc/xorg.conf delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley-ivb/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config/sugarbay/xorg.conf delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sys940x/recipes-graphics/xorg-xserver/xserver-xf86-config/sys940x-noemgd/xorg.conf diff --git a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf b/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf deleted file mode 100644 index 96b94b4..000 --- a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf +++ /dev/null @@ -1,26 +0,0 @@ -Section Device -Identifier Intel Graphics Driver -Driver intel -EndSection - -Section Monitor -IdentifierGeneric Monitor -OptionDPMS -EndSection - -Section Screen -IdentifierDefault Screen -Device Intel Graphics Driver -Monitor Generic Monitor -DefaultDepth 24 -EndSection - -Section ServerLayout -Identifier Default Layout -Screen Default Screen -EndSection - -Section ServerFlags -OptionDontZap 0 -Option
[meta-intel] [PATCH][minnowboard] xserver-xf86-config: allow hotplugged input
DontZap defaults to 0 anyway, and AutoAddDevices=False means that hotplugged input devices won't work. Signed-off-by: Ross Burton ross.bur...@intel.com --- .../xorg-xserver/xserver-xf86-config/minnow/xorg.conf |5 - 1 file changed, 5 deletions(-) diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-config/minnow/xorg.conf b/recipes-graphics/xorg-xserver/xserver-xf86-config/minnow/xorg.conf index 6d3ad1b..cf0ddfe 100644 --- a/recipes-graphics/xorg-xserver/xserver-xf86-config/minnow/xorg.conf +++ b/recipes-graphics/xorg-xserver/xserver-xf86-config/minnow/xorg.conf @@ -59,8 +59,3 @@ Section ServerLayout # InputDeviceKeyboard0 CoreKeyboard # InputDeviceDevInputMice SendCoreEvents EndSection - -Section ServerFlags -OptionDontZap 0 -OptionAutoAddDevices False -EndSection -- 1.7.10.4 ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. Which of these BSPs did you test and verify work after this patch? Thanks, Darren Signed-off-by: Ross Burton ross.bur...@intel.com --- .../xserver-xf86-config/chiefriver/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/crownbay-noemgd/xorg.conf | 26 .../xserver-xf86-config/crownbay/xorg.conf |5 --- .../crystalforest-gladden/xorg.conf| 26 .../crystalforest-server/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/emenlow-noemgd/xorg.conf |5 --- .../xserver-xf86-config/emenlow/xorg.conf |5 --- .../xserver-xf86-config/fri2-noemgd/xorg.conf | 26 .../xserver-xf86-config/fri2/xorg.conf |5 --- .../xserver-xf86-config/jasperforest/xorg.conf | 32 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/n450/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xorg-xserver/xserver-xf86-config/nuc/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/romley-ivb/xorg.conf | 26 .../xserver-xf86-config/romley/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sugarbay/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sys940x-noemgd/xorg.conf | 26 .../xserver-xf86-config/sys940x/xorg.conf |5 --- 24 files changed, 350 deletions(-) delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay-noemgd/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-gladden/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-server/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-fri2/recipes-graphics/xorg-xserver/xserver-xf86-config/fri2-noemgd/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config/jasperforest/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config/nuc/xorg.conf delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley-ivb/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config/sugarbay/xorg.conf delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sys940x/recipes-graphics/xorg-xserver/xserver-xf86-config/sys940x-noemgd/xorg.conf diff --git a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf b/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf deleted file mode 100644 index 96b94b4..000 --- a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf +++ /dev/null @@ -1,26 +0,0 @@ -Section Device -Identifier Intel Graphics Driver -Driver intel -EndSection - -Section
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. Ross ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On 19 September 2013 00:43, Burton, Ross ross.bur...@intel.com wrote: Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. The same patch series but split per BSP is now at http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-contrib/log/?h=ross/xorg. Ross ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
