Re: [meta-intel] [PATCH] canterbury-corpus: Use base_libdir in FILES

2016-05-23 Thread Jussi Kukkonen 
On 23 May 2016 at 14:48, Burton, Ross  wrote:
>
> On 23 May 2016 at 12:41, Jussi Kukkonen  wrote:
>>
>> -FILES_${PN} = "/lib/firmware/*"
>> +FILES_${PN} = "${base_libdir}/firmware/*"
>
> If these files are being loaded by the kernel firmware loader then /lib is
> right and the rest of the recipe is wrong.

So I doubt they're loaded by the firmware loader (they are random data
files, a compression test corpus) but maybe they are being used in a
test inside the kernel and the firmware directory is hack to find
them?

I'm CCing some people who have touched the qat16 recipe lately (as it
seems to do similar things).

Rahul or Anuj: The issue is that canterbury-corpus fails to package if
$base_libdir != "/lib/".  Do you know whether the canterbury-corpus
recipe is actually used by something (I'm asking since qat16 seems to
install practically the same data itself)? If it is used, should the
files be installed into /lib/ ?

Jussi
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] canterbury-corpus: Use base_libdir in FILES

2016-05-23 Thread Jussi Kukkonen 
On 23 May 2016 at 14:48, Burton, Ross  wrote:
>
> On 23 May 2016 at 12:41, Jussi Kukkonen  wrote:
>>
>> -FILES_${PN} = "/lib/firmware/*"
>> +FILES_${PN} = "${base_libdir}/firmware/*"
>
>
> If these files are being loaded by the kernel firmware loader then /lib is
> right and the rest of the recipe is wrong.

I see, I'll find out if that's the case and resend.

Thanks

> Ross
>
> -
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] canterbury-corpus: Use base_libdir in FILES

2016-05-23 Thread Burton, Ross 
On 23 May 2016 at 12:41, Jussi Kukkonen  wrote:

> -FILES_${PN} = "/lib/firmware/*"
> +FILES_${PN} = "${base_libdir}/firmware/*"
>

If these files are being loaded by the kernel firmware loader then /lib is
right and the rest of the recipe is wrong.

Ross
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

[meta-intel] [PATCH] canterbury-corpus: Use base_libdir in FILES

2016-05-23 Thread Jussi Kukkonen 
Signed-off-by: Jussi Kukkonen 
---
 common/recipes-corpus/canterbury-corpus/canterbury-corpus.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/recipes-corpus/canterbury-corpus/canterbury-corpus.bb 
b/common/recipes-corpus/canterbury-corpus/canterbury-corpus.bb
index db64e53..f54e87b 100644
--- a/common/recipes-corpus/canterbury-corpus/canterbury-corpus.bb
+++ b/common/recipes-corpus/canterbury-corpus/canterbury-corpus.bb
@@ -15,7 +15,7 @@ SRC_URI = 
"http://corpus.canterbury.ac.nz/resources/cantrbry.tar.gz;subdir=${BP}
 SRC_URI[md5sum] = "442e56cfffdf460d25b0b91650a55908"
 SRC_URI[sha256sum] = 
"f140e8a5b73d3f53198555a63bfb827889394a42f20825df33c810c3d5e3f8fb"
 
-FILES_${PN} = "/lib/firmware/*"
+FILES_${PN} = "${base_libdir}/firmware/*"
 
 do_install () {
# do_unpack creates this directory but we don't want to install it, so
-- 
2.1.4

-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel