Re: [meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
On 08/12/2015 08:15 PM, Pengyu Ma wrote:
# ~/checkbashisms -f
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients
possible bashism in
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients line 3
(bash arrays, ${name[0|*|@]}):
SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
possible bashism in
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients line 3
($BASH_SOMETHING):
SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
It seems there are some bash specific script.
Shall bash is rdepended in this package instead of remove bash?
Yes, if there are bashisms that can not be fixed easily then we should
have a RDEPENDS = bash added to the recipe to ensure bash is installed
for these tools.
Sau!
Pengyu
On 08/12/2015 11:33 PM, Burton, Ross wrote:
On 12 August 2015 at 16:17, Saul Wold s...@linux.intel.com
mailto:s...@linux.intel.com wrote:
If you are running on a system with bash the /bin/sh will point to
bash so there is no real change, the real test is to install these
tools on a system without Bash and ensure they work.
Or run checkbashisms, or just read the scripts.
Ross
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
On 08/13/2015 11:10 PM, Saul Wold wrote:
On 08/12/2015 08:15 PM, Pengyu Ma wrote:
# ~/checkbashisms -f
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients
possible bashism in
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients line 3
(bash arrays, ${name[0|*|@]}):
SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
possible bashism in
/usr/lib64/intel-gpu-tools/intel-gpu-tools/check_drm_clients line 3
($BASH_SOMETHING):
SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
It seems there are some bash specific script.
Shall bash is rdepended in this package instead of remove bash?
Yes, if there are bashisms that can not be fixed easily then we should
have a RDEPENDS = bash added to the recipe to ensure bash is
installed for these tools.
OK, I will send V4 version.
Pengyu
Sau!
Pengyu
On 08/12/2015 11:33 PM, Burton, Ross wrote:
On 12 August 2015 at 16:17, Saul Wold s...@linux.intel.com
mailto:s...@linux.intel.com wrote:
If you are running on a system with bash the /bin/sh will point to
bash so there is no real change, the real test is to install these
tools on a system without Bash and ensure they work.
Or run checkbashisms, or just read the scripts.
Ross
--
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
On 08/12/2015 02:37 AM, Pengyu Ma wrote: I have installed intel-gpu-tools on my broadwell-u board, run kms_sysfs_edid_timing and other tests, most of them have no output, one example log: /usr/lib64/intel-gpu-tools/intel-gpu-tools/drv_missed_irq_hang Interrupts masked Interrupts unmasked Cleared missed interrupts If you are running on a system with bash the /bin/sh will point to bash so there is no real change, the real test is to install these tools on a system without Bash and ensure they work. Sau! Pengyu On 08/12/2015 04:59 PM, Burton, Ross wrote: On 12 August 2015 at 04:42, Pengyu Ma pengyu...@windriver.com mailto:pengyu...@windriver.com wrote: * Remove bash dependency. Did you verify that the scripts are not actually bash scripts and can simply be changed to use /bin/sh? Ross -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
On 12 August 2015 at 16:17, Saul Wold s...@linux.intel.com wrote: If you are running on a system with bash the /bin/sh will point to bash so there is no real change, the real test is to install these tools on a system without Bash and ensure they work. Or run checkbashisms, or just read the scripts. Ross -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
I have installed intel-gpu-tools on my broadwell-u board, run kms_sysfs_edid_timing and other tests, most of them have no output, one example log: /usr/lib64/intel-gpu-tools/intel-gpu-tools/drv_missed_irq_hang Interrupts masked Interrupts unmasked Cleared missed interrupts Pengyu On 08/12/2015 04:59 PM, Burton, Ross wrote: On 12 August 2015 at 04:42, Pengyu Ma pengyu...@windriver.com mailto:pengyu...@windriver.com wrote: * Remove bash dependency. Did you verify that the scripts are not actually bash scripts and can simply be changed to use /bin/sh? Ross -- ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
[meta-intel] [PATCH v3] intel-gpu-tools: upgrade to version 1.11
Disable gtk-doc to fix building error.
Add libunwind package config to fix denpendece.
Changes since v2:
* Remove bash dependency.
Changes since v1:
* Add libunwind package config.
Signed-off-by: Pengyu Ma pengyu...@windriver.com
---
...001-test-script-remove-dependency-on-bash.patch | 146 +
...el-gpu-tools_1.9.bb = intel-gpu-tools_1.11.bb} | 12 +-
2 files changed, 156 insertions(+), 2 deletions(-)
create mode 100644
common/recipes-graphics/intel-gpu-tools/intel-gpu-tools/0001-test-script-remove-dependency-on-bash.patch
rename common/recipes-graphics/intel-gpu-tools/{intel-gpu-tools_1.9.bb =
intel-gpu-tools_1.11.bb} (62%)
diff --git
a/common/recipes-graphics/intel-gpu-tools/intel-gpu-tools/0001-test-script-remove-dependency-on-bash.patch
b/common/recipes-graphics/intel-gpu-tools/intel-gpu-tools/0001-test-script-remove-dependency-on-bash.patch
new file mode 100644
index 000..e93ab64
--- /dev/null
+++
b/common/recipes-graphics/intel-gpu-tools/intel-gpu-tools/0001-test-script-remove-dependency-on-bash.patch
@@ -0,0 +1,146 @@
+From a46007ee1644522775c5e429310e0637946818fd Mon Sep 17 00:00:00 2001
+From: Pengyu Ma pengyu...@windriver.com
+Date: Wed, 12 Aug 2015 11:01:36 +0800
+Subject: [PATCH] test/script: remove dependency on bash
+
+use /bin/sh instead.
+
+Signed-off-by: Pengyu Ma pengyu...@windriver.com
+---
+ scripts/run-tests.sh| 2 +-
+ scripts/who.sh | 2 +-
+ tests/check_drm_clients | 2 +-
+ tests/ddx_intel_after_fbdev | 2 +-
+ tests/debugfs_emon_crash| 2 +-
+ tests/drv_debugfs_reader| 2 +-
+ tests/drv_missed_irq_hang | 2 +-
+ tests/drv_module_reload | 2 +-
+ tests/kms_sysfs_edid_timing | 2 +-
+ tests/sysfs_l3_parity | 2 +-
+ tests/test_rte_check| 2 +-
+ tests/tools_test| 2 +-
+ 12 files changed, 12 insertions(+), 12 deletions(-)
+
+diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
+index d72fc05..f269567 100755
+--- a/scripts/run-tests.sh
b/scripts/run-tests.sh
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # Copyright © 2014 Intel Corporation
+ #
+diff --git a/scripts/who.sh b/scripts/who.sh
+index b221639..205cdca 100755
+--- a/scripts/who.sh
b/scripts/who.sh
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # usage: sudo who.sh
+ #
+diff --git a/tests/check_drm_clients b/tests/check_drm_clients
+index eb12416..fed00cd 100755
+--- a/tests/check_drm_clients
b/tests/check_drm_clients
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+
+ SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
+ . $SOURCE_DIR/drm_lib.sh
+diff --git a/tests/ddx_intel_after_fbdev b/tests/ddx_intel_after_fbdev
+index bcd2c29..cc3b7cf 100755
+--- a/tests/ddx_intel_after_fbdev
b/tests/ddx_intel_after_fbdev
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # Testcase: Load Intel DDX after fbdev was loaded
+ #
+diff --git a/tests/debugfs_emon_crash b/tests/debugfs_emon_crash
+index 809bfab..2e18963 100755
+--- a/tests/debugfs_emon_crash
b/tests/debugfs_emon_crash
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # This check if we can crash the kernel with segmentation-fault
+ # by reading /sys/kernel/debug/dri/0/i915_emon_status too quickly
+diff --git a/tests/drv_debugfs_reader b/tests/drv_debugfs_reader
+index 9e2845e..23e9c32 100755
+--- a/tests/drv_debugfs_reader
b/tests/drv_debugfs_reader
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+
+ SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
+ . $SOURCE_DIR/drm_lib.sh
+diff --git a/tests/drv_missed_irq_hang b/tests/drv_missed_irq_hang
+index 6e8cfc2..8285bc0 100755
+--- a/tests/drv_missed_irq_hang
b/tests/drv_missed_irq_hang
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # Testcase: Simulate missed breadcrumb interrupts
+ #
+diff --git a/tests/drv_module_reload b/tests/drv_module_reload
+index bb29a64..e0398d0 100755
+--- a/tests/drv_module_reload
b/tests/drv_module_reload
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # Testcase: Reload the drm module
+ #
+diff --git a/tests/kms_sysfs_edid_timing b/tests/kms_sysfs_edid_timing
+index ec704f6..e90e374 100755
+--- a/tests/kms_sysfs_edid_timing
b/tests/kms_sysfs_edid_timing
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+ #
+ # This check the time we take to read the content of all the possible
connectors.
+ # Without the edid -ENXIO patch
(http://permalink.gmane.org/gmane.comp.video.dri.devel/62083),
+diff --git a/tests/sysfs_l3_parity b/tests/sysfs_l3_parity
+index 9bd1724..02f763b 100755
+--- a/tests/sysfs_l3_parity
b/tests/sysfs_l3_parity
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+
+ SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
+ . $SOURCE_DIR/drm_lib.sh
+diff --git a/tests/test_rte_check b/tests/test_rte_check
+index eb12416..fed00cd 100755
+--- a/tests/test_rte_check
b/tests/test_rte_check
+@@ -1,4 +1,4 @@
+-#!/bin/bash
++#!/bin/sh
+
+ SOURCE_DIR=$( dirname ${BASH_SOURCE[0]} )
+ . $SOURCE_DIR/drm_lib.sh
+diff --git a/tests/tools_test b/tests/tools_test
+index a6178e1..5f2d1dc 100755
+---
