Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Fri, 2013-09-20 at 21:26 +, Kamble, Nitin A wrote: -Original Message- From: Zanussi, Tom Sent: Friday, September 20, 2013 2:20 PM To: Kamble, Nitin A Cc: Darren Hart; meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Fri, 2013-09-20 at 16:14 -0500, Kamble, Nitin A wrote: -Original Message- From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- boun...@yoctoproject.org] On Behalf Of Darren Hart Sent: Friday, September 20, 2013 2:11 PM To: Zanussi, Tom Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Thu, 2013-09-19 at 09:35 -0500, Tom Zanussi wrote: On Thu, 2013-09-19 at 00:43 +0100, Burton, Ross wrote: On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. I pulled in the nuc changes, but will wait for the individual BSP owners to ack the changes for their BSPs before pulling in the others. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. And of course Darren will need to pull in the minnow changes. With the minnow tested now tested, I'm happy to see FRI2, SYS940x, and Crownbay go in. In fact, that's enough I think for the series to go. Any other objections? Darren, Ross, How are you testing? Just deleting file on the target? I am finding the commit is causing build failure for NUC. Hmm, I did a nuc build before pulling it in and didn't see any problems here.. Then failure I am seeing must be due to my additional layer, looking for the xorg.conf file. Sorry about the noise. I'm building sugarbay, n450, and jasperforest with ross's branch. Will report back. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
-Original Message- From: Zanussi, Tom Sent: Friday, September 20, 2013 2:20 PM To: Kamble, Nitin A Cc: Darren Hart; meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Fri, 2013-09-20 at 16:14 -0500, Kamble, Nitin A wrote: -Original Message- From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- boun...@yoctoproject.org] On Behalf Of Darren Hart Sent: Friday, September 20, 2013 2:11 PM To: Zanussi, Tom Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Thu, 2013-09-19 at 09:35 -0500, Tom Zanussi wrote: On Thu, 2013-09-19 at 00:43 +0100, Burton, Ross wrote: On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. I pulled in the nuc changes, but will wait for the individual BSP owners to ack the changes for their BSPs before pulling in the others. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. And of course Darren will need to pull in the minnow changes. With the minnow tested now tested, I'm happy to see FRI2, SYS940x, and Crownbay go in. In fact, that's enough I think for the series to go. Any other objections? Darren, Ross, How are you testing? Just deleting file on the target? I am finding the commit is causing build failure for NUC. Hmm, I did a nuc build before pulling it in and didn't see any problems here.. Then failure I am seeing must be due to my additional layer, looking for the xorg.conf file. Sorry about the noise. Thanks, Nitin Tom Nitin -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Fri, 2013-09-20 at 16:19 -0500, Tom Zanussi wrote: On Fri, 2013-09-20 at 16:14 -0500, Kamble, Nitin A wrote: -Original Message- From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- boun...@yoctoproject.org] On Behalf Of Darren Hart Sent: Friday, September 20, 2013 2:11 PM To: Zanussi, Tom Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Thu, 2013-09-19 at 09:35 -0500, Tom Zanussi wrote: On Thu, 2013-09-19 at 00:43 +0100, Burton, Ross wrote: On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. I pulled in the nuc changes, but will wait for the individual BSP owners to ack the changes for their BSPs before pulling in the others. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. And of course Darren will need to pull in the minnow changes. With the minnow tested now tested, I'm happy to see FRI2, SYS940x, and Crownbay go in. In fact, that's enough I think for the series to go. Any other objections? Darren, Ross, How are you testing? Just deleting file on the target? I am finding the commit is causing build failure for NUC. Hmm, I did a nuc build before pulling it in and didn't see any problems here.. I built and did a boot / X input test for minnow. I haven't attempted a complete build with everything applied. I'll kick a few off on Rage, she isn't doing anything anyway. -- Darren Tom Nitin -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Thu, 2013-09-19 at 09:35 -0500, Tom Zanussi wrote: On Thu, 2013-09-19 at 00:43 +0100, Burton, Ross wrote: On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. I pulled in the nuc changes, but will wait for the individual BSP owners to ack the changes for their BSPs before pulling in the others. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. And of course Darren will need to pull in the minnow changes. With the minnow tested now tested, I'm happy to see FRI2, SYS940x, and Crownbay go in. In fact, that's enough I think for the series to go. Any other objections? -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Fri, 2013-09-20 at 16:14 -0500, Kamble, Nitin A wrote: -Original Message- From: meta-intel-boun...@yoctoproject.org [mailto:meta-intel- boun...@yoctoproject.org] On Behalf Of Darren Hart Sent: Friday, September 20, 2013 2:11 PM To: Zanussi, Tom Cc: meta-intel@yoctoproject.org; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Thu, 2013-09-19 at 09:35 -0500, Tom Zanussi wrote: On Thu, 2013-09-19 at 00:43 +0100, Burton, Ross wrote: On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. I pulled in the nuc changes, but will wait for the individual BSP owners to ack the changes for their BSPs before pulling in the others. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. And of course Darren will need to pull in the minnow changes. With the minnow tested now tested, I'm happy to see FRI2, SYS940x, and Crownbay go in. In fact, that's enough I think for the series to go. Any other objections? Darren, Ross, How are you testing? Just deleting file on the target? I am finding the commit is causing build failure for NUC. Hmm, I did a nuc build before pulling it in and didn't see any problems here.. Tom Nitin -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Fri, 2013-09-20 at 14:33 -0700, Darren Hart wrote: I'm building sugarbay, n450, and jasperforest with ross's branch. Will report back. All successfully completed a core-image-sato build. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
-Original Message- From: Darren Hart [mailto:dvh...@linux.intel.com] Sent: Friday, September 20, 2013 3:42 PM To: Kamble, Nitin A Cc: meta-intel@yoctoproject.org; Zanussi, Tom; Ong, Boon Leong; Haw, Foo Chien Subject: Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones On Fri, 2013-09-20 at 14:33 -0700, Darren Hart wrote: I'm building sugarbay, n450, and jasperforest with ross's branch. Will report back. All successfully completed a core-image-sato build. After fixing my layer, the NUC image is building fine here too. Nitin -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. Which of these BSPs did you test and verify work after this patch? Thanks, Darren Signed-off-by: Ross Burton ross.bur...@intel.com --- .../xserver-xf86-config/chiefriver/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/crownbay-noemgd/xorg.conf | 26 .../xserver-xf86-config/crownbay/xorg.conf |5 --- .../crystalforest-gladden/xorg.conf| 26 .../crystalforest-server/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/emenlow-noemgd/xorg.conf |5 --- .../xserver-xf86-config/emenlow/xorg.conf |5 --- .../xserver-xf86-config/fri2-noemgd/xorg.conf | 26 .../xserver-xf86-config/fri2/xorg.conf |5 --- .../xserver-xf86-config/jasperforest/xorg.conf | 32 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/n450/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xorg-xserver/xserver-xf86-config/nuc/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/romley-ivb/xorg.conf | 26 .../xserver-xf86-config/romley/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sugarbay/xorg.conf | 26 .../xorg-xserver/xserver-xf86-config_0.1.bbappend |1 - .../xserver-xf86-config/sys940x-noemgd/xorg.conf | 26 .../xserver-xf86-config/sys940x/xorg.conf |5 --- 24 files changed, 350 deletions(-) delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf delete mode 100644 meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-crownbay/recipes-graphics/xorg-xserver/xserver-xf86-config/crownbay-noemgd/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-gladden/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config/crystalforest-server/xorg.conf delete mode 100644 meta-crystalforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-fri2/recipes-graphics/xorg-xserver/xserver-xf86-config/fri2-noemgd/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config/jasperforest/xorg.conf delete mode 100644 meta-jasperforest/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config/n450/xorg.conf delete mode 100644 meta-n450/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config/nuc/xorg.conf delete mode 100644 meta-nuc/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley-ivb/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley/xorg.conf delete mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config/sugarbay/xorg.conf delete mode 100644 meta-sugarbay/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend delete mode 100644 meta-sys940x/recipes-graphics/xorg-xserver/xserver-xf86-config/sys940x-noemgd/xorg.conf diff --git a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf b/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf deleted file mode 100644 index 96b94b4..000 --- a/meta-chiefriver/recipes-graphics/xorg-xserver/xserver-xf86-config/chiefriver/xorg.conf +++ /dev/null @@ -1,26 +0,0 @@ -Section Device -Identifier Intel Graphics Driver -Driver intel -EndSection - -Section
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On 19 September 2013 00:31, Darren Hart dvh...@linux.intel.com wrote: On Wed, 2013-09-18 at 23:23 +0100, Ross Burton wrote: Most BSPs appear to be derived from what appears to be a stale copy of the atom-pc xorg.conf which was either repeating defaults (the screen configuration), pointlessly hard-coding (specifying video driver when X can auto-probe), or actively harmful (disabling hotplugged input devices). Delete the files which can be removed, and remove the bad hotplug disabling options from the others. This has been something I've wanted to see improved for a long time. Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. Which of these BSPs did you test and verify work after this patch? Two classes of patches: delete the file and trim the file. Where xorg.conf was deleted the only hardware I can (and did) test it on was NUC. I guess a representative sample of vesa and mga hardware should be verified to still boot. One instance of the trim patch was tested by Saul on his Minnow (whose report of a broken touchscreen prompted this series) and oe-core has had the same change for atom-pc/genericx86 for some time now. Ross ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
Re: [meta-intel] [PATCH] xserver-xf86-config: remove redundant files, clean up broken ones
On 19 September 2013 00:43, Burton, Ross ross.bur...@intel.com wrote: Typically we do changes like with one patch per BSP to help keep things a bit more flexible in the face of regressions. I started doing that but then got rapidly bored with copy-paste... I can split it up though. The same patch series but split per BSP is now at http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-contrib/log/?h=ross/xorg. Ross ___ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
