Re: [Mingw-w64-public] New bug fix from v5.x release soon

[Liu Hao]

With this patch the crash in question shall not happen on i686 and 
x86_64 any more. Pushed to master.



--
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[Liu Hao]

On 2017/10/27 8:52, David Grayson wrote:

The mingw-w64 project has some documentation about how to build a
mingw-w64 GCC compiler:

https://sourceforge.net/p/mingw-w64/wiki2/Cross%20Win32%20and%20Win64%20compiler/
https://github.com/mirror/mingw-w64/tree/master/mingw-w64-doc/howto-build

No you don't need to build the compiler. The only things required to 
build are the headers and the CRT.



Or you could use MSYS2 and start with the build scripts here:

https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-crt-git

Yeah that is exactly why I said 'I don't have time to test': MSYS2 has a 
few patches that got broken by upstream changes a couple of weeks ago. I 
shall take care of it today.



Personally, I like my setup using Nix better, since I can build
complex chains of software without having to remember the right order
to build everything:

https://github.com/DavidEGrayson/nixcrpkgs

--David




--
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[David Grayson]

The mingw-w64 project has some documentation about how to build a
mingw-w64 GCC compiler:

https://sourceforge.net/p/mingw-w64/wiki2/Cross%20Win32%20and%20Win64%20compiler/
https://github.com/mirror/mingw-w64/tree/master/mingw-w64-doc/howto-build

Or you could use MSYS2 and start with the build scripts here:

https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-crt-git

Personally, I like my setup using Nix better, since I can build
complex chains of software without having to remember the right order
to build everything:

https://github.com/DavidEGrayson/nixcrpkgs

--David

On Thu, Oct 26, 2017 at 5:27 PM,   wrote:
> -Original Message- From: Liu Hao
> Sent: Thursday, October 26, 2017 11:51 PM
> To: mingw-w64-public@lists.sourceforge.net ; sisyph...@optusnet.com.au
> Cc: JonY
> Subject: Re: [Mingw-w64-public] New bug fix from v5.x release soon
>
>> The attached patch should fix the problem. This is a quick fix and I don't
>> have time to test it, please test so we can push this patch before this
>> release.
>
>
> Is there a link that will tell me specifically what I need to do - ie what
> to download and patch, and what toolchain I should use to build it ?
> I haven't actually built this stuff before.
>
>
> Cheers,
> Rob
>
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[sisyphus1]

-Original Message- 
From: Liu Hao

Sent: Thursday, October 26, 2017 11:51 PM
To: mingw-w64-public@lists.sourceforge.net ; sisyph...@optusnet.com.au
Cc: JonY
Subject: Re: [Mingw-w64-public] New bug fix from v5.x release soon

The attached patch should fix the problem. This is a quick fix and I don't 
have time to test it, please test so we can push this patch before this 
release.


Is there a link that will tell me specifically what I need to do - ie what 
to download and patch, and what toolchain I should use to build it ?

I haven't actually built this stuff before.

Cheers,
Rob




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] IDWriteFontFace1 Fix

[Tom Ritter]

We missed one, here is the additional patch.

-tom



On 18 October 2017 at 11:55, Jacek Caban  wrote:
> On 18.10.2017 18:50, Tom Ritter wrote:
>> On 18 October 2017 at 02:58, Jacek Caban  wrote:
>>> The attachment didn't make it to the mailing list.
>> Whoops, sorry, let me try with a .txt. If that fails:
>> https://pastebin.mozilla.org/9070416
>
> It looks good to me, I committed it.
>
> Thanks,
> Jacek
From bc0631e32a04a992fa9f4c4fe496473d9218baab Mon Sep 17 00:00:00 2001
From: Tom Ritter 
Date: Thu, 26 Oct 2017 13:07:31 -0500
Subject: [PATCH] Correct the declaration of IDWriteFontFace2::GetMetrics

The GetMetrics function in the derived class takes a parameter
of type DWRITE_FONT_METRICS1 rather than DWRITE_FONT_METRICS.

We missed this interface in the prior patch, per:
https://bugzilla.mozilla.org/show_bug.cgi?id=1409915#c6
---
 mingw-w64-headers/include/dwrite_2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mingw-w64-headers/include/dwrite_2.h 
b/mingw-w64-headers/include/dwrite_2.h
index 6c5f4f7c..c939297b 100644
--- a/mingw-w64-headers/include/dwrite_2.h
+++ b/mingw-w64-headers/include/dwrite_2.h
@@ -447,7 +447,7 @@ DECLARE_INTERFACE_(IDWriteFontFace2,IDWriteFontFace1)
 WINBOOL isSideways __MINGW_DEF_ARG_VAL(FALSE)) PURE;
 
 /* IDWriteFontFace1 methods */
-STDMETHOD_(void, GetMetrics)(THIS_ DWRITE_FONT_METRICS*) PURE;
+STDMETHOD_(void, GetMetrics)(THIS_ DWRITE_FONT_METRICS1*) PURE;
 STDMETHOD(GetGdiCompatibleMetrics)(THIS_ FLOAT,FLOAT,DWRITE_MATRIX 
const*,DWRITE_FONT_METRICS1*) PURE;
 STDMETHOD_(void, GetCaretMetrics)(THIS_ DWRITE_CARET_METRICS*) PURE;
 STDMETHOD(GetUnicodeRanges)(THIS_ UINT32, DWRITE_UNICODE_RANGE*,UINT32*) 
PURE;
-- 
2.11.0

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[Kai Tietz via Mingw-w64-public]

Thanks for the patch.  If test passes, patch is ok to apply.

Thanks,
Kai

2017-10-26 14:51 GMT+02:00 Liu Hao :
> On 2017/10/26 19:53, sisyph...@optusnet.com.au wrote:
>>
>> -Original Message- From: JonY via Mingw-w64-public
>> Sent: Thursday, October 26, 2017 10:03 PM
>> To: mingw-w64-public@lists.sourceforge.net
>> Cc: JonY
>> Subject: [Mingw-w64-public] New bug fix from v5.x release soon
>>
>>> Are there any bug fix commits from master that you think should go into
>>> v5.x?
>>> Let me know ASAP, thanks.
>>
>>
>> Is https://sourceforge.net/p/mingw-w64/bugs/478/ being fixed ?
>>
>> It's a bug that has continued to cause me grief over the last couple of
>> years - largely because the perl5 developers have chosen to *not* work
>> around it.
>>
>> Cheers,
>> Rob
>
> The asm statements fail to clobber the AX register so the compiler thinks
> they were left alone and stores a pointer in {R,E}AX.
>
> The attached patch should fix the problem. This is a quick fix and I don't
> have time to test it, please test so we can push this patch before this
> release.
>
>
> --
> Best regards,
> LH_Mouse
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[Liu Hao]

On 2017/10/26 19:53, sisyph...@optusnet.com.au wrote:

-Original Message- From: JonY via Mingw-w64-public
Sent: Thursday, October 26, 2017 10:03 PM
To: mingw-w64-public@lists.sourceforge.net
Cc: JonY
Subject: [Mingw-w64-public] New bug fix from v5.x release soon

Are there any bug fix commits from master that you think should go 
into v5.x?

Let me know ASAP, thanks.


Is https://sourceforge.net/p/mingw-w64/bugs/478/ being fixed ?

It's a bug that has continued to cause me grief over the last couple of 
years - largely because the perl5 developers have chosen to *not* work 
around it.


Cheers,
Rob
The asm statements fail to clobber the AX register so the compiler 
thinks they were left alone and stores a pointer in {R,E}AX.


The attached patch should fix the problem. This is a quick fix and I 
don't have time to test it, please test so we can push this patch before 
this release.



--
Best regards,
LH_Mouse
From 6988618931548eea602319488e60d32557d704c2 Mon Sep 17 00:00:00 2001
From: Liu Hao 
Date: Thu, 26 Oct 2017 20:48:45 +0800
Subject: [PATCH] mingw-w64-crt/math/modf{,f,l}.c: Fix segment faults in
 modf(), modff() and modfl().

Reference: https://sourceforge.net/p/mingw-w64/bugs/478/
Signed-off-by: Liu Hao 
---
 mingw-w64-crt/math/modf.c  | 4 ++--
 mingw-w64-crt/math/modff.c | 4 ++--
 mingw-w64-crt/math/modfl.c | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/mingw-w64-crt/math/modf.c b/mingw-w64-crt/math/modf.c
index 068aec6c..f8ba64e8 100644
--- a/mingw-w64-crt/math/modf.c
+++ b/mingw-w64-crt/math/modf.c
@@ -21,7 +21,7 @@ modf (double value, double* iptr)
 "fldcw (%%rsp)\n"
 "frndint\n"
 "fldcw 4(%%rsp)\n"
-"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value)); /* round */
+"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value) : "eax"); /* round */
 #elif defined(_X86_) || defined(__i386__)
   asm ("push %%eax\n\tsubl $8, %%esp\n"
 "fnstcw 4(%%esp)\n"
@@ -31,7 +31,7 @@ modf (double value, double* iptr)
 "fldcw (%%esp)\n"
 "frndint\n"
 "fldcw 4(%%esp)\n"
-"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value)); /* round 
*/
+"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value) : "eax"); 
/* round */
 #else
   int_part = trunc(value);
 #endif
diff --git a/mingw-w64-crt/math/modff.c b/mingw-w64-crt/math/modff.c
index 3e08f9dd..2c4de3eb 100644
--- a/mingw-w64-crt/math/modff.c
+++ b/mingw-w64-crt/math/modff.c
@@ -22,7 +22,7 @@ modff (float value, float* iptr)
 "fldcw (%%rsp)\n"
 "frndint\n"
 "fldcw 4(%%rsp)\n"
-"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value)); /* round */
+"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value) : "eax"); /* round */
 #elif defined(_X86_) || defined(__i386__)
   asm ("push %%eax\n\tsubl $8, %%esp\n"
 "fnstcw 4(%%esp)\n"
@@ -32,7 +32,7 @@ modff (float value, float* iptr)
 "fldcw (%%esp)\n"
 "frndint\n"
 "fldcw 4(%%esp)\n"
-"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value)); /* round 
*/
+"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value) : "eax"); 
/* round */
 #else
   int_part = truncf(value);
 #endif
diff --git a/mingw-w64-crt/math/modfl.c b/mingw-w64-crt/math/modfl.c
index af75a8b8..ef1ab16c 100644
--- a/mingw-w64-crt/math/modfl.c
+++ b/mingw-w64-crt/math/modfl.c
@@ -21,7 +21,7 @@ modfl (long double value, long double* iptr)
 "fldcw (%%rsp)\n"
 "frndint\n"
 "fldcw 4(%%rsp)\n"
-"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value)); /* round */
+"addq $8, %%rsp\n" : "=t" (int_part) : "0" (value) : "eax"); /* round */
 #elif defined(_X86_) || defined(__i386__)
   asm ("push %%eax\n\tsubl $8, %%esp\n"
 "fnstcw 4(%%esp)\n"
@@ -31,7 +31,7 @@ modfl (long double value, long double* iptr)
 "fldcw (%%esp)\n"
 "frndint\n"
 "fldcw 4(%%esp)\n"
-"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value)); /* round 
*/
+"addl $8, %%esp\n\tpop %%eax\n" : "=t" (int_part) : "0" (value) : "eax"); 
/* round */
 #else
   int_part = truncl(value);
 #endif
-- 
2.14.2

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] New bug fix from v5.x release soon

[sisyphus1]

-Original Message- 
From: JonY via Mingw-w64-public

Sent: Thursday, October 26, 2017 10:03 PM
To: mingw-w64-public@lists.sourceforge.net
Cc: JonY
Subject: [Mingw-w64-public] New bug fix from v5.x release soon

Are there any bug fix commits from master that you think should go into 
v5.x?

Let me know ASAP, thanks.


Is https://sourceforge.net/p/mingw-w64/bugs/478/ being fixed ?

It's a bug that has continued to cause me grief over the last couple of 
years - largely because the perl5 developers have chosen to *not* work 
around it.


Cheers,
Rob





--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] New bug fix from v5.x release soon

[JonY via Mingw-w64-public]

Are there any bug fix commits from master that you think should go into
v5.x?

Let me know ASAP, thanks.


signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public