Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in specstrings.h.

2017-05-10 Thread Liu Hao 
On 2017/5/10 23:24, David Grayson wrote:
> OK, thanks.  I've attached a new patch where the #include is after the 
> __cplusplus stuff.
> 
> I also included a second patch that will add an include guard for 
> specstrings.h, since Microsoft seems to do that too.
> 
> driverspecs.h is also missing an include guard but it is part of the 
> React DDK so I didn't want to mess around with editing at the moment.
> I pushed both patches to master.

The name for the include guard macro used by this file is the same as 
that used by Microsoft so I think it should be safe.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in specstrings.h.

2017-05-09 Thread Liu Hao 
On 2017/5/10 10:34, David Grayson wrote:
> This patch adds "#include " near the end of specstrings.h,
> because the same is done in Microsoft's version of specstrings.h.  With
> this patch, I am able to build Microsoft's devcon utility without
> modification.  Thanks!
You must `#include` that header AFTER the `#ifdef __cplusplus ... 
#endif` block.

Anyway, this header seems short of a header guard. I shall ask someone 
for sure.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] Include driverspecs.h in specstrings.h.

2017-05-09 Thread David Grayson 
This patch adds "#include " near the end of specstrings.h,
because the same is done in Microsoft's version of specstrings.h.  With
this patch, I am able to build Microsoft's devcon utility without
modification.  Thanks!

--David Grayson
From bbe97312dabdbd7200b337ad8f8232786ae77c4e Mon Sep 17 00:00:00 2001
From: David Grayson 
Date: Tue, 9 May 2017 09:15:29 -0700
Subject: [PATCH] specstrings.h:  Include driverspecs.h near the bottom.

That's what the Microsoft header does, and their devcon utility
depends on it.
---
 mingw-w64-headers/include/specstrings.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mingw-w64-headers/include/specstrings.h 
b/mingw-w64-headers/include/specstrings.h
index 485b4330..5c35 100644
--- a/mingw-w64-headers/include/specstrings.h
+++ b/mingw-w64-headers/include/specstrings.h
@@ -325,6 +325,8 @@ extern "C" {
 #endif
 #endif /* DECLSPEC_ADDRSAFE */
 
+#include 
+
 #ifdef __cplusplus
 }
 #endif
-- 
2.12.1

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public