Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.
On 4/15/19 3:03 PM, Martin Storsjö wrote: On Mon, 15 Apr 2019, Jacek Caban wrote: On 3/29/19 4:34 PM, Jacek Caban wrote: Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/mingw_helpers.c | 23 --- mingw-w64-crt/include/internal.h | 4 mingw-w64-crt/lib32/msvcr90.def.in | 4 ++-- mingw-w64-crt/lib64/msvcr90.def.in | 4 ++-- 4 files changed, 4 insertions(+), 31 deletions(-) Ping, is there any reason to keep it? Liu OK'd this patch back in March soon after it was posted. I missed it somehow, thanks. In any case, I don't mind either, although I'm not really aware of the original purpose of these functions. They were used by the old (pre-ucrt-inspired) atexit() implementation, through even then they seemed questionable. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.
On Mon, 15 Apr 2019, Jacek Caban wrote: On 3/29/19 4:34 PM, Jacek Caban wrote: Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/mingw_helpers.c | 23 --- mingw-w64-crt/include/internal.h | 4 mingw-w64-crt/lib32/msvcr90.def.in | 4 ++-- mingw-w64-crt/lib64/msvcr90.def.in | 4 ++-- 4 files changed, 4 insertions(+), 31 deletions(-) Ping, is there any reason to keep it? Liu OK'd this patch back in March soon after it was posted. In any case, I don't mind either, although I'm not really aware of the original purpose of these functions. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.
On 3/29/19 4:34 PM, Jacek Caban wrote: Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/mingw_helpers.c | 23 --- mingw-w64-crt/include/internal.h | 4 mingw-w64-crt/lib32/msvcr90.def.in | 4 ++-- mingw-w64-crt/lib64/msvcr90.def.in | 4 ++-- 4 files changed, 4 insertions(+), 31 deletions(-) Ping, is there any reason to keep it? Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] crt: Remove no longer used _encode_pointer and _decode_pointer.
在 2019/3/29 23:34, Jacek Caban 写道: > > Those are not used since a0ee49ec60f8a2a54e9991ef37501f62cfb07bdd. > > Signed-off-by: Jacek Caban > --- > mingw-w64-crt/crt/mingw_helpers.c | 23 --- > mingw-w64-crt/include/internal.h | 4 > mingw-w64-crt/lib32/msvcr90.def.in | 4 ++-- > mingw-w64-crt/lib64/msvcr90.def.in | 4 ++-- > 4 files changed, 4 insertions(+), 31 deletions(-) > > > > LGTM. Thanks. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
