Re: [Mingw-w64-public] [PATCH] setupapi.h: add missing devpropdef.h include

2016-08-26 Thread Kai Tietz
Hello Mateusz,

2016-08-25 11:18 GMT+02:00 Mateusz :
> Fix for bug #550 https://sourceforge.net/p/mingw-w64/bugs/550/
>
> >From 6325df027a92d7f5041da022d0a9420c1af531c2 Mon Sep 17 00:00:00 2001
> From: mati865 
> Date: Thu, 25 Aug 2016 11:00:50 +0200
> Subject: [PATCH] setupapi.h: add missing devpropdef.h include
>
> ---
>  mingw-w64-headers/include/setupapi.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mingw-w64-headers/include/setupapi.h
> b/mingw-w64-headers/include/setupapi.h
> index a0244a3..f029b80 100644
> --- a/mingw-w64-headers/include/setupapi.h
> +++ b/mingw-w64-headers/include/setupapi.h
> @@ -7,6 +7,7 @@
>  #define _INC_SETUPAPI
>
>  #include <_mingw_unicode.h>
> +#include 
>
>  #ifndef _SETUPAPI_
>  #define WINSETUPAPI DECLSPEC_IMPORT
> --
> 2.9.1

Patch looks ok.  In general are such header dependencies to be treated
with care.  It seems on the first glance like an user improvement, but
can lead to issues about different use cases for the header.

Thanks,
Kai

--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


[Mingw-w64-public] [PATCH] setupapi.h: add missing devpropdef.h include

2016-08-25 Thread Mateusz
Fix for bug #550 https://sourceforge.net/p/mingw-w64/bugs/550/

>From 6325df027a92d7f5041da022d0a9420c1af531c2 Mon Sep 17 00:00:00 2001
From: mati865 
Date: Thu, 25 Aug 2016 11:00:50 +0200
Subject: [PATCH] setupapi.h: add missing devpropdef.h include

---
 mingw-w64-headers/include/setupapi.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mingw-w64-headers/include/setupapi.h
b/mingw-w64-headers/include/setupapi.h
index a0244a3..f029b80 100644
--- a/mingw-w64-headers/include/setupapi.h
+++ b/mingw-w64-headers/include/setupapi.h
@@ -7,6 +7,7 @@
 #define _INC_SETUPAPI

 #include <_mingw_unicode.h>
+#include 

 #ifndef _SETUPAPI_
 #define WINSETUPAPI DECLSPEC_IMPORT
-- 
2.9.1
--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public