Re: [Mingw-w64-public] [PATCH] strsafe.h: Added missing _STRSAFE_EXTERN_C in cases when inlining is disables.

[Jacek Caban]

On 22.06.2017 15:07, Kai Tietz via Mingw-w64-public wrote:
> 2017-06-20 3:52 GMT+02:00 Liu Hao :
>> On 2017/6/20 1:40, Jacek Caban wrote:
>>> Please review.
>>>
>>> Signed-off-by: Jacek Caban 
>>> ---
>>>   mingw-w64-headers/include/strsafe.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>> We might have to test this patch with different `-std=` options with
>> different optimization levels because of different behavior of `extern
>> inline` in C89, C99 and C++.
>>
>> --
>> Best regards,
>> LH_Mouse
> Sure, but patch of Jacek just touches the none-inline variant, isn't it?
>
> So IMHO patch is ok.

Thanks for reviews, I pushed patches. Could you please also look at
dwrite.h patch?

Thanks,
Jacek

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] strsafe.h: Added missing _STRSAFE_EXTERN_C in cases when inlining is disables.

[Kai Tietz via Mingw-w64-public]

2017-06-20 3:52 GMT+02:00 Liu Hao :
> On 2017/6/20 1:40, Jacek Caban wrote:
>>
>> Please review.
>>
>> Signed-off-by: Jacek Caban 
>> ---
>>   mingw-w64-headers/include/strsafe.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
> We might have to test this patch with different `-std=` options with
> different optimization levels because of different behavior of `extern
> inline` in C89, C99 and C++.
>
> --
> Best regards,
> LH_Mouse

Sure, but patch of Jacek just touches the none-inline variant, isn't it?

So IMHO patch is ok.

Regards,
Kai

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] strsafe.h: Added missing _STRSAFE_EXTERN_C in cases when inlining is disables.

[Liu Hao]

On 2017/6/20 1:40, Jacek Caban wrote:

Please review.

Signed-off-by: Jacek Caban 
---
  mingw-w64-headers/include/strsafe.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

We might have to test this patch with different `-std=` options with 
different optimization levels because of different behavior of `extern 
inline` in C89, C99 and C++.


--
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] strsafe.h: Added missing _STRSAFE_EXTERN_C in cases when inlining is disables.

[Jacek Caban]

Please review.

Signed-off-by: Jacek Caban 
---
 mingw-w64-headers/include/strsafe.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/mingw-w64-headers/include/strsafe.h b/mingw-w64-headers/include/strsafe.h
index 74f924ab..173c1ea0 100644
--- a/mingw-w64-headers/include/strsafe.h
+++ b/mingw-w64-headers/include/strsafe.h
@@ -86,9 +86,9 @@ typedef __LONG32 HRESULT;
 /* Variadic functions can't be __stdcall.  */
 #define STRSAFEAPIV _STRSAFE_EXTERN_C __inline HRESULT
 #else
-#define STRSAFEAPI HRESULT WINAPI
+#define STRSAFEAPI _STRSAFE_EXTERN_C HRESULT WINAPI
 /* Variadic functions can't be __stdcall.  */
-#define STRSAFEAPIV HRESULT
+#define STRSAFEAPIV _STRSAFE_EXTERN_C HRESULT
 #endif
 
 #if !defined(__CRT__NO_INLINE) && !defined(__CRT_STRSAFE_IMPL)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public