Re: [Mingw-w64-public] [PATCH 14/18] winpthreads: AC_PROG_RANLIB is obsoleted by LT_INIT

2023-11-30 Thread LIU Hao

在 2023/11/30 18:54, Antonin Décimo 写道:

Are you sure it's a good idea? Isn't it better if the two files are
kept in sync?
It's less confusing during the occasional bisect. In OCaml, we even
have continuous integration testing that configure is regenerated on
configure.ac changes.


Changes to generated files can't be reviewed or cherry-picked; and they may be overwritten anyway. 
So there is no necessity to include them. They will be committed separately.



--
Best regards,
LIU Hao



OpenPGP_signature.asc
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] [PATCH 14/18] winpthreads: AC_PROG_RANLIB is obsoleted by LT_INIT

2023-11-30 Thread Antonin Décimo
Le jeu. 30 nov. 2023 à 08:11, JonY via Mingw-w64-public
 a écrit :
>
> On 11/29/23 10:39, Antonin Décimo wrote:
> > Fixes a warning from libtoolize: 'AC_PROG_RANLIB' is rendered obsolete
> > by 'LT_INIT'.
> >
> > Signed-off-by: Antonin Décimo 
> > ---
> >   mingw-w64-libraries/winpthreads/configure| 104 +--
> >   mingw-w64-libraries/winpthreads/configure.ac |   1 -
> >   2 files changed, 1 insertion(+), 104 deletions(-)
> >
>
> Please exclude the configure file itself from the commit, regenerate it
> as a separate commit.

Are you sure it's a good idea? Isn't it better if the two files are
kept in sync?
It's less confusing during the occasional bisect. In OCaml, we even
have continuous integration testing that configure is regenerated on
configure.ac changes.

The configure file was regenerated on MSYS2 with

WANT_AUTOMAKE=1.16 autoreconf -fiv

Best regards,
-- Antonin


___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] [PATCH 14/18] winpthreads: AC_PROG_RANLIB is obsoleted by LT_INIT

2023-11-29 Thread JonY via Mingw-w64-public

On 11/29/23 10:39, Antonin Décimo wrote:

Fixes a warning from libtoolize: 'AC_PROG_RANLIB' is rendered obsolete
by 'LT_INIT'.

Signed-off-by: Antonin Décimo 
---
  mingw-w64-libraries/winpthreads/configure| 104 +--
  mingw-w64-libraries/winpthreads/configure.ac |   1 -
  2 files changed, 1 insertion(+), 104 deletions(-)



Please exclude the configure file itself from the commit, regenerate it 
as a separate commit.


Thanks.



___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


[Mingw-w64-public] [PATCH 14/18] winpthreads: AC_PROG_RANLIB is obsoleted by LT_INIT

2023-11-29 Thread Antonin Décimo
Fixes a warning from libtoolize: 'AC_PROG_RANLIB' is rendered obsolete
by 'LT_INIT'.

Signed-off-by: Antonin Décimo 
---
 mingw-w64-libraries/winpthreads/configure| 104 +--
 mingw-w64-libraries/winpthreads/configure.ac |   1 -
 2 files changed, 1 insertion(+), 104 deletions(-)

diff --git a/mingw-w64-libraries/winpthreads/configure 
b/mingw-w64-libraries/winpthreads/configure
index 22b955cd4..36a217e5f 100755
--- a/mingw-w64-libraries/winpthreads/configure
+++ b/mingw-w64-libraries/winpthreads/configure
@@ -678,6 +678,7 @@ LIPO
 NMEDIT
 DSYMUTIL
 MANIFEST_TOOL
+RANLIB
 FILECMD
 LN_S
 NM
@@ -699,7 +700,6 @@ am__fastdepCCAS_TRUE
 CCASDEPMODE
 CCASFLAGS
 CCAS
-RANLIB
 am__fastdepCC_FALSE
 am__fastdepCC_TRUE
 CCDEPMODE
@@ -4641,108 +4641,6 @@ else
 fi
 
 
-if test -n "$ac_tool_prefix"; then
-  # Extract the first word of "${ac_tool_prefix}ranlib", so it can be a 
program name with args.
-set dummy ${ac_tool_prefix}ranlib; ac_word=$2
-{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
-printf %s "checking for $ac_word... " >&6; }
-if test ${ac_cv_prog_RANLIB+y}
-then :
-  printf %s "(cached) " >&6
-else $as_nop
-  if test -n "$RANLIB"; then
-  ac_cv_prog_RANLIB="$RANLIB" # Let the user override the test.
-else
-as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
-  IFS=$as_save_IFS
-  case $as_dir in #(((
-'') as_dir=./ ;;
-*/) ;;
-*) as_dir=$as_dir/ ;;
-  esac
-for ac_exec_ext in '' $ac_executable_extensions; do
-  if as_fn_executable_p "$as_dir$ac_word$ac_exec_ext"; then
-ac_cv_prog_RANLIB="${ac_tool_prefix}ranlib"
-printf "%s\n" "$as_me:${as_lineno-$LINENO}: found 
$as_dir$ac_word$ac_exec_ext" >&5
-break 2
-  fi
-done
-  done
-IFS=$as_save_IFS
-
-fi
-fi
-RANLIB=$ac_cv_prog_RANLIB
-if test -n "$RANLIB"; then
-  { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $RANLIB" >&5
-printf "%s\n" "$RANLIB" >&6; }
-else
-  { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: no" >&5
-printf "%s\n" "no" >&6; }
-fi
-
-
-fi
-if test -z "$ac_cv_prog_RANLIB"; then
-  ac_ct_RANLIB=$RANLIB
-  # Extract the first word of "ranlib", so it can be a program name with args.
-set dummy ranlib; ac_word=$2
-{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
-printf %s "checking for $ac_word... " >&6; }
-if test ${ac_cv_prog_ac_ct_RANLIB+y}
-then :
-  printf %s "(cached) " >&6
-else $as_nop
-  if test -n "$ac_ct_RANLIB"; then
-  ac_cv_prog_ac_ct_RANLIB="$ac_ct_RANLIB" # Let the user override the test.
-else
-as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
-  IFS=$as_save_IFS
-  case $as_dir in #(((
-'') as_dir=./ ;;
-*/) ;;
-*) as_dir=$as_dir/ ;;
-  esac
-for ac_exec_ext in '' $ac_executable_extensions; do
-  if as_fn_executable_p "$as_dir$ac_word$ac_exec_ext"; then
-ac_cv_prog_ac_ct_RANLIB="ranlib"
-printf "%s\n" "$as_me:${as_lineno-$LINENO}: found 
$as_dir$ac_word$ac_exec_ext" >&5
-break 2
-  fi
-done
-  done
-IFS=$as_save_IFS
-
-fi
-fi
-ac_ct_RANLIB=$ac_cv_prog_ac_ct_RANLIB
-if test -n "$ac_ct_RANLIB"; then
-  { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $ac_ct_RANLIB" >&5
-printf "%s\n" "$ac_ct_RANLIB" >&6; }
-else
-  { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: no" >&5
-printf "%s\n" "no" >&6; }
-fi
-
-  if test "x$ac_ct_RANLIB" = x; then
-RANLIB=":"
-  else
-case $cross_compiling:$ac_tool_warned in
-yes:)
-{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: WARNING: using cross tools not 
prefixed with host triplet" >&5
-printf "%s\n" "$as_me: WARNING: using cross tools not prefixed with host 
triplet" >&2;}
-ac_tool_warned=yes ;;
-esac
-RANLIB=$ac_ct_RANLIB
-  fi
-else
-  RANLIB="$ac_cv_prog_RANLIB"
-fi
-
 # By default we simply use the C compiler to build assembly code.
 
 test "${CCAS+set}" = set || CCAS=$CC
diff --git a/mingw-w64-libraries/winpthreads/configure.ac 
b/mingw-w64-libraries/winpthreads/configure.ac
index 424a9bcec..e72316752 100644
--- a/mingw-w64-libraries/winpthreads/configure.ac
+++ b/mingw-w64-libraries/winpthreads/configure.ac
@@ -16,7 +16,6 @@ AC_CANONICAL_HOST
 # Checks for programs.
 AC_NO_EXECUTABLES
 AC_PROG_CC
-AC_PROG_RANLIB
 AM_PROG_AS
 AM_PROG_AR
 
-- 
2.43.0



___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public