Re: [Mingw-w64-public] [PATCH 2/2] widl: Quote path names in the makefile, to fix installing into a path that contains spaces
On Sun, 1 Dec 2019, JonY via Mingw-w64-public wrote: On 11/30/19 8:28 PM, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- mingw-w64-tools/widl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-tools/widl/Makefile.am b/mingw-w64-tools/widl/Makefile.am index 0cc45611e..7c570210e 100644 --- a/mingw-w64-tools/widl/Makefile.am +++ b/mingw-w64-tools/widl/Makefile.am @@ -58,7 +58,7 @@ widl_SOURCES = src/widl.h \ include/pathtools.h \ include/winnt.rh -widl_CPPFLAGS = -I$(top_srcdir)/include -DDEFAULT_INCLUDE_DIR=\"@WIDL_INCLUDEDIR@\" -DDEFAULT_BINDIR=\"$(bindir)\" +widl_CPPFLAGS = -I$(top_srcdir)/include -DDEFAULT_INCLUDE_DIR=\""@WIDL_INCLUDEDIR@"\" -DDEFAULT_BINDIR=\""$(bindir)"\" widl_CFLAGS = -O3 -g -Wall -Wformat -Wpacked -Wmissing-declarations -Wimplicit-function-declaration -Wmissing-prototypes -Wstrict-aliasing=2 DISTCHECK_CONFIGURE_FLAGS = --host=$(host) --target=$(target) Patches look good to me. Thanks, pushed them both. // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH 2/2] widl: Quote path names in the makefile, to fix installing into a path that contains spaces
On 11/30/19 8:28 PM, Martin Storsjö wrote: > Signed-off-by: Martin Storsjö > --- > mingw-w64-tools/widl/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mingw-w64-tools/widl/Makefile.am > b/mingw-w64-tools/widl/Makefile.am > index 0cc45611e..7c570210e 100644 > --- a/mingw-w64-tools/widl/Makefile.am > +++ b/mingw-w64-tools/widl/Makefile.am > @@ -58,7 +58,7 @@ widl_SOURCES = src/widl.h \ >include/pathtools.h \ >include/winnt.rh > > -widl_CPPFLAGS = -I$(top_srcdir)/include > -DDEFAULT_INCLUDE_DIR=\"@WIDL_INCLUDEDIR@\" -DDEFAULT_BINDIR=\"$(bindir)\" > +widl_CPPFLAGS = -I$(top_srcdir)/include > -DDEFAULT_INCLUDE_DIR=\""@WIDL_INCLUDEDIR@"\" -DDEFAULT_BINDIR=\""$(bindir)"\" > widl_CFLAGS = -O3 -g -Wall -Wformat -Wpacked -Wmissing-declarations > -Wimplicit-function-declaration -Wmissing-prototypes -Wstrict-aliasing=2 > > DISTCHECK_CONFIGURE_FLAGS = --host=$(host) --target=$(target) > Patches look good to me. signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] [PATCH 2/2] widl: Quote path names in the makefile, to fix installing into a path that contains spaces
Signed-off-by: Martin Storsjö --- mingw-w64-tools/widl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-tools/widl/Makefile.am b/mingw-w64-tools/widl/Makefile.am index 0cc45611e..7c570210e 100644 --- a/mingw-w64-tools/widl/Makefile.am +++ b/mingw-w64-tools/widl/Makefile.am @@ -58,7 +58,7 @@ widl_SOURCES = src/widl.h \ include/pathtools.h \ include/winnt.rh -widl_CPPFLAGS = -I$(top_srcdir)/include -DDEFAULT_INCLUDE_DIR=\"@WIDL_INCLUDEDIR@\" -DDEFAULT_BINDIR=\"$(bindir)\" +widl_CPPFLAGS = -I$(top_srcdir)/include -DDEFAULT_INCLUDE_DIR=\""@WIDL_INCLUDEDIR@"\" -DDEFAULT_BINDIR=\""$(bindir)"\" widl_CFLAGS = -O3 -g -Wall -Wformat -Wpacked -Wmissing-declarations -Wimplicit-function-declaration -Wmissing-prototypes -Wstrict-aliasing=2 DISTCHECK_CONFIGURE_FLAGS = --host=$(host) --target=$(target) -- 2.17.1 ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
