Re: [Mingw-w64-public] [PATCH 9/9] crt: Rename msvcrt-common.def.in to crt-aliases.def.in

[Martin Storsjö]

On Thu, 9 May 2024, Pali Rohár wrote:


This file contains definitions of symbol aliases for any CRT library. It is
already used by msvcrt, crtdll and ucrt. So rename msvcrt-common.def.in to
crt-aliases.def.in as new name better match the purpose of the file.
---


The rest of these 9 patches seem fine to me, the only details I noticed 
was some parts of the commit message in 2/9 and ifdef style in 6/9.


// Martin

___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH 9/9] crt: Rename msvcrt-common.def.in to crt-aliases.def.in

[Pali Rohár]

This file contains definitions of symbol aliases for any CRT library. It is
already used by msvcrt, crtdll and ucrt. So rename msvcrt-common.def.in to
crt-aliases.def.in as new name better match the purpose of the file.
---
 .../def-include/{msvcrt-common.def.in => crt-aliases.def.in}  | 0
 mingw-w64-crt/lib-common/msvcr120_app.def.in  | 2 +-
 mingw-w64-crt/lib-common/msvcrt.def.in| 4 ++--
 mingw-w64-crt/lib-common/ucrtbase.def.in  | 2 +-
 mingw-w64-crt/lib32/crtdll.def.in | 2 +-
 mingw-w64-crt/lib32/msvcr100.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcr110.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcr120.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcr120d.def.in  | 2 +-
 mingw-w64-crt/lib32/msvcr70.def.in| 2 +-
 mingw-w64-crt/lib32/msvcr71.def.in| 2 +-
 mingw-w64-crt/lib32/msvcr80.def.in| 2 +-
 mingw-w64-crt/lib32/msvcr90.def.in| 2 +-
 mingw-w64-crt/lib32/msvcr90d.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcrt10.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcrt20.def.in   | 2 +-
 mingw-w64-crt/lib32/msvcrt40.def.in   | 2 +-
 mingw-w64-crt/lib64/msvcr100.def.in   | 2 +-
 mingw-w64-crt/lib64/msvcr110.def.in   | 2 +-
 mingw-w64-crt/lib64/msvcr120.def.in   | 2 +-
 mingw-w64-crt/lib64/msvcr120d.def.in  | 2 +-
 mingw-w64-crt/lib64/msvcr80.def.in| 2 +-
 mingw-w64-crt/lib64/msvcr90.def.in| 2 +-
 mingw-w64-crt/lib64/msvcr90d.def.in   | 2 +-
 24 files changed, 24 insertions(+), 24 deletions(-)
 rename mingw-w64-crt/def-include/{msvcrt-common.def.in => crt-aliases.def.in} 
(100%)

diff --git a/mingw-w64-crt/def-include/msvcrt-common.def.in 
b/mingw-w64-crt/def-include/crt-aliases.def.in
similarity index 100%
rename from mingw-w64-crt/def-include/msvcrt-common.def.in
rename to mingw-w64-crt/def-include/crt-aliases.def.in
diff --git a/mingw-w64-crt/lib-common/msvcr120_app.def.in 
b/mingw-w64-crt/lib-common/msvcr120_app.def.in
index 6f3376a58fc2..928c0d3a5c95 100644
--- a/mingw-w64-crt/lib-common/msvcr120_app.def.in
+++ b/mingw-w64-crt/lib-common/msvcr120_app.def.in
@@ -2502,4 +2502,4 @@ wscanf_s
 #define NO_STRCMPI_ALIAS
 #define FIXED_SIZE_SYMBOLS
 #endif
-#include "msvcrt-common.def.in"
+#include "crt-aliases.def.in"
diff --git a/mingw-w64-crt/lib-common/msvcrt.def.in 
b/mingw-w64-crt/lib-common/msvcrt.def.in
index 29d10767dd47..a27ff541e354 100644
--- a/mingw-w64-crt/lib-common/msvcrt.def.in
+++ b/mingw-w64-crt/lib-common/msvcrt.def.in
@@ -1739,7 +1739,7 @@ swscanf_s
 F_ARM_ANY(tanhf) ; i386 tanhf provided by emu and x64 tanhf replaced by emu
 tmpfile_s
 tmpnam_s
-F_ARM_ANY(utime) ; i386 and x64 utime replaced by alias in msvcrt-common.def.in
+F_ARM_ANY(utime) ; i386 and x64 utime replaced by alias in crt-aliases.def.in
 vfprintf_s
 vfwprintf_s
 vprintf_s
@@ -1835,7 +1835,7 @@ F_ARM_ANY(fabsf) ; i386 and x64 fabsf provided by emu
 ; i386 strtoll, strtoull, strtoimax and strtoumax alias provided by emu
 #define WITH_STRTO64_ALIAS
 #endif
-#include "msvcrt-common.def.in"
+#include "crt-aliases.def.in"
 
 ; This is list of additional symbol aliases not available in any CRT library
 ; FIXME: check if these really are needed
diff --git a/mingw-w64-crt/lib-common/ucrtbase.def.in 
b/mingw-w64-crt/lib-common/ucrtbase.def.in
index 7453c2438ddf..914936f4f5dc 100644
--- a/mingw-w64-crt/lib-common/ucrtbase.def.in
+++ b/mingw-w64-crt/lib-common/ucrtbase.def.in
@@ -2630,4 +2630,4 @@ wmemcpy_s
 wmemmove_s
 
 #define UCRTBASE
-#include "msvcrt-common.def.in"
+#include "crt-aliases.def.in"
diff --git a/mingw-w64-crt/lib32/crtdll.def.in 
b/mingw-w64-crt/lib32/crtdll.def.in
index 06f4ee68ceee..06ca3759b504 100644
--- a/mingw-w64-crt/lib32/crtdll.def.in
+++ b/mingw-w64-crt/lib32/crtdll.def.in
@@ -629,4 +629,4 @@ _ultow
 #define NO_WIDE_FIXED_SIZE
 #define NO_I64_FIXED_SIZE
 #define NO_STRCMPI_ALIAS
-#include "msvcrt-common.def.in"
+#include "crt-aliases.def.in"
diff --git a/mingw-w64-crt/lib32/msvcr100.def.in 
b/mingw-w64-crt/lib32/msvcr100.def.in
index 31a3580110d2..67f8e4cfd751 100644
--- a/mingw-w64-crt/lib32/msvcr100.def.in
+++ b/mingw-w64-crt/lib32/msvcr100.def.in
@@ -1907,4 +1907,4 @@ wscanf_s
 #define WITH_IMAXDIV_ALIAS
 #define WITH_STRTO64_ALIAS
 #define WITH_STRTO64_L_ALIAS
-#include "msvcrt-common.def.in"
+#include "crt-aliases.def.in"
diff --git a/mingw-w64-crt/lib32/msvcr110.def.in 
b/mingw-w64-crt/lib32/msvcr110.def.in
index a2dffde27b10..7ece206ebbc4 100644
--- a/mingw-w64-crt/lib32/msvcr110.def.in
+++ b/mingw-w64-crt/lib32/msvcr110.def.in
@@ -2039,4 +2039,4 @@ wscanf_s
 #define