Re: [Mingw-w64-public] [PATCH] Two secapi fixes

2014-01-20 Thread Kai Tietz
Hallo Eric,

both patches are ok.  Please apply to trunk.  Jon_y those patches
should be applied to 3.x branch too.

Thanks,
Kai


2014/1/19 Erik van Pienbroek e...@vanpienbroek.nl:
 Hi,

 One of our users tried to run a Qt5 based application on Windows XP and
 Windows Server 2003, but stumbled across a fatal error indicating that
 the symbol vsprintf_s isn't available in msvcrt.dll [1].

 After searching I've found out that the msvcrt.def.in still contains a
 reference to vsprintf_s even though there's a wrapper implementation of
 this symbol in mingw-w64-crt/secapi/vsprintf_s.c so it shouldn't be
 mentioned in the msvcrt.def.in file any more.

 After testing some more (see testcase at [2]) I also discovered some
 other issues with the secapi wrappers. The attached patches should fix
 these.

 Regards,

 Erik van Pienbroek

 [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1054481
 [2]:
 http://svn.nntpgrab.nl/svn/fedora_mingw_testsuite/trunk/testcases/def/secapi/


 --
 CenturyLink Cloud: The Leader in Enterprise Cloud Services.
 Learn Why More Businesses Are Choosing CenturyLink Cloud For
 Critical Workloads, Development Environments  Everything In Between.
 Get a Quote or Start a Free Trial Today.
 http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments  Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] [PATCH] Two secapi fixes

2014-01-20 Thread Erik van Pienbroek
Committed as r6450 and r6451

Kai Tietz schreef op ma 20-01-2014 om 15:00 [+0100]:
 Hallo Eric,
 
 both patches are ok.  Please apply to trunk.  Jon_y those patches
 should be applied to 3.x branch too.
 
 Thanks,
 Kai
 
 
 2014/1/19 Erik van Pienbroek e...@vanpienbroek.nl:
  Hi,
 
  One of our users tried to run a Qt5 based application on Windows XP and
  Windows Server 2003, but stumbled across a fatal error indicating that
  the symbol vsprintf_s isn't available in msvcrt.dll [1].
 
  After searching I've found out that the msvcrt.def.in still contains a
  reference to vsprintf_s even though there's a wrapper implementation of
  this symbol in mingw-w64-crt/secapi/vsprintf_s.c so it shouldn't be
  mentioned in the msvcrt.def.in file any more.
 
  After testing some more (see testcase at [2]) I also discovered some
  other issues with the secapi wrappers. The attached patches should fix
  these.
 
  Regards,
 
  Erik van Pienbroek
 
  [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1054481
  [2]:
  http://svn.nntpgrab.nl/svn/fedora_mingw_testsuite/trunk/testcases/def/secapi/
 
 
  --
  CenturyLink Cloud: The Leader in Enterprise Cloud Services.
  Learn Why More Businesses Are Choosing CenturyLink Cloud For
  Critical Workloads, Development Environments  Everything In Between.
  Get a Quote or Start a Free Trial Today.
  http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk
  ___
  Mingw-w64-public mailing list
  Mingw-w64-public@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
 
 
 --
 CenturyLink Cloud: The Leader in Enterprise Cloud Services.
 Learn Why More Businesses Are Choosing CenturyLink Cloud For
 Critical Workloads, Development Environments  Everything In Between.
 Get a Quote or Start a Free Trial Today. 
 http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments  Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public