Re: [Mingw-w64-public] [PATCH] for push/pop macro problem

2016-08-22 Thread David Wohlferd
On 8/21/2016 11:27 PM, Martin Storsjö wrote:
> On Sun, 21 Aug 2016, David Wohlferd wrote:
>
>> Under certain circumstances, the #pragma pop_macro("__has_builtin") at the
>> bottom of intrin-impl.h can be called without ever having hit the #pragma
>> push_macro("__has_builtin") at the top.  Clang warns about this, so I have
>> moved the push appropriately.
>>
>> Patch attached.
> The patch seems ok, although the nesting in that header isn't quite
> obvious.

True.  I thought about trying to move the 'pop' up, but quickly surrendered.

dw

--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


Re: [Mingw-w64-public] [PATCH] for push/pop macro problem

2016-08-22 Thread Martin Storsjö
On Sun, 21 Aug 2016, David Wohlferd wrote:

> Under certain circumstances, the #pragma pop_macro("__has_builtin") at the 
> bottom of intrin-impl.h can be called without ever having hit the #pragma 
> push_macro("__has_builtin") at the top.  Clang warns about this, so I have 
> moved the push appropriately.
>
> Patch attached.

The patch seems ok, although the nesting in that header isn't quite 
obvious.

// Martin

--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public