Re: [Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.
On 09/14/2018 04:52 PM, Liu Hao wrote: > 在 2018-09-14 22:17, Jacek Caban 写道: >> Signed-off-by: Jacek Caban >> --- >> mingw-w64-crt/lib32/dhcpcsvc.def | 63 >> >> 1 file changed, 63 insertions(+) >> >> > It looks good to me. Pushed, thanks. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.
在 2018-09-14 22:17, Jacek Caban 写道: > Signed-off-by: Jacek Caban > --- > mingw-w64-crt/lib32/dhcpcsvc.def | 63 > > 1 file changed, 63 insertions(+) > > It looks good to me. -- Best regards, LH_Mouse ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] [PATCH] dhcpcsvc.def: Add missing entries.
Signed-off-by: Jacek Caban --- mingw-w64-crt/lib32/dhcpcsvc.def | 63 1 file changed, 63 insertions(+) diff --git a/mingw-w64-crt/lib32/dhcpcsvc.def b/mingw-w64-crt/lib32/dhcpcsvc.def index 84023c7a..d1e733ca 100644 --- a/mingw-w64-crt/lib32/dhcpcsvc.def +++ b/mingw-w64-crt/lib32/dhcpcsvc.def @@ -1,8 +1,71 @@ LIBRARY DHCPCSVC.DLL EXPORTS +DhcpAcquireParameters@4 +DhcpAcquireParametersByBroadcast@4 +DhcpCApiCleanup DhcpCApiCleanup@0 DhcpCApiInitialize@4 +DhcpClient_Generalize +DhcpDeRegisterConnectionStateNotification@8 +DhcpDeRegisterOptions@4 DhcpDeRegisterParamChange@12 +DhcpDelPersistentRequestParams@8 +DhcpEnableDhcp@8 +DhcpEnableTracing@4 +DhcpEnumClasses@16 +DhcpEnumInterfaces@4 +DhcpFallbackRefreshParams@4 +DhcpFreeEnumeratedInterfaces@4 +DhcpFreeLeaseInfo@4 +DhcpFreeLeaseInfoArray@8 +DhcpFreeMem@4 +DhcpGetClassId@8 +DhcpGetClientId@8 +DhcpGetDhcpServicedConnections@12 +DhcpGetFallbackParams@8 +DhcpGetNotificationStatus@8 +DhcpGetOriginalSubnetMask@8 +DhcpGetTraceArray@4 +DhcpGlobalIsShuttingDown DATA +DhcpGlobalServiceSyncEvent DATA +DhcpGlobalTerminateEvent DATA +DhcpHandlePnPEvent@20 +DhcpIsEnabled@8 +DhcpLeaseIpAddress@24 +DhcpLeaseIpAddressEx@32 +DhcpNotifyConfigChange@28 +DhcpNotifyConfigChangeEx@32 +DhcpNotifyMediaReconnected@4 +DhcpOpenGlobalEvent +DhcpPersistentRequestParams@28 +DhcpQueryLeaseInfo@8 +DhcpQueryLeaseInfoArray@12 +DhcpQueryLeaseInfoEx@12 +DhcpRegisterConnectionStateNotification@12 +DhcpRegisterOptions@16 DhcpRegisterParamChange@28 DhcpRemoveDNSRegistrations@0 +DhcpReleaseIpAddressLease@8 +DhcpReleaseIpAddressLeaseEx@16 +DhcpReleaseParameters@4 +DhcpRemoveDNSRegistrations +DhcpRenewIpAddressLease@16 +DhcpRenewIpAddressLeaseEx@24 +DhcpRequestCachedParams@20 +DhcpRequestOptions@28 +DhcpRequestParams@44 +DhcpSetClassId@8 +DhcpSetClientId@8 +DhcpSetFallbackParams@8 +DhcpSetMSFTVendorSpecificOptions@24 +DhcpStaticRefreshParams@4 DhcpUndoRequestParams@16 +Dhcpv4CheckServerAvailability@8 +Dhcpv4EnableDhcpEx@4 +McastApiCleanup +McastApiStartup@4 +McastEnumerateScopes@20 +McastGenUID@4 +McastReleaseAddress@12 +McastRenewAddress@16 +McastRequestAddress@20 ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
在 2018/9/14 20:08, Jacek Caban 写道: > > *32 variants are handled by importlibs for crts that need it anyway and > unsuffixed variants don't exist in ucrt runtime. > This could break code that makes use of MSVCRT, as it is only in MSVCRT that `_fstat32` is absent. It exists in all MSVCR* DLLs since MSVCR80. > Signed-off-by: Jacek Caban > --- > mingw-w64-headers/crt/_mingw_stat64.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > > -- Best regards, LH_Mouse ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
[Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
*32 variants are handled by importlibs for crts that need it anyway and unsuffixed variants don't exist in ucrt runtime. Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/_mingw_stat64.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mingw-w64-headers/crt/_mingw_stat64.h b/mingw-w64-headers/crt/_mingw_stat64.h index d9909a89..00b68ce3 100644 --- a/mingw-w64-headers/crt/_mingw_stat64.h +++ b/mingw-w64-headers/crt/_mingw_stat64.h @@ -1,17 +1,14 @@ #ifndef _STAT_DEFINED #ifdef _USE_32BIT_TIME_T -#if __MSVCRT_VERSION__ >= 0x1400 #define _fstat _fstat32 #define _stat _stat32 #define _wstat _wstat32 +#if __MSVCRT_VERSION__ >= 0x1400 #define _fstati64 _fstat32i64 #define _stati64 _stat32i64 #define _wstati64 _wstat32i64 #else -#define _fstat32 _fstat -#define _stat32 _stat -#define _wstat32 _wstat #define _fstat32i64 _fstati64 #define _stat32i64 _stati64 #define _wstat32i64 _wstati64 ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
在 2018-09-14 20:22, Jacek Caban 写道:
> On 09/14/2018 02:21 PM, Liu Hao wrote:
>> 在 2018/9/14 20:08, Jacek Caban 写道:
>>> *32 variants are handled by importlibs for crts that need it anyway and
>>> unsuffixed variants don't exist in ucrt runtime.
>>>
>> This could break code that makes use of MSVCRT, as it is only in MSVCRT
>> that `_fstat32` is absent. It exists in all MSVCR* DLLs since MSVCR80.
>
> Our msvcrt importlib forwards _fstat32 to _fstat, so it should be fine.
>
> Jacek
>
Apparently it does not:
```
lh_mouse@lhmouse-ideapad ~/Desktop $ expand -t4 test.c
extern int printf(const char *, ...);
extern char _fstat32();
int main(void)
{
printf("%p\n", (void *)_fstat32);
}
lh_mouse@lhmouse-ideapad ~/Desktop $ x86_64-w64-mingw32-gcc test.c -lmsvcr80
lh_mouse@lhmouse-ideapad ~/Desktop $ x86_64-w64-mingw32-gcc test.c -lmsvcrt
/tmp/cc9yIfl5.o:test.c:(.rdata$.refptr._fstat32[.refptr._fstat32]+0x0):
undefined reference to `_fstat32'
collect2: error: ld returned 1 exit status
```
--
Best regards,
LH_Mouse
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
On 09/14/2018 03:25 PM, Liu Hao wrote:
> 在 2018-09-14 20:22, Jacek Caban 写道:
>> On 09/14/2018 02:21 PM, Liu Hao wrote:
>>> 在 2018/9/14 20:08, Jacek Caban 写道:
*32 variants are handled by importlibs for crts that need it anyway and
unsuffixed variants don't exist in ucrt runtime.
>>> This could break code that makes use of MSVCRT, as it is only in MSVCRT
>>> that `_fstat32` is absent. It exists in all MSVCR* DLLs since MSVCR80.
>> Our msvcrt importlib forwards _fstat32 to _fstat, so it should be fine.
>>
>> Jacek
>>
> Apparently it does not:
>
> ```
> lh_mouse@lhmouse-ideapad ~/Desktop $ expand -t4 test.c
> extern int printf(const char *, ...);
> extern char _fstat32();
>
> int main(void)
>{
> printf("%p\n", (void *)_fstat32);
>}
> lh_mouse@lhmouse-ideapad ~/Desktop $ x86_64-w64-mingw32-gcc test.c -lmsvcr80
> lh_mouse@lhmouse-ideapad ~/Desktop $ x86_64-w64-mingw32-gcc test.c -lmsvcrt
> /tmp/cc9yIfl5.o:test.c:(.rdata$.refptr._fstat32[.refptr._fstat32]+0x0):
> undefined reference to `_fstat32'
> collect2: error: ld returned 1 exit status
> ```
My patch is 32-bit only and so is importlib alias.
Jacek
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
在 2018/9/14 21:30, Jacek Caban 写道: > My patch is 32-bit only and so is importlib alias. > > Jacek > Oh I didn't notice this difference. And thanks for the reminder. The patch looks good. Please apply. -- Best regards, LH_Mouse ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] _mingw_stat64.h: Define _fstat, _stat and _wstat to *32 variants when appropriate.
On 09/14/2018 03:45 PM, Liu Hao wrote: > 在 2018/9/14 21:30, Jacek Caban 写道: >> My patch is 32-bit only and so is importlib alias. >> >> Jacek >> > Oh I didn't notice this difference. And thanks for the reminder. > > The patch looks good. Please apply. Pushed, thanks for review. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
