Re: opportunity to help: %s audit in mandoc
Hi everybody, Here is an updated list after doing what I said yesterday. One nit: I count 25 instances in cgi.c, not 27. // 27 cgi.c: all ok // 317: msg is only NULL when status == 200 // 351,353,379,405,409,421,425,497,499,527: compile-time string // constants and/or scriptname // 552: neither r[i].file nor req->q.manpath can be NULL if we got this far // 564,585,809,814: constants or cannot be NULL // 878: made it through validate_manpath // 915: req.q.manpath is set by caller // 1002,1149: compile-time string constant // 1163,1164,1169,1170: compile-time constant, dp cannot be NULL there // 1180: compile-time string constant // 4 dbm.c: all ok //85,92,96,102: dbm_map(fname) won // 5 dbm_map.c: all ok //60,73,80,87,97: open(fname) won // // 3 eqn.c: agree with Dariusz //305: p cannot be NULL //679: def->key is set above if def is NULL // 1077: eqnsyms[i].sym cannot be NULL So I guess I'll start on these next: 5 html.c: 20 main.c: 2 man.c: 2 man_html.c: 5 man_macro.c: ... and check you here: // 2 man_term.c: Please check me, too. 9 man_validate.c: 37 mandocdb.c: 2 manpath.c: 23 mansearch.c: 4 mdoc_html.c: // 10 mdoc_macro.c: 1 mdoc_man.c: 2 mdoc_term.c: 43 mdoc_validate.c: 6 read.c: 13 roff.c: // 1 tag.c: // 1 tbl_layout.c: // 1 tbl_opts.c: 6 term_ps.c: 11 tree.c: One thing I noticed in cgi.c, line 1015: what if there are multiple slashes at the head of path? I think this can happen unless I'm missing something. Pax, -A -- http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
Re: opportunity to help: %s audit in mandoc
Dariusz Sendkowski <dsendkow...@gmail.com> writes:
> From the list below:
>
> 27 cgi.c:
>4 dbm.c:
>5 dbm_map.c:
I'll start on these three...
>// 3 eqn.c:
... and check you here. When I get that far I'll post again, or if
it's taking me longer than I thought it would I'll post at the end of
the day anyway.
>5 html.c:
> 20 main.c:
>2 man.c:
>2 man_html.c:
>5 man_macro.c:
>// 2 man_term.c:
>9 man_validate.c:
> 37 mandocdb.c:
>2 manpath.c:
> 23 mansearch.c:
>4 mdoc_html.c:
>// 10 mdoc_macro.c:
>1 mdoc_man.c:
>2 mdoc_term.c:
> 43 mdoc_validate.c:
>6 read.c:
> 13 roff.c:
>// 1 tag.c:
>// 1 tbl_layout.c:
>// 1 tbl_opts.c:
>6 term_ps.c:
> 11 tree.c:
>
> I've checked the commented (//) files so far and they look fine. You can
> recheck or take new ones.
> Unfortunately, I don't have as much time as I'd like to so this goes rather
> slowly.
>
See you in a few hours :-)
Pax, -A
>
>
> 2016-08-09 18:41 GMT+02:00 attila <att...@stalphonsos.com>:
>
>> Hi {Ingo,Darius,misc@},
>>
>> Ingo Schwarze <schwa...@usta.de> writes:
>>
>> > Hi Dariusz,
>> >
>> > Dariusz Sendkowski wrote on Sun, Aug 07, 2016 at 08:27:07PM +0200:
>> >
>> >> OK, but from which branch?
>> >
>> > We don't use branches in OpenBSD.
>> > Just use the HEAD of the OpenBSD CVS repository.
>> >
>> > You don't need to worry about merging to the portable mandoc
>> > on mdocml.bsd.lv. That's a no-brainer i'll take care of.
>> >
>> >> Can the results be sent incrementally?
>> >
>> > Yes, that's ideal.
>> >
>> > Don't work for days before sending anything. Imagine you misunderstand
>> > something and only learn about your error after having wasted days
>> > of work. That would be bad. Or imagine two people start working
>> > on the same task and work for days, both preparing the same huge
>> > report. That would be a waste, too. That cannot happen if you
>> > send results incrementally right after finding them.
>>
>> Sorry I'm late to the party, as usual, but I had some trouble getting
>> my -current setup back to a reasonable state. I would like to pitch
>> in on this if it is still needed, and don't want to duplicate work. I
>> have a list of 221 hits for %s in /usr/src/usr.bin/mandoc in front of
>> me. Shall I start at the top or has that already happened?
>>
>> > In general, OpenBSD prefers small patches that are easy to understand
>> > and verify, in particular from new contributors. They need not be
>> > easy to produce, though.
>> >
>> > Yours,
>> > Ingo
>>
>> Pax, -A
>> --
>> http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
--
http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
Re: opportunity to help: %s audit in mandoc
Hi {Ingo,Darius,misc@},
Ingo Schwarze <schwa...@usta.de> writes:
> Hi Dariusz,
>
> Dariusz Sendkowski wrote on Sun, Aug 07, 2016 at 08:27:07PM +0200:
>
>> OK, but from which branch?
>
> We don't use branches in OpenBSD.
> Just use the HEAD of the OpenBSD CVS repository.
>
> You don't need to worry about merging to the portable mandoc
> on mdocml.bsd.lv. That's a no-brainer i'll take care of.
>
>> Can the results be sent incrementally?
>
> Yes, that's ideal.
>
> Don't work for days before sending anything. Imagine you misunderstand
> something and only learn about your error after having wasted days
> of work. That would be bad. Or imagine two people start working
> on the same task and work for days, both preparing the same huge
> report. That would be a waste, too. That cannot happen if you
> send results incrementally right after finding them.
Sorry I'm late to the party, as usual, but I had some trouble getting
my -current setup back to a reasonable state. I would like to pitch
in on this if it is still needed, and don't want to duplicate work. I
have a list of 221 hits for %s in /usr/src/usr.bin/mandoc in front of
me. Shall I start at the top or has that already happened?
> In general, OpenBSD prefers small patches that are easy to understand
> and verify, in particular from new contributors. They need not be
> easy to produce, though.
>
> Yours,
> Ingo
Pax, -A
--
http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
Re: Static webpages with OpenBSD - success stories
Paolo Aglialoro <paol...@gmail.com> writes: > Hello, > > yesterday I've been at an interesting presentation of pelican (it was a > git+pelican+fabric gramework), in order to create static websites and I > very much appreciated the topic. I had also recently had a look at jekill > (which looks kinda promising), but discovered that there is a whole "world" > of static site generators described at the page > https://staticsitegenerators.net/ among which some look also interesting to > me in case of customizations because just based on shell scripts and not on > python/java/perl/etc in which I am not fluent: I am starting from the basic > bashblog to more complex like rawk, baker, simsalabash. > > After a quick peek on openports I have seen pelican present, but couldn't > identify more. On hugo webpage there's a package for OpenBSD > https://github.com/spf13/hugo/releases > > Did you have success experiences with them or similar products on OpenBSD > (e.g. octopress, jekyll, etc)? What would you advice to build a static site > which should sport light but sexy template (e.g. scroll effects), multiple > pages, pictures and some media links (like embedded youtube videos, for > instance)? Use of googleforms would be a bonus. > > Also, on source language: although being asciidoc present in OpenBSD, > markdown seems at the moment the "industry standard". In ports, besides > python version of markdown, I've found a really interesting C port of it, > named "discount". Do you have had any previous experience with it and would > you suggest it instead of plain python version? FWIW, textproc/multimarkdown is pretty nice for static sites. https://torbsd.github.io is done in multimarkdown with a simple Makefile and some CSS. I also use multimarkdown to generate PDFs, via dblatex - always looks nice (but maybe I'm easier to please than you :-). Multimarkdown's simple extensions to markdown are all useful, no fluff. > > Thanks Pax, -A -- http://haqistan.net/~attila | att...@stalphonsos.com | 0x62A729CF
