[PATCH] chat(8) manpage clarification

2011-07-25 Thread Stefan Unterweger
Hi!

I've recently tried debugging a pppd(8) connection and noticed that the
information in the chat(8) manpage was a little imprecise with regard to
how logging is done.

According to chat.c (lines 304 onward, from 4.9-release), it will log
using facility LOCAL2 and level WARNING. If -v is specified, it will
also log up to level INFO. I think it might be useful to include this
information in the manpage as well; see patch below.


Regards,
s//un


Index: chat/chat.8
===
RCS file: /cvs/src/usr.sbin/pppd/chat/chat.8,v
retrieving revision 1.18
diff -u -r1.18 chat.8
--- chat/chat.8 28 Oct 2010 18:34:44 -  1.18
+++ chat/chat.8 25 Jul 2011 15:08:18 -
@@ -58,8 +58,12 @@
 .It Fl S
 Do not use
 .Xr syslog 3 .
-By default, error messages are logged via
-.Xr syslog 3 .
+By default, error messages are logged through
+.Xr syslog 3
+with facility
+.Ar local2
+and level
+.Ar warning .
 The use of
 .Fl S
 will prevent both log messages from
@@ -110,8 +114,10 @@
 .Nm
 program will then log the execution state of the chat script as well as all
 text received from the modem and the output strings sent to the modem.
-The default is to log via
-.Xr syslog 3 ;
+The default is to log through
+.Xr syslog 3
+with level
+.Ar info ;
 the logging method may be altered with the
 .Fl S
 and

[demime 1.01d removed an attachment of type application/pgp-signature]



Re: [PATCH] chat(8) manpage clarification

2011-07-25 Thread David Coppa
On Mon, Jul 25, 2011 at 5:20 PM, Stefan Unterweger ste...@aleturo.com
wrote:
 Hi!

 I've recently tried debugging a pppd(8) connection and noticed that the
 information in the chat(8) manpage was a little imprecise with regard to
 how logging is done.

 According to chat.c (lines 304 onward, from 4.9-release), it will log
 using facility LOCAL2 and level WARNING. If -v is specified, it will
 also log up to level INFO. I think it might be useful to include this
 information in the manpage as well; see patch below.


 Regards,
s//un


 Index: chat/chat.8
 ===
 RCS file: /cvs/src/usr.sbin/pppd/chat/chat.8,v
 retrieving revision 1.18
 diff -u -r1.18 chat.8
 --- chat/chat.8 28 Oct 2010 18:34:44 -  1.18
 +++ chat/chat.8 25 Jul 2011 15:08:18 -
 @@ -58,8 +58,12 @@
  .It Fl S
  Do not use
  .Xr syslog 3 .
 -By default, error messages are logged via
 -.Xr syslog 3 .
 +By default, error messages are logged through
 +.Xr syslog 3
 +with facility
 +.Ar local2
 +and level
 +.Ar warning .
  The use of
  .Fl S
  will prevent both log messages from
 @@ -110,8 +114,10 @@
  .Nm
  program will then log the execution state of the chat script as well as
all
  text received from the modem and the output strings sent to the modem.
 -The default is to log via
 -.Xr syslog 3 ;
 +The default is to log through
 +.Xr syslog 3
 +with level
 +.Ar info ;
  the logging method may be altered with the
  .Fl S
  and

Having scratched my head around this in the past, I can say I like it.
Ok for me.

ciao,
David



Re: [PATCH] chat(8) manpage clarification

2011-07-25 Thread Jason McIntyre
On Mon, Jul 25, 2011 at 08:03:32PM +0200, David Coppa wrote:
 On Mon, Jul 25, 2011 at 5:20 PM, Stefan Unterweger ste...@aleturo.com wrote:
  Hi!
 
  I've recently tried debugging a pppd(8) connection and noticed that the
  information in the chat(8) manpage was a little imprecise with regard to
  how logging is done.
 
  According to chat.c (lines 304 onward, from 4.9-release), it will log
  using facility LOCAL2 and level WARNING. If -v is specified, it will
  also log up to level INFO. I think it might be useful to include this
  information in the manpage as well; see patch below.
 
 
  Regards,
  ? ?s//un
 
 
  Index: chat/chat.8
  ===
  RCS file: /cvs/src/usr.sbin/pppd/chat/chat.8,v
  retrieving revision 1.18
  diff -u -r1.18 chat.8
  --- chat/chat.8 28 Oct 2010 18:34:44 - ? ? ?1.18
  +++ chat/chat.8 25 Jul 2011 15:08:18 -
  @@ -58,8 +58,12 @@
  ?.It Fl S
  ?Do not use
  ?.Xr syslog 3 .
  -By default, error messages are logged via
  -.Xr syslog 3 .
  +By default, error messages are logged through
  +.Xr syslog 3
  +with facility
  +.Ar local2
  +and level
  +.Ar warning .
  ?The use of
  ?.Fl S
  ?will prevent both log messages from
  @@ -110,8 +114,10 @@
  ?.Nm
  ?program will then log the execution state of the chat script as well as all
  ?text received from the modem and the output strings sent to the modem.
  -The default is to log via
  -.Xr syslog 3 ;
  +The default is to log through
  +.Xr syslog 3
  +with level
  +.Ar info ;
  ?the logging method may be altered with the
  ?.Fl S
  ?and
 
 Having scratched my head around this in the past, I can say I like it.
 Ok for me.
 
 ciao,
 David

i committed this with two tweaks:

- i used Dq for the facility/level, since that seems more consistent
  with the syslog pages

- i made a small wording tweak, for readability, that was unrelated to
  the diff

jmc