Re: No sound on ThinkPad X220 using current snapshot

2022-02-16 Thread Dirk-Wilhelm Peters
Matthias Schmidt  wrote:

> * Alexandre Ratchov wrote:
> > On Mon, Feb 14, 2022 at 01:11:09PM +0100, Dirk-Wilhelm Peters wrote:
> > > Hi,
> > > 
> > > after a recent update to the latest snapshot on my ThinkPad X220, there
> > > is no sound after returning from suspend mode. The problem persists
> > > even after a reboot. I have to shutdown/restart the machine to enable
> > > audio output again. Headphone output is not affected.
> > > 
> > 
> > This is recent regression, right?

Yes. The latest snapshot fixes the problem.

> > FWIW mixer settings are saved during suspend and restored on
> > resume. Working headphones suggests this may be caused by parts of the
> > system (speaker amplifiers) not being powered.
> 
> FYI, I had the same issue with a Thinkpad X250 and the recent snapshot
> from this morning fixed it for me.
> 
> OpenBSD 7.0-current (GENERIC) #336: Wed Feb 16 01:14:53 MST 2022

I have just upgraded my machine (X220) and can confirm that the problem has been
fixed.

OpenBSD 7.0-current (GENERIC.MP) #346: Tue Feb 15 11:51:21 MST 2022
dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 12746092544 (12155MB)
avail mem = 12342587392 (11770MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.6 @ 0xdae9c000 (67 entries)
bios0: vendor LENOVO version "8DET52WW (1.22 )" date 09/15/2011
bios0: LENOVO 4290W1B
acpi0 at bios0: ACPI 4.0
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP SSDT SSDT SSDT HPET APIC MCFG ECDT ASF! TCPA SSDT SSDT 
DMAR UEFI UEFI UEFI
acpi0: wakeup devices LID_(S3) SLPB(S3) IGBE(S4) EXP4(S4) EXP7(S4) EHC1(S3) 
EHC2(S3) HDEF(S4)
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.54 MHz, 06-2a-07
cpu0: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu0: 256KB 64b/line 8-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
cpu0: apic clock running at 99MHz
cpu0: mwait min=64, max=64, C-substates=0.2.1.1.2, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.41 MHz, 06-2a-07
cpu1: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu1: 256KB 64b/line 8-way L2 cache
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.42 MHz, 06-2a-07
cpu2: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu2: 256KB 64b/line 8-way L2 cache
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 797.41 MHz, 06-2a-07
cpu3: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu3: 256KB 64b/line 8-way L2 cache
cpu3: smt 1, core 1, package 0
ioapic0 at mainbus0: apid 2 pa 0xfec0, version 20, 24 pins
acpimcfg0 at acpi0
acpimcfg0: addr 0xf800, bus 0-63
acpiec0 at acpi0
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus -1 (PEG_)
acpiprt2 at acpi0: bus 2 (EXP1)
acpiprt3 at acpi0: bus 3 (EXP2)
acpiprt4 at acpi0: bus 5 (EXP4)
acpiprt5 at acpi0: bus 13 (EXP5)
acpiprt6 at acpi0: bus -1 (EXP7)
acpibtn0 at acpi0: LID_
acpibtn1 at acpi0: SLPB
acpipci0 at acpi0 PCI0: 0x 0x0011 0x0001
acpicmos0 at acpi0
tpm0 at acpi0 TPM_ 1.2 (TIS) addr 0xfed4/0x5000, device 0x104a rev 0x4e
acpibat0 at acpi0: BAT0 model "42T4861" serial  5709 type LION oem "SANYO"
acpiac0 at acpi0: AC unit online
acpithinkpad0 at acpi0: version 1.0
"PNP0C14" at acpi0 not configured
"PNP0C14" at acpi0 not configured
acpicpu0 at acpi0: C3(350@104 io@0x415), C1(1000@1 halt), PSS
acpicpu1 at acpi0: C3(350@104 io@0x415), C1(1000@1 halt), PSS
acp

Re: No sound on ThinkPad X220 using current snapshot

2022-02-16 Thread Matthias Schmidt
Hi,

* Alexandre Ratchov wrote:
> On Mon, Feb 14, 2022 at 01:11:09PM +0100, Dirk-Wilhelm Peters wrote:
> > Hi,
> > 
> > after a recent update to the latest snapshot on my ThinkPad X220, there
> > is no sound after returning from suspend mode. The problem persists
> > even after a reboot. I have to shutdown/restart the machine to enable
> > audio output again. Headphone output is not affected.
> > 
> 
> This is recent regression, right?
> 
> FWIW mixer settings are saved during suspend and restored on
> resume. Working headphones suggests this may be caused by parts of the
> system (speaker amplifiers) not being powered.

FYI, I had the same issue with a Thinkpad X250 and the recent snapshot
from this morning fixed it for me.

OpenBSD 7.0-current (GENERIC) #336: Wed Feb 16 01:14:53 MST 2022

Cheers

Matthias



Re: No sound on ThinkPad X220 using current snapshot

2022-02-16 Thread Alexandre Ratchov
On Mon, Feb 14, 2022 at 01:11:09PM +0100, Dirk-Wilhelm Peters wrote:
> Hi,
> 
> after a recent update to the latest snapshot on my ThinkPad X220, there
> is no sound after returning from suspend mode. The problem persists
> even after a reboot. I have to shutdown/restart the machine to enable
> audio output again. Headphone output is not affected.
> 

This is recent regression, right?

FWIW mixer settings are saved during suspend and restored on
resume. Working headphones suggests this may be caused by parts of the
system (speaker amplifiers) not being powered.



Re: No sound on ThinkPad X220 using current snapshot

2022-02-14 Thread Theo de Raadt
Josh Grosse  wrote:

> On Mon, Feb 14, 2022 at 05:58:37PM +0100, Dirk-Wilhelm Peters wrote:
> > "Theo de Raadt"  wrote:
> > 
> > > > OpenBSD 7.0-current (GENERIC.MP) #325: Thu Feb 10 12:26:12 MST 2022
> > > 
> > > Your subject says "current snapshot".  But then you show a 4-day old
> > > kernel.
> > > 
> > > You can do better.
> > 
> > Yes. Kernel #334 is also silent after returning from suspend mode.
>  
> I have the same X220 hardware.  Bisecting the kernel indicates this
> commit caused the regression.  Tested on the X220 with GENERIC.MP.
> 
> commit ad814436a071b6401bfaf527a709138b9bf992e2 (refs/bisect/bad)
> Author: deraadt 
> Date:   Tue Feb 8 17:25:10 2022 +
> 
> The suspend/resume code is a sticky mess of MI, MD, and ACPI sequencing.
> This splits out the MI sequencing, backing it with per-architecture helper
> functions.  Further steps will be neccesary because ACPI and MD are too
> tightly coupled, but soon we'll be able to use this code for more 
> architectures
> (which depends on figuring out the lowest-level cpu sleeping method)
> ok kettenis

I was meticulous about keeping the order-of-operations the same as before,
but something very subtle has happened.

We need to recall that suspend/resume on some machines has never behaved
perfectly.  Maybe some heisenbug has moved around.  I've been re-reading all
morning and I still can't see any reason.



Re: No sound on ThinkPad X220 using current snapshot

2022-02-14 Thread Josh Grosse
On Mon, Feb 14, 2022 at 05:58:37PM +0100, Dirk-Wilhelm Peters wrote:
> "Theo de Raadt"  wrote:
> 
> > > OpenBSD 7.0-current (GENERIC.MP) #325: Thu Feb 10 12:26:12 MST 2022
> > 
> > Your subject says "current snapshot".  But then you show a 4-day old
> > kernel.
> > 
> > You can do better.
> 
> Yes. Kernel #334 is also silent after returning from suspend mode.
 
I have the same X220 hardware.  Bisecting the kernel indicates this
commit caused the regression.  Tested on the X220 with GENERIC.MP.

commit ad814436a071b6401bfaf527a709138b9bf992e2 (refs/bisect/bad)
Author: deraadt 
Date:   Tue Feb 8 17:25:10 2022 +

The suspend/resume code is a sticky mess of MI, MD, and ACPI sequencing.
This splits out the MI sequencing, backing it with per-architecture helper
functions.  Further steps will be neccesary because ACPI and MD are too
tightly coupled, but soon we'll be able to use this code for more 
architectures
(which depends on figuring out the lowest-level cpu sleeping method)
ok kettenis



Re: No sound on ThinkPad X220 using current snapshot

2022-02-14 Thread Theo de Raadt
Dirk-Wilhelm Peters  wrote:

> "Theo de Raadt"  wrote:
> 
> > > OpenBSD 7.0-current (GENERIC.MP) #325: Thu Feb 10 12:26:12 MST 2022
> > 
> > Your subject says "current snapshot".  But then you show a 4-day old
> > kernel.
> > 
> > You can do better.
> 
> Yes. Kernel #334 is also silent after returning from suspend mode.

That number is not a point of reference.  Sorry, I don't have time for
incomplete bug reports.



Re: No sound on ThinkPad X220 using current snapshot

2022-02-14 Thread Dirk-Wilhelm Peters
"Theo de Raadt"  wrote:

> > OpenBSD 7.0-current (GENERIC.MP) #325: Thu Feb 10 12:26:12 MST 2022
> 
> Your subject says "current snapshot".  But then you show a 4-day old
> kernel.
> 
> You can do better.

Yes. Kernel #334 is also silent after returning from suspend mode.



Re: No sound on ThinkPad X220 using current snapshot

2022-02-14 Thread Theo de Raadt
> OpenBSD 7.0-current (GENERIC.MP) #325: Thu Feb 10 12:26:12 MST 2022

Your subject says "current snapshot".  But then you show a 4-day old
kernel.

You can do better.