Re: OpenSMTPD 7.3.0p0 rc1 -- please test!

2023-06-09 Thread Andi Vajda



On Fri, 9 Jun 2023, Omar Polo wrote:


Sorry for the delay,


I was able to build the release 7.3 branch on NetBSD 9.3 with libressl 3.7.3 
and with openssl 3.1.1. Both configurations appear to work !


Thank you for the fixes !

Andi..



On 2023/06/05 15:20:38 -0700, Andi Vajda  wrote:


On Mon, 5 Jun 2023, Andi Vajda wrote:


The build succeeds but running a debug session:
 sudo ./local/sbin/smtpd -f `pwd`/smtpd.conf -dv

fails. I'm not sure how much of my debug logs is appropriate to post here but
I could try to build with openssl 3 next ?


Same problem with smtpd built with openssl 3.3.1: build succeeds, smtpd.conf
is validated OK when running with -n but when I start a debug session with
-dv, the server starts but eventually fails but is not saying much about
what is failing. It looks like a child process is terminating:
   warn: lost child: dispatcher terminated; signal 11
I also tried without --with-libevent=/usr/pkg
(and yes, I did not forget to stop my 6.8.0p2 server first)


I've fixed both issues.  The crash at runtime was due to a missing
-D_OPENBSD_SOURCE.  The TL;DR is that the configure script managed to
find functions like reallocarray (linking works) but the prototypes
are hidden behind a #ifdef _OPENBSD_SOURCE on NetBSD.  The compiler
then assumed these returned an `int' and... yeah.

The build failure with libressl was due to a wrong order in the
configure script: libtls is searched *before* --with-libssl is
handled.

I've committed a fix both in the master and in the release-7.3 branch,
but no new RC.

Can you verify it works for you too?  You should ignore the tarball
and checkout the branch release-7.3 from the git repository.


Thanks!

Omar Polo





Re: OpenSMTPD 7.3.0p0 rc1 -- please test!

2023-06-09 Thread Omar Polo
Sorry for the delay,

On 2023/06/05 15:20:38 -0700, Andi Vajda  wrote:
> 
> On Mon, 5 Jun 2023, Andi Vajda wrote:
> 
> > The build succeeds but running a debug session:
> >  sudo ./local/sbin/smtpd -f `pwd`/smtpd.conf -dv
> >
> > fails. I'm not sure how much of my debug logs is appropriate to post here 
> > but 
> > I could try to build with openssl 3 next ?
> 
> Same problem with smtpd built with openssl 3.3.1: build succeeds, smtpd.conf 
> is validated OK when running with -n but when I start a debug session with 
> -dv, the server starts but eventually fails but is not saying much about 
> what is failing. It looks like a child process is terminating:
>warn: lost child: dispatcher terminated; signal 11
> I also tried without --with-libevent=/usr/pkg
> (and yes, I did not forget to stop my 6.8.0p2 server first)

I've fixed both issues.  The crash at runtime was due to a missing
-D_OPENBSD_SOURCE.  The TL;DR is that the configure script managed to
find functions like reallocarray (linking works) but the prototypes
are hidden behind a #ifdef _OPENBSD_SOURCE on NetBSD.  The compiler
then assumed these returned an `int' and... yeah.

The build failure with libressl was due to a wrong order in the
configure script: libtls is searched *before* --with-libssl is
handled.

I've committed a fix both in the master and in the release-7.3 branch,
but no new RC.

Can you verify it works for you too?  You should ignore the tarball
and checkout the branch release-7.3 from the git repository.


Thanks!

Omar Polo