Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

I finally got it compile on my machine.

I sent a PR with all the changes I made :

https://github.com/mixxxdj/mixxx/pull/743

sb

Le 16/10/2015 00:31, Sébastien Blaisot a écrit :
> in fact, both of them need to be replaced with
> TAGLIB_FILENAME_FROM_QSTRING(getFilename())
>
> sb
>
> Le 16/10/2015 00:24, Sébastien Blaisot a écrit :
>> sorry, wrong line.
>>
>> I meant
>> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396
>>
>> sb
>>
>> Le 16/10/2015 00:09, Sébastien Blaisot a écrit :
>>> Probably you also need to patch this :
>>> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105
>>>
>>> I have a link-time error (unresolved external symbol) for
>>> soundsourcemediafoundation
>>>
>>> sb
>>>
>>> Le 15/10/2015 23:59, Daniel Schürmann a écrit :
 Nice! Then I will prepare a commit, using this.

 Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot:
> I have no idea.
> It is available in Visual Studio 2010, 2012, 2013 and 2015
> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
> but I don't know if it is dependant of an option at compile time.
>
> I know it works perfectly for me, out of the box (no special
> configuration for VC) using scons and mixxx 1.12 config ;)
>
> sb
>
> Le 15/10/2015 23:50, Daniel Schürmann a écrit :
>> Is this available on VC without c++11 support?
>>
>> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
>>> As we are in a #ifdef _WIN32, why not using native static_assert ?
>>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>>>
>>> sb
>>> --
>>> ___
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

in fact, both of them need to be replaced with
TAGLIB_FILENAME_FROM_QSTRING(getFilename())

sb

Le 16/10/2015 00:24, Sébastien Blaisot a écrit :
> sorry, wrong line.
>
> I meant
> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396
>
> sb
>
> Le 16/10/2015 00:09, Sébastien Blaisot a écrit :
>> Probably you also need to patch this :
>> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105
>>
>> I have a link-time error (unresolved external symbol) for
>> soundsourcemediafoundation
>>
>> sb
>>
>> Le 15/10/2015 23:59, Daniel Schürmann a écrit :
>>> Nice! Then I will prepare a commit, using this.
>>>
>>> Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot:
 I have no idea.
 It is available in Visual Studio 2010, 2012, 2013 and 2015
 https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
 but I don't know if it is dependant of an option at compile time.

 I know it works perfectly for me, out of the box (no special
 configuration for VC) using scons and mixxx 1.12 config ;)

 sb

 Le 15/10/2015 23:50, Daniel Schürmann a écrit :
> Is this available on VC without c++11 support?
>
> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
>> As we are in a #ifdef _WIN32, why not using native static_assert ?
>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>>
>> sb
>>
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

sorry, wrong line.

I meant 
https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396

sb

Le 16/10/2015 00:09, Sébastien Blaisot a écrit :
> Probably you also need to patch this :
> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105
>
> I have a link-time error (unresolved external symbol) for
> soundsourcemediafoundation
>
> sb
>
> Le 15/10/2015 23:59, Daniel Schürmann a écrit :
>> Nice! Then I will prepare a commit, using this.
>>
>> Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot:
>>> I have no idea.
>>> It is available in Visual Studio 2010, 2012, 2013 and 2015
>>> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
>>> but I don't know if it is dependant of an option at compile time.
>>>
>>> I know it works perfectly for me, out of the box (no special
>>> configuration for VC) using scons and mixxx 1.12 config ;)
>>>
>>> sb
>>>
>>> Le 15/10/2015 23:50, Daniel Schürmann a écrit :
 Is this available on VC without c++11 support?

 Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
> As we are in a #ifdef _WIN32, why not using native static_assert ?
> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>
> sb
>
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

Probably you also need to patch this :
https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105

I have a link-time error (unresolved external symbol) for 
soundsourcemediafoundation

sb

Le 15/10/2015 23:59, Daniel Schürmann a écrit :
> Nice! Then I will prepare a commit, using this.
>
> Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot:
>> I have no idea.
>> It is available in Visual Studio 2010, 2012, 2013 and 2015
>> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
>> but I don't know if it is dependant of an option at compile time.
>>
>> I know it works perfectly for me, out of the box (no special
>> configuration for VC) using scons and mixxx 1.12 config ;)
>>
>> sb
>>
>> Le 15/10/2015 23:50, Daniel Schürmann a écrit :
>>> Is this available on VC without c++11 support?
>>>
>>> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
 As we are in a #ifdef _WIN32, why not using native static_assert ?
 https://msdn.microsoft.com/fr-fr/library/dd293588.aspx

 sb



--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann 
Nice! Then I will prepare a commit, using this.

Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot:
> I have no idea.
> It is available in Visual Studio 2010, 2012, 2013 and 2015
> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
> but I don't know if it is dependant of an option at compile time.
>
> I know it works perfectly for me, out of the box (no special
> configuration for VC) using scons and mixxx 1.12 config ;)
>
> sb
>
> Le 15/10/2015 23:50, Daniel Schürmann a écrit :
>> Is this available on VC without c++11 support?
>>
>> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
>>> As we are in a #ifdef _WIN32, why not using native static_assert ?
>>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>>>
>>> sb
>>>
>>> Le 15/10/2015 22:05, Daniel Schürmann a écrit :
 Thank you.

 I have fixed the issue and have a working STATIC_ASSERT
 just build local, will commit next.


 Am 15.10.2015 um 22:00 schrieb Owen Williams:
> Still failing:
>
>
> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
> soundsourcemediafoundation.cpp
>
> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
> warning C4005: 'NOMINMAX' : macro redefinition
>  command-line arguments :  see previous definition of 
> 'NOMINMAX'
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
> error C2614: 'SoundSourceMediaFoundation' : illegal member
> initialization: 'm_wcFilename' is not a base or member
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
> error C2065: 'm_wcFilename' : undeclared identifier
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2065: 'm_wcFilename' : undeclared identifier
>
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2541: 'delete' : cannot delete objects that are not pointers
> scons: *** [win64_build\plugins\win64_build\mediafoundation
> \soundsourcemediafoundation.obj] Error 2
> scons: building terminated because of errors.
>
> Build step 'Execute Windows batch command' marked build as failure
> Recording test results
> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
> were found but none of them are new. Did tests run?
> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
> \windows\test_results.xml is 14 days old
>
> SSH: Current build result is [FAILURE], not going to run.
>
> Finished: FAILURE
>
>
> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
>> NULL),
>>
>> You're missing a closing parenthesis
>>
>> —
>> Reply to this email directly or view it on GitHub.
>>
>>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
 --
 ___
 Get Mixxx, the #1 Free MP3 DJ Mixing software Today
 http://mixxx.org


 Mixxx-devel mailing list
 Mixxx-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>> --
>>> ___
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

I have no idea.
It is available in Visual Studio 2010, 2012, 2013 and 2015
https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist
but I don't know if it is dependant of an option at compile time.

I know it works perfectly for me, out of the box (no special 
configuration for VC) using scons and mixxx 1.12 config ;)

sb

Le 15/10/2015 23:50, Daniel Schürmann a écrit :
> Is this available on VC without c++11 support?
>
> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
>> As we are in a #ifdef _WIN32, why not using native static_assert ?
>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>>
>> sb
>>
>> Le 15/10/2015 22:05, Daniel Schürmann a écrit :
>>> Thank you.
>>>
>>> I have fixed the issue and have a working STATIC_ASSERT
>>> just build local, will commit next.
>>>
>>>
>>> Am 15.10.2015 um 22:00 schrieb Owen Williams:
 Still failing:


 cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
 soundsourcemediafoundation.cpp

 c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
 warning C4005: 'NOMINMAX' : macro redefinition
 command-line arguments :  see previous definition of 'NOMINMAX'
 plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
 error C2614: 'SoundSourceMediaFoundation' : illegal member
 initialization: 'm_wcFilename' is not a base or member
 plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
 error C2065: 'm_wcFilename' : undeclared identifier
 plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
 error C2065: 'm_wcFilename' : undeclared identifier

 plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
 error C2541: 'delete' : cannot delete objects that are not pointers
 scons: *** [win64_build\plugins\win64_build\mediafoundation
 \soundsourcemediafoundation.obj] Error 2
 scons: building terminated because of errors.

 Build step 'Execute Windows batch command' marked build as failure
 Recording test results
 ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
 were found but none of them are new. Did tests run?
 For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
 \windows\test_results.xml is 14 days old

 SSH: Current build result is [FAILURE], not going to run.

 Finished: FAILURE


 On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
> NULL),
>
> You're missing a closing parenthesis
>
> —
> Reply to this email directly or view it on GitHub.
>
>
 --
 ___
 Get Mixxx, the #1 Free MP3 DJ Mixing software Today
 http://mixxx.org


 Mixxx-devel mailing list
 Mixxx-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>> --
>>> ___
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

It seems to be compiling fine if you replace

STATIC_ASSERT(sizeof(wchar_t) == sizeof(QChar));

with

static_assert(sizeof(wchar_t) == sizeof(QChar), "wchar_t is not the same 
size than QChar");

and remove STATIC_ASSERT definition in src/util/assert.h

sb

Le 15/10/2015 23:41, Sébastien Blaisot a écrit :
> As we are in a #ifdef _WIN32, why not using native static_assert ?
> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>
> sb
>
> Le 15/10/2015 22:05, Daniel Schürmann a écrit :
>> Thank you.
>>
>> I have fixed the issue and have a working STATIC_ASSERT
>> just build local, will commit next.
>>
>>
>> Am 15.10.2015 um 22:00 schrieb Owen Williams:
>>> Still failing:
>>>
>>>
>>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
>>> soundsourcemediafoundation.cpp
>>>
>>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
>>> warning C4005: 'NOMINMAX' : macro redefinition
>>>command-line arguments :  see previous definition of 'NOMINMAX'
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
>>> error C2614: 'SoundSourceMediaFoundation' : illegal member
>>> initialization: 'm_wcFilename' is not a base or member
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
>>> error C2065: 'm_wcFilename' : undeclared identifier
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>>> error C2065: 'm_wcFilename' : undeclared identifier
>>>
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>>> error C2541: 'delete' : cannot delete objects that are not pointers
>>> scons: *** [win64_build\plugins\win64_build\mediafoundation
>>> \soundsourcemediafoundation.obj] Error 2
>>> scons: building terminated because of errors.
>>>
>>> Build step 'Execute Windows batch command' marked build as failure
>>> Recording test results
>>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
>>> were found but none of them are new. Did tests run?
>>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
>>> \windows\test_results.xml is 14 days old
>>>
>>> SSH: Current build result is [FAILURE], not going to run.
>>>
>>> Finished: FAILURE
>>>
>>>
>>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
 NULL),

 You're missing a closing parenthesis

 —
 Reply to this email directly or view it on GitHub.


>>> --
>>> ___
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann 
Is this available on VC without c++11 support?

Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot:
> As we are in a #ifdef _WIN32, why not using native static_assert ?
> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx
>
> sb
>
> Le 15/10/2015 22:05, Daniel Schürmann a écrit :
>> Thank you.
>>
>> I have fixed the issue and have a working STATIC_ASSERT
>> just build local, will commit next.
>>
>>
>> Am 15.10.2015 um 22:00 schrieb Owen Williams:
>>> Still failing:
>>>
>>>
>>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
>>> soundsourcemediafoundation.cpp
>>>
>>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
>>> warning C4005: 'NOMINMAX' : macro redefinition
>>>command-line arguments :  see previous definition of 'NOMINMAX'
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
>>> error C2614: 'SoundSourceMediaFoundation' : illegal member
>>> initialization: 'm_wcFilename' is not a base or member
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
>>> error C2065: 'm_wcFilename' : undeclared identifier
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>>> error C2065: 'm_wcFilename' : undeclared identifier
>>>
>>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>>> error C2541: 'delete' : cannot delete objects that are not pointers
>>> scons: *** [win64_build\plugins\win64_build\mediafoundation
>>> \soundsourcemediafoundation.obj] Error 2
>>> scons: building terminated because of errors.
>>>
>>> Build step 'Execute Windows batch command' marked build as failure
>>> Recording test results
>>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
>>> were found but none of them are new. Did tests run?
>>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
>>> \windows\test_results.xml is 14 days old
>>>
>>> SSH: Current build result is [FAILURE], not going to run.
>>>
>>> Finished: FAILURE
>>>
>>>
>>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
 NULL),

 You're missing a closing parenthesis

 —
 Reply to this email directly or view it on GitHub.


>>> --
>>> ___
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

As we are in a #ifdef _WIN32, why not using native static_assert ?
https://msdn.microsoft.com/fr-fr/library/dd293588.aspx

sb

Le 15/10/2015 22:05, Daniel Schürmann a écrit :
> Thank you.
>
> I have fixed the issue and have a working STATIC_ASSERT
> just build local, will commit next.
>
>
> Am 15.10.2015 um 22:00 schrieb Owen Williams:
>> Still failing:
>>
>>
>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
>> soundsourcemediafoundation.cpp
>>
>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
>> warning C4005: 'NOMINMAX' : macro redefinition
>>   command-line arguments :  see previous definition of 'NOMINMAX'
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
>> error C2614: 'SoundSourceMediaFoundation' : illegal member
>> initialization: 'm_wcFilename' is not a base or member
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
>> error C2065: 'm_wcFilename' : undeclared identifier
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>> error C2065: 'm_wcFilename' : undeclared identifier
>>
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>> error C2541: 'delete' : cannot delete objects that are not pointers
>> scons: *** [win64_build\plugins\win64_build\mediafoundation
>> \soundsourcemediafoundation.obj] Error 2
>> scons: building terminated because of errors.
>>
>> Build step 'Execute Windows batch command' marked build as failure
>> Recording test results
>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
>> were found but none of them are new. Did tests run?
>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
>> \windows\test_results.xml is 14 days old
>>
>> SSH: Current build result is [FAILURE], not going to run.
>>
>> Finished: FAILURE
>>
>>
>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
>>> NULL),
>>>
>>> You're missing a closing parenthesis
>>>
>>> —
>>> Reply to this email directly or view it on GitHub.
>>>
>>>
>>
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot 

Still failing:

cl : Ligne de commande warning D9002 : option '/arch:SSE2' inconnue ignorée
audiotagger.cpp
d:\mixxx-buildserver64\include\taglib\trefcounter.h(36) : warning C4005: 
'NOMINMAX' : redéfinition de macro
 arguments de ligne de commande : voir la définition précédente 
de 'NOMINMAX'
src\audiotagger.cpp(25) : error C4430: spécificateur de type manquant - 
int est
pris en compte par défaut. Remarque : C++ ne prend pas en charge int par 
défaut
scons: *** [win64_build\audiotagger.obj] Error 2
scons: building terminated because of errors.



Le 15/10/2015 22:16, Daniel Schürmann a écrit :
> New version is up:
> https://github.com/mixxxdj/mixxx/commit/316e7e9900e03a7c331db6ebdf03d5c16c323651
>
> Am 15.10.2015 um 22:00 schrieb Owen Williams:
>> Still failing:
>>
>>
>> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
>> soundsourcemediafoundation.cpp
>>
>> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
>> warning C4005: 'NOMINMAX' : macro redefinition
>>   command-line arguments :  see previous definition of 'NOMINMAX'
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
>> error C2614: 'SoundSourceMediaFoundation' : illegal member
>> initialization: 'm_wcFilename' is not a base or member
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
>> error C2065: 'm_wcFilename' : undeclared identifier
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>> error C2065: 'm_wcFilename' : undeclared identifier
>>
>> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
>> error C2541: 'delete' : cannot delete objects that are not pointers
>> scons: *** [win64_build\plugins\win64_build\mediafoundation
>> \soundsourcemediafoundation.obj] Error 2
>> scons: building terminated because of errors.
>>
>> Build step 'Execute Windows batch command' marked build as failure
>> Recording test results
>> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
>> were found but none of them are new. Did tests run?
>> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
>> \windows\test_results.xml is 14 days old
>>
>> SSH: Current build result is [FAILURE], not going to run.
>>
>> Finished: FAILURE
>>
>>
>> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
>>> NULL),
>>>
>>> You're missing a closing parenthesis
>>>
>>> —
>>> Reply to this email directly or view it on GitHub.
>>>
>>>
>>
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann 
New version is up:
https://github.com/mixxxdj/mixxx/commit/316e7e9900e03a7c331db6ebdf03d5c16c323651

Am 15.10.2015 um 22:00 schrieb Owen Williams:
> Still failing:
>
>
> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
> soundsourcemediafoundation.cpp
>
> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
> warning C4005: 'NOMINMAX' : macro redefinition
>  command-line arguments :  see previous definition of 'NOMINMAX'
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
> error C2614: 'SoundSourceMediaFoundation' : illegal member
> initialization: 'm_wcFilename' is not a base or member
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
> error C2065: 'm_wcFilename' : undeclared identifier
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2065: 'm_wcFilename' : undeclared identifier
>
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2541: 'delete' : cannot delete objects that are not pointers
> scons: *** [win64_build\plugins\win64_build\mediafoundation
> \soundsourcemediafoundation.obj] Error 2
> scons: building terminated because of errors.
>
> Build step 'Execute Windows batch command' marked build as failure
> Recording test results
> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
> were found but none of them are new. Did tests run?
> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
> \windows\test_results.xml is 14 days old
>
> SSH: Current build result is [FAILURE], not going to run.
>
> Finished: FAILURE
>
>
> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
>> NULL),
>>
>> You're missing a closing parenthesis
>>
>> —
>> Reply to this email directly or view it on GitHub.
>>
>>
>
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann 
Thank you.

I have fixed the issue and have a working STATIC_ASSERT
just build local, will commit next.


Am 15.10.2015 um 22:00 schrieb Owen Williams:
> Still failing:
>
>
> cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
> soundsourcemediafoundation.cpp
>
> c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
> warning C4005: 'NOMINMAX' : macro redefinition
>  command-line arguments :  see previous definition of 'NOMINMAX'
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
> error C2614: 'SoundSourceMediaFoundation' : illegal member
> initialization: 'm_wcFilename' is not a base or member
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
> error C2065: 'm_wcFilename' : undeclared identifier
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2065: 'm_wcFilename' : undeclared identifier
>
> plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
> error C2541: 'delete' : cannot delete objects that are not pointers
> scons: *** [win64_build\plugins\win64_build\mediafoundation
> \soundsourcemediafoundation.obj] Error 2
> scons: building terminated because of errors.
>
> Build step 'Execute Windows batch command' marked build as failure
> Recording test results
> ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
> were found but none of them are new. Did tests run?
> For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
> \windows\test_results.xml is 14 days old
>
> SSH: Current build result is [FAILURE], not going to run.
>
> Finished: FAILURE
>
>
> On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
>> NULL),
>>
>> You're missing a closing parenthesis
>>
>> —
>> Reply to this email directly or view it on GitHub.
>>
>>
>
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel


--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

[Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Owen Williams 
Still failing:


cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
soundsourcemediafoundation.cpp

c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) :
warning C4005: 'NOMINMAX' : macro redefinition
command-line arguments :  see previous definition of 'NOMINMAX'
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
error C2614: 'SoundSourceMediaFoundation' : illegal member
initialization: 'm_wcFilename' is not a base or member
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
error C2065: 'm_wcFilename' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
error C2065: 'm_wcFilename' : undeclared identifier

plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
error C2541: 'delete' : cannot delete objects that are not pointers
scons: *** [win64_build\plugins\win64_build\mediafoundation
\soundsourcemediafoundation.obj] Error 2
scons: building terminated because of errors.

Build step 'Execute Windows batch command' marked build as failure
Recording test results
ERROR: Publisher 'Publish JUnit test result report' failed: Test reports
were found but none of them are new. Did tests run? 
For example, c:\mixxx\workspace\1.12-release\architecture\amd64\platform
\windows\test_results.xml is 14 days old

SSH: Current build result is [FAILURE], not going to run.

Finished: FAILURE


On Thu, 2015-10-15 at 12:38 -0700, Sebastien BLAISOT wrote:
> NULL),
> 
> You're missing a closing parenthesis
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 



--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Sébastien Blaisot 
Le 15/10/2015 08:42, Daniel Schürmann a écrit :
> Unfortunately I have no access to the build server (network timeout)
> Since there are no recent windows builds builds on
> http://downloads.mixxx.org/builds/1.12/
> I assume there is still an issue. Can one forward me the failing build
> message?

from 
http://builds.mixxx.org:8081/jenkins/job/1.12-release/architecture=amd64,platform=windows/129/console

soundsourcemediafoundation.cpp
c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : 
warning C4005: 'NOMINMAX' : macro redefinition
  command-line arguments :  see previous definition of 'NOMINMAX'
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) : 
error C2614: 'SoundSourceMediaFoundation' : illegal member 
initialization: 'm_wcFilename' is not a base or member
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) : 
error C2065: 'm_wcFilename' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : 
error C2065: 'm_wcFilename' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) : 
error C2541: 'delete' : cannot delete objects that are not pointers
scons: *** 
[win64_build\plugins\win64_build\mediafoundation\soundsourcemediafoundation.obj]
 
Error 2
scons: building terminated because of errors.

-- 
Sébastien
圣巴斯弟盎



--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Owen Williams 
Windows build failure:
Ilib\fidlib-0.9.10 /IC:\usr\include\taglib /Ilib\hidapi-0.8.0-pre
\hidapi /Ilib\xwax /Ilib\scratchlib /Ilib\vamp-2.3
soundsourcemediafoundation.cpp
c:\mixxx\environments\2.0-x64-debug\include\taglib\trefcounter.h(36) :
warning C4005: 'NOMINMAX' : macro redefinition
command-line arguments :  see previous definition of 'NOMINMAX'
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(66) :
error C2614: 'SoundSourceMediaFoundation' : illegal member
initialization: 'm_wcFilename' is not a base or member
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(75) :
error C2065: 'm_wcFilename' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
error C2065: 'm_wcFilename' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(80) :
error C2541: 'delete' : cannot delete objects that are not pointers
scons: *** [win64_build\plugins\win64_build\mediafoundation
\soundsourcemediafoundation.obj] Error 2
scons: building terminated because of errors.
Build step 'Execute Windows batch command' marked build as failure

http://builds.mixxx.org:8081/jenkins/job/1.12-debug/architecture=amd64,platform=windows/15/console


On Thu, 2015-10-15 at 08:42 +0200, Daniel Schürmann wrote:
> My latest commit, trying to fix the wchat_t windows issue is on 1.12
> branch only. 
> 
> 
> I will merge the 1.12 to master once 1.12 builds on windows. 
> 
> Unfortunately I have no access to the build server (network timeout) 
> 
> Since there are no recent windows builds builds on
> http://downloads.mixxx.org/builds/1.12/
> 
> I assume there is still an issue. Can one forward me the failing build
> message? 
> 
> 
> There also a major Taglib issue pending. Version 1.10 will be released
> in a couple of days until then we can use Taglib head of master
> 
> Who is able to update Taglib to current master. Who is able to add
> Taglib 1.10 to the Mixxx ppa? 
> 
> What is to do for Mac? 
> 
> 
> Details: 
> https://github.com/taglib/taglib/issues/635
> 
>  
> 
> 
> 
> 
> 2015-10-15 7:48 GMT+02:00 Uwe Klotz :
> Daniel has already migrated his changes for Windows
> (UTF-16/wchar_t) from
> 1.12 to master separately. It should be safe if we just choose
> the
> SoundSource and TagLib files from master in case of conflicts.
> 
> On 10/15/2015 02:05 AM, Owen Williams wrote:
> > Can someone carefully do a merge from 1.12 into trunk?
> There are a
> > bunch of conflicts with the soundsource files.
> >
> > We have to be very careful making changes to soundsource
> files because
> > there has been so much divergence since the backend change.
> Until the
> > release we need to keep incorporating 1.12 bugfixes into
> master.
> >
> > (Speaking of the release, we're just waiting on the
> shoutcast fix and
> > then we'll do it.  It sounds like there's a freeze on
> shutdown we need
> > to fix, but otherwise it's mostly good)
> >
> >
> >
> 
> --
> > ___
> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > http://mixxx.org
> >
> >
> > Mixxx-devel mailing list
> > Mixxx-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> >
> 
> 
> 
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> 
> 
> 
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel



--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Owen Williams 
The build server was having network problems so I bought a new network
card.  I've started a new build, we'll see if it works.

On Thu, 2015-10-15 at 08:42 +0200, Daniel Schürmann wrote:
> My latest commit, trying to fix the wchat_t windows issue is on 1.12
> branch only. 
> 
> 
> I will merge the 1.12 to master once 1.12 builds on windows. 
> 
> Unfortunately I have no access to the build server (network timeout) 
> 
> Since there are no recent windows builds builds on
> http://downloads.mixxx.org/builds/1.12/
> 
> I assume there is still an issue. Can one forward me the failing build
> message? 
> 
> 
> There also a major Taglib issue pending. Version 1.10 will be released
> in a couple of days until then we can use Taglib head of master
> 
> Who is able to update Taglib to current master. Who is able to add
> Taglib 1.10 to the Mixxx ppa? 
> 
> What is to do for Mac? 
> 
> 
> Details: 
> https://github.com/taglib/taglib/issues/635
> 
>  
> 
> 
> 
> 
> 2015-10-15 7:48 GMT+02:00 Uwe Klotz :
> Daniel has already migrated his changes for Windows
> (UTF-16/wchar_t) from
> 1.12 to master separately. It should be safe if we just choose
> the
> SoundSource and TagLib files from master in case of conflicts.
> 
> On 10/15/2015 02:05 AM, Owen Williams wrote:
> > Can someone carefully do a merge from 1.12 into trunk?
> There are a
> > bunch of conflicts with the soundsource files.
> >
> > We have to be very careful making changes to soundsource
> files because
> > there has been so much divergence since the backend change.
> Until the
> > release we need to keep incorporating 1.12 bugfixes into
> master.
> >
> > (Speaking of the release, we're just waiting on the
> shoutcast fix and
> > then we'll do it.  It sounds like there's a freeze on
> shutdown we need
> > to fix, but otherwise it's mostly good)
> >
> >
> >
> 
> --
> > ___
> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > http://mixxx.org
> >
> >
> > Mixxx-devel mailing list
> > Mixxx-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> >
> 
> 
> 
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> 
> 
> 
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel



--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Accessing TrackModel

2015-10-15 Thread Trevor Hansen 
+1 for this idea as well.

On Thu, Oct 15, 2015 at 1:09 AM, Daniel Schürmann 
wrote:

> Hi JAmes,
>
> Thank you for contributing to Mixxx.
>
> I am not 100 % clear what how the final feature will look like.
>
> Is it similar to https://bugs.launchpad.net/mixxx/+bug/1505408 ?
>
> If yes, you may describe your feature there and assign the bug to
> yourselves.
> If not file a new one.
>
> The duration for playlists is shown here:
>
> https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/library/playlistfeature.cpp#L168
> and calculated here:
>
> https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/library/playlistfeature.cpp#L133
>
> This link might be help in general:
> http://www.mixxx.org/wiki/doku.php/bugfix_workflow
>
> If you need help on your code, just issue a normal GitHub pull request and
> ask your questions there.
>
> Hope that helps.
>
> Kind regards,
>
> Daniel
>
>
>
>
>
> 2015-10-15 8:10 GMT+02:00 JAmes Atwill :
>
>> Hi,
>>
>> I've been wanting a feature in AutoDJ where the total duration of the
>> selected tracks would be visible somewhere so I can estimate how much
>> of a set I've put together. I thought this would be a decent way to
>> dive into C++, Qt and associated tooling.
>>
>> I've connected the trackSelected signal to a slot in DlgAutoDJ.
>>
>> My method grabs the selectedRows of the m_pTrackTableView and I want
>> to call getTrackModel()->getTrack(...) except that getTrackModel is
>> private which makes me believe I've likely come about this the wrong
>> way.
>>
>> To play around, I made it public and I'm able to sum the total
>> duration ( pTrack->getDuration ) and print in a qDebug statement.
>> (I've added a QLabel to dlgautodj.ui where the result will ultimately
>> go.)
>>
>> I appreciate an actual C++ developer could do this in five minutes,
>> but there are handful of other tiny things I'd love to make Mixxx do
>> and figured this would be a good way to cut my teeth.
>>
>> What's the best way to get the trackmodel, or am I coming about this
>> wrong way?
>>
>> Thanks!
>>
>>   JAmes
>>
>>
>> --
>> ___
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>
>
>
> --
>
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>



-- 

Trevor Hansen
Opus Productions
www.djopus.com
801.866.5122
--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Thorsten Munsch 
Hi all,

I've done a lot of sessions with the current 1.12 branch. Just want to 
mention that the stability is impressive. I haven't found any bugs yet. :)

If I can help with testing for the further 1.12 release, let me know.

On the weekend I will watch for some (easy) bugs to solve.


Am 15.10.2015 um 08:42 schrieb Daniel Schürmann:
> My latest commit, trying to fix the wchat_t windows issue is on 1.12
> branch only.
>
> I will merge the 1.12 to master once 1.12 builds on windows.
>
> Unfortunately I have no access to the build server (network timeout)
> Since there are no recent windows builds builds on
> http://downloads.mixxx.org/builds/1.12/
> I assume there is still an issue. Can one forward me the failing build
> message?
>
> There also a major Taglib issue pending. Version 1.10 will be released
> in a couple of days until then we can use Taglib head of master
> Who is able to update Taglib to current master. Who is able to add
> Taglib 1.10 to the Mixxx ppa?
> What is to do for Mac?
>
> Details:
> https://github.com/taglib/taglib/issues/635
>
>
>
> 2015-10-15 7:48 GMT+02:00 Uwe Klotz  >:
>
> Daniel has already migrated his changes for Windows (UTF-16/wchar_t)
> from
> 1.12 to master separately. It should be safe if we just choose the
> SoundSource and TagLib files from master in case of conflicts.
>
> On 10/15/2015 02:05 AM, Owen Williams wrote:
>  > Can someone carefully do a merge from 1.12 into trunk?  There are a
>  > bunch of conflicts with the soundsource files.
>  >
>  > We have to be very careful making changes to soundsource files
> because
>  > there has been so much divergence since the backend change.
> Until the
>  > release we need to keep incorporating 1.12 bugfixes into master.
>  >
>  > (Speaking of the release, we're just waiting on the shoutcast fix and
>  > then we'll do it.  It sounds like there's a freeze on shutdown we
> need
>  > to fix, but otherwise it's mostly good)
>  >
>  >
>  >
> 
> --
>  > ___
>  > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>  > http://mixxx.org
>  >
>  >
>  > Mixxx-devel mailing list
>  > Mixxx-devel@lists.sourceforge.net
> 
>  > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>  >
>
>
> 
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> 
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
>
> --
>
>
>
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>

--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Accessing TrackModel

2015-10-15 Thread Daniel Schürmann 
Hi JAmes,

Thank you for contributing to Mixxx.

I am not 100 % clear what how the final feature will look like.

Is it similar to https://bugs.launchpad.net/mixxx/+bug/1505408 ?

If yes, you may describe your feature there and assign the bug to
yourselves.
If not file a new one.

The duration for playlists is shown here:
https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/library/playlistfeature.cpp#L168
and calculated here:
https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/library/playlistfeature.cpp#L133

This link might be help in general:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

If you need help on your code, just issue a normal GitHub pull request and
ask your questions there.

Hope that helps.

Kind regards,

Daniel





2015-10-15 8:10 GMT+02:00 JAmes Atwill :

> Hi,
>
> I've been wanting a feature in AutoDJ where the total duration of the
> selected tracks would be visible somewhere so I can estimate how much
> of a set I've put together. I thought this would be a decent way to
> dive into C++, Qt and associated tooling.
>
> I've connected the trackSelected signal to a slot in DlgAutoDJ.
>
> My method grabs the selectedRows of the m_pTrackTableView and I want
> to call getTrackModel()->getTrack(...) except that getTrackModel is
> private which makes me believe I've likely come about this the wrong
> way.
>
> To play around, I made it public and I'm able to sum the total
> duration ( pTrack->getDuration ) and print in a qDebug statement.
> (I've added a QLabel to dlgautodj.ui where the result will ultimately
> go.)
>
> I appreciate an actual C++ developer could do this in five minutes,
> but there are handful of other tiny things I'd love to make Mixxx do
> and figured this would be a good way to cut my teeth.
>
> What's the best way to get the trackmodel, or am I coming about this wrong
> way?
>
> Thanks!
>
>   JAmes
>
>
> --
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel