Re: [mkgmap-dev] Dead end check
Hi Mike,
I don't know if there is an established tag in OSM to say "this is not a dead
end". (1)
The current code checks if the end node has a fixme=* or FIXME=* tag. If found,
the dead-end-check is disabled for that way. I did not try it but I think you
can use a rule in nodes to set fixme. Your example way has
railway=car_shuttle, so maybe this rule will help for your case:
railway=car_shuttle {add fixme=1}
(1) I suggest to discuss this in the tagging list.
http://gis.19327.n8.nabble.com/Tagging-f5258744.html
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Dienstag, 18. Februar 2020 18:30
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Dead end check
HI Gerd,
I am not getting too many positives - I am trying to differentiate those
which are real OSM errors from those which are because the software isn't
clever enough or doesn't have enough information. So what is needed for this
situation is to tag a way to indicate that it is a known dead end. Setting
mkgmap:dead-end-check=false on the way does pretty much that, albeit only
for mkgmap, and only if the mkgmap:dead-end-check information is loaded from
OSM.
I also have nodes that have amenity=parking_entrance at the end of one-way
roads. Is there a way to get a tag on a node to set mkgmap:dead-end-check on
the way it belongs to?
Cheers,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 18 February 2020 17:02
To: Mike Baggaley ; 'Development list for mkgmap'
Subject: AW: [mkgmap-dev] Dead end check
Hi Mike,
if you get too many false positives with the dead-end check you may add
mkgmap:dead-end-check=false for all highway=service.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Dienstag, 18. Februar 2020 17:46
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Dead end check
Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some
of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one
I added as all the surrounding ways had it set already with just that one
not having it. The change log for the other ways shows the tag was added by
tms13 in 2015. This information cannot be added in the style with the
existing OSM data unless you specify something like id=108322149 {set
mkgmap:dead-end-check=false}, which is not an ideal solution. If you can
suggest what should go in OSM to indicate it is a known dead end so that it
can be detected by the style then that would be great.
Regards,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 17 February 2020 20:04
To: Development list for mkgmap
Subject: Re: [mkgmap-dev] Dead end check
Hi Mike,
Ticker is right. Please don't add mkgmap special tags to the OSM database.
Those tags should be used in the style.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Montag, 17. Februar 2020 20:17
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] Dead end check
Hi all,
I have set logging to enable warnings in StyledConverter, and have been
getting a few unexpected results from the dead end check. It seems that
using the default style and latest mkgmap release, if a way has
mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when
the dead end check is run, ways with this tag are not omitted from the
check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end-check in
the list of standard tags to be loaded, without needing anything specific in
the style (or at least if dead end check is enabled). I would not expect OSM
to have many of these, so it should not make any significant difference to
the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the
train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check,
mkgmap:dir-check and mkgmap:no-dir-check.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Dead end check
HI Gerd,
I am not getting too many positives - I am trying to differentiate those
which are real OSM errors from those which are because the software isn't
clever enough or doesn't have enough information. So what is needed for this
situation is to tag a way to indicate that it is a known dead end. Setting
mkgmap:dead-end-check=false on the way does pretty much that, albeit only
for mkgmap, and only if the mkgmap:dead-end-check information is loaded from
OSM.
I also have nodes that have amenity=parking_entrance at the end of one-way
roads. Is there a way to get a tag on a node to set mkgmap:dead-end-check on
the way it belongs to?
Cheers,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 18 February 2020 17:02
To: Mike Baggaley ; 'Development list for mkgmap'
Subject: AW: [mkgmap-dev] Dead end check
Hi Mike,
if you get too many false positives with the dead-end check you may add
mkgmap:dead-end-check=false for all highway=service.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Dienstag, 18. Februar 2020 17:46
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Dead end check
Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some
of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one
I added as all the surrounding ways had it set already with just that one
not having it. The change log for the other ways shows the tag was added by
tms13 in 2015. This information cannot be added in the style with the
existing OSM data unless you specify something like id=108322149 {set
mkgmap:dead-end-check=false}, which is not an ideal solution. If you can
suggest what should go in OSM to indicate it is a known dead end so that it
can be detected by the style then that would be great.
Regards,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 17 February 2020 20:04
To: Development list for mkgmap
Subject: Re: [mkgmap-dev] Dead end check
Hi Mike,
Ticker is right. Please don't add mkgmap special tags to the OSM database.
Those tags should be used in the style.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Montag, 17. Februar 2020 20:17
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] Dead end check
Hi all,
I have set logging to enable warnings in StyledConverter, and have been
getting a few unexpected results from the dead end check. It seems that
using the default style and latest mkgmap release, if a way has
mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when
the dead end check is run, ways with this tag are not omitted from the
check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end-check in
the list of standard tags to be loaded, without needing anything specific in
the style (or at least if dead end check is enabled). I would not expect OSM
to have many of these, so it should not make any significant difference to
the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the
train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check,
mkgmap:dir-check and mkgmap:no-dir-check.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Dead end check
Hi Mike,
if you get too many false positives with the dead-end check you may add
mkgmap:dead-end-check=false for all highway=service.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Dienstag, 18. Februar 2020 17:46
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Dead end check
Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some
of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one
I added as all the surrounding ways had it set already with just that one
not having it. The change log for the other ways shows the tag was added by
tms13 in 2015. This information cannot be added in the style with the
existing OSM data unless you specify something like id=108322149 {set
mkgmap:dead-end-check=false}, which is not an ideal solution. If you can
suggest what should go in OSM to indicate it is a known dead end so that it
can be detected by the style then that would be great.
Regards,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 17 February 2020 20:04
To: Development list for mkgmap
Subject: Re: [mkgmap-dev] Dead end check
Hi Mike,
Ticker is right. Please don't add mkgmap special tags to the OSM database.
Those tags should be used in the style.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Montag, 17. Februar 2020 20:17
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] Dead end check
Hi all,
I have set logging to enable warnings in StyledConverter, and have been
getting a few unexpected results from the dead end check. It seems that
using the default style and latest mkgmap release, if a way has
mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when
the dead end check is run, ways with this tag are not omitted from the
check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end-check in
the list of standard tags to be loaded, without needing anything specific in
the style (or at least if dead end check is enabled). I would not expect OSM
to have many of these, so it should not make any significant difference to
the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the
train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check,
mkgmap:dir-check and mkgmap:no-dir-check.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Dead end check
Hi Gerd, there are a number of mkgmap special tags in the OSM database. Some
of them are rather dubious (e.g. there are 4 mkgmap:area2poi tags). This one
I added as all the surrounding ways had it set already with just that one
not having it. The change log for the other ways shows the tag was added by
tms13 in 2015. This information cannot be added in the style with the
existing OSM data unless you specify something like id=108322149 {set
mkgmap:dead-end-check=false}, which is not an ideal solution. If you can
suggest what should go in OSM to indicate it is a known dead end so that it
can be detected by the style then that would be great.
Regards,
Mike
-Original Message-
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com]
Sent: 17 February 2020 20:04
To: Development list for mkgmap
Subject: Re: [mkgmap-dev] Dead end check
Hi Mike,
Ticker is right. Please don't add mkgmap special tags to the OSM database.
Those tags should be used in the style.
Gerd
Von: mkgmap-dev im Auftrag von Mike
Baggaley
Gesendet: Montag, 17. Februar 2020 20:17
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] Dead end check
Hi all,
I have set logging to enable warnings in StyledConverter, and have been
getting a few unexpected results from the dead end check. It seems that
using the default style and latest mkgmap release, if a way has
mkgmap:dead-end-check=no set in OSM, this information is not loaded, so when
the dead end check is run, ways with this tag are not omitted from the
check. I have worked around this by adding a dummy line to the lines file:
mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
The tag data is then loaded.
It seems to me though that the code should include mkgmap:dead-end-check in
the list of standard tags to be loaded, without needing anything specific in
the style (or at least if dead end check is enabled). I would not expect OSM
to have many of these, so it should not make any significant difference to
the amount of memory needed by mkgmap or affect the execution time.
An example is way 108322149 which is one of the ways where cars get on the
train at Ashford.
I suspect the same thing will happen with mkgmap:flare-check,
mkgmap:dir-check and mkgmap:no-dir-check.
Regards,
Mike
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Dead end check
Thanks Ticker. Hadn't noticed that facility in the style manual - there's no
mention of the command line option in the help.
Regards,
Mike
-Original Message-
From: Ticker Berkin [mailto:rwb-mkg...@jagit.co.uk]
Sent: 17 February 2020 19:52
To: Development list for mkgmap
Subject: Re: [mkgmap-dev] Dead end check
Hi
It is standard mkgmap behaviour to not load OSM tags that it doesn't
see the need for. It detects tags referenced in the style and has a
list of other tags known to be processed by the java code
(resources/styles/builtin-tag-list).
Add extra ones to your style options file:
...
extra-used-tags=mkgmap:dead-end-check,etc,etc
or equiv command line option.
Ticker
On Mon, 2020-02-17 at 19:17 +, Mike Baggaley wrote:
> Hi all,
>
> I have set logging to enable warnings in StyledConverter, and have
> been
> getting a few unexpected results from the dead end check. It seems
> that
> using the default style and latest mkgmap release, if a way has
> mkgmap:dead-end-check=no set in OSM, this information is not loaded,
> so when
> the dead end check is run, ways with this tag are not omitted from
> the
> check. I have worked around this by adding a dummy line to the lines
> file:
>
> mkgmap:dead-end-check=no {set mkgmap:dead-end-check=no}
>
> The tag data is then loaded.
>
> It seems to me though that the code should include mkgmap:dead-end
> -check in
> the list of standard tags to be loaded, without needing anything
> specific in
> the style (or at least if dead end check is enabled). I would not
> expect OSM
> to have many of these, so it should not make any significant
> difference to
> the amount of memory needed by mkgmap or affect the execution time.
>
> An example is way 108322149 which is one of the ways where cars get
> on the
> train at Ashford.
>
> I suspect the same thing will happen with mkgmap:flare-check,
> mkgmap:dir-check and mkgmap:no-dir-check.
>
> Regards,
> Mike
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] Work on is_in branch
Hi Gerd Part of the reason for the methods is to group the IN/ON/OUT cases together in various combinations for meaningful usability. In IsInUtilTest.java is the table (for the sake of brevity, using 'camel' notation rather than underscores as in the actual method keyword): /* all=someInNoneOut, any=anyIn, none=someOutNoneIn a) INall allInOrOnany b) IN ON all allInOrOnany c) IN ON OUT any d)ON allInOrOn on e)ON OUT none f) OUT none */ So the difference between ..,all)=true and ..,none)=false is what happens to cases c) and d). The methods "any", "on" and "allInOrOn" include these cases. Obvious and sensible for the meaning of "any" and "on", "allInOrOn" is a bit arbritary, but the idea is that a perimeter line can be picked up along with the inside lines in one test if that is what is wanted. I didn't think there was a need to pick up a perimeter line with the outside lines, but this could be added easily. Ticker On Tue, 2020-02-18 at 00:28 -0700, Gerd Petermann wrote: > Gerd Petermann wrote > > Ticker Berkin wrote > > > I suggest replacing ANY_IN_OR_ON with SOME_OUT_NONE_IN, giving it > > > the > > > method string "none", like SOME_IN_NONE_OUT is referenced as > > > "all". > > > > Yes, much better. > > Thinking again about it. What would be the difference between > is_in(..all)=true and is_in(..none)=false? > > My understanding is that we want to distinguish 5 or 6 cases. Three > methods > returning true or false should be enough for that. > > Gerd > > > > -- > Sent from: > http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html > ___ > mkgmap-dev mailing list > mkgmap-dev@lists.mkgmap.org.uk > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
