Re: [mkgmap-dev] [PATCH v1] - All ways may contain nodes
On Mon, Jul 27, 2009 at 4:25 PM, Mark Burton wrote: > As for the short arc errors going away, it must be more of those wacky > routable railway platforms! Yeah, I changed my style file to exclude railway platforms which are areas. I know I shouldn't change two things at once when I test something, but that's just the way I roll. ;-) Cheers. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] - All ways may contain nodes
Hi Clinton, > I did a quick test of this patch: I could not observe any breakage. In > addition, a number of short arc errors (in ways I didn't care about), > which had cropped up in recent builds, disappeared. > > So this looks good. OK - thanks for the report - sounds good. As for the short arc errors going away, it must be more of those wacky routable railway platforms! Cheers, Mark ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] [PATCH v1] - All ways may contain nodes
On Mon, Jul 27, 2009 at 1:34 PM, Mark Burton wrote: > I would be grateful if as many people as possible test this and > report any breakage as it could have an effect on any map (although, I > believe it safe enough). I did a quick test of this patch: I could not observe any breakage. In addition, a number of short arc errors (in ways I didn't care about), which had cropped up in recent builds, disappeared. So this looks good. Cheers. ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] [PATCH v1] - All ways may contain nodes
This patch should cure the problem where something that isn't a highway
or a ferry route is mutated into a routable way by the style file and,
subsequently, due to its shape/size/topology/etc introduces a short
arc.
I would be grateful if as many people as possible test this and
report any breakage as it could have an effect on any map (although, I
believe it safe enough).
Cheers,
Mark
diff --git a/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java b/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java
index ff804ad..e350483 100644
--- a/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java
+++ b/src/uk/me/parabola/mkgmap/reader/osm/xml/Osm5XmlHandler.java
@@ -284,11 +284,6 @@ class Osm5XmlHandler extends DefaultHandler {
String highway = currentWay.getTag("highway");
if(highway != null ||
"ferry".equals(currentWay.getTag("route"))) {
- // the way is a highway (or ferry route), so for
- // each of it's points, increment the number of
- // highways using that point
- for(Coord p : currentWay.getPoints())
- p.incHighwayCount();
// if the way is a roundabout but isn't already
// flagged as "oneway", flag it here
if("roundabout".equals(currentWay.getTag("junction"))) {
@@ -711,6 +706,7 @@ class Osm5XmlHandler extends DefaultHandler {
}
}
currentWay.addPoint(co);
+ co.incHighwayCount(); // nodes (way joins) will have highwayCount > 1
if(minimumArcLength != null)
nodeIdMap.put(co, id);
}
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
