Re: [mkgmap-dev] found multiple points with equal coord.....
Hi Gerd
I think it should just deal with the (probably) common, significant
case and assume the restriction is needed.
The short distance is, nominally, from the centre-line to the side of
the non-barriered highway. In the examples I've seen this more than
highPrecEqual but less than 2m (apart from the errors where mappers
have put a stile on the junction, forcing car-routing to avoid the
area!)
Ticker
On Tue, 2021-05-04 at 08:16 +, Gerd Petermann wrote:
> Hi Ticker,
>
> thanks for the info. I didn't see such messages in GpsMapEdit before,
> only for turn-restrictions with multiple via nodes.
> The only special case here is that the barrier node "highPrecEquals"
> the last node.
>
> A general question would be if mkgmap should detect that a
> restriction shoud better be ignored when it only restricts access to
> the last 5 meters or so.
> I didn't try it but I guess it could lead to routing problems if your
> start is at the end of the road.
>
> Gerd
>
>
> Von: mkgmap-dev im Auftrag
> von Ticker Berkin
> Gesendet: Dienstag, 4. Mai 2021 10:06
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] found multiple points with equal coord.
>
> Hi Gerd & others
>
> This is a quite common physical set-up; a highway with another, more
> minor, highway/track/path leading off it with a "barrier" at the
> junction, inhibiting access to the minor highway.
>
> Often the only clear access restrictions visible on-the-ground are on
> the barrier, so these are what get represented in OSM. A minimal
> distance between the barrier and the major highway is needed to map
> this on OSM.
>
> mkgmap should handle this situation correctly. I haven't tried to
> understand why it didn't before, but if the patch fixes it then it
> should be applied.
>
> I've seen other examples of GPSMapEdit flagging errors like this:
>
> WARNING: Unexpected format of input data. Unexpected NodeID=936272 in
> turn restriction at (51.013083,-1.389384). The restriction will be
> ignored
>
> where there are very short section between the restriction and the
> junction node and I think it is just a GPSMapEdit problem.
>
> Ticker
>
>
> On Sun, 2021-05-02 at 08:46 +, Gerd Petermann wrote:
> > Hi all,
> >
> > the message
> > "Found multiple points with equal coords as CoordPOI at
> > http://www.openstreetmap.org/?mlat=56.835675=37.404949=17
> > "
> > is produced because the nodes
> > https://www.osm.org/node/2924385337
> > https://www.osm.org/node/2924351922
> > are so close together that mkgmap could not distinguish the
> > position.
> > No idea why someone maps a lift-gate less that close to the end of
> > the road, but of course mkgmap should not fail with this.
> >
> > The problem doesn't show up with the default style unless I add
> > this
> > line in points rules:
> > barrier=*{ addaccess no;}
> > after
> > barrier=* & access=* {addaccess '${access|subst:private=>no}'}
> > Without this change the default style doesn't create a route
> > restriction for the barrier node
> > https://www.openstreetmap.org/node/2924385337
> >
> > I've created a patch to fix this problem for good by adding a
> > hashmap but GpsMapEdit doesn't like the result:
> > Unexpected format of input data. Unexpected NodeID=136381 in turn
> > restriction at (56.835666 37.404950). The restriction will be
> > ignored.
> >
> > The old code didn't add the restriction, the new code does.
> > Now I am unsure if the "corrected" code causes more trouble than
> > the
> > old. Maybe I should somehow detect the special case that a barrier
> > is very close to an end of a way which is not connected to other
> > ways? If I change the input data so that the end is a bit more away
> > GpsMapEdit doesn't complain. Is it just a problem in GpsMapEdit?
> >
> > Gerd
> >
> >
> > Von: mkgmap-dev im Auftrag
> > von Thomas Morgenstern
> > Gesendet: Samstag, 1. Mai 2021 08:56
> > An: Development list for mkgmap
> > Betreff: [mkgmap-dev] found multiple points with equal coord.
> >
> > Hi ,
> > yesterday mkgmap r4587 gives me following message : 'found multiple
> > points with equal coord as CoordPOI at 56.835467 37.404949...
> > The map seems okay. What shell I do with this message ?. Is this
> > meassage only a hint for incorrect data ? Or what else ?
> >
> > thomas
> >
> > ___
> > mkgmap
Re: [mkgmap-dev] found multiple points with equal coord.....
Hi Ticker,
thanks for the info. I didn't see such messages in GpsMapEdit before, only for
turn-restrictions with multiple via nodes.
The only special case here is that the barrier node "highPrecEquals" the last
node.
A general question would be if mkgmap should detect that a restriction shoud
better be ignored when it only restricts access to the last 5 meters or so.
I didn't try it but I guess it could lead to routing problems if your start is
at the end of the road.
Gerd
Von: mkgmap-dev im Auftrag von Ticker
Berkin
Gesendet: Dienstag, 4. Mai 2021 10:06
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] found multiple points with equal coord.
Hi Gerd & others
This is a quite common physical set-up; a highway with another, more
minor, highway/track/path leading off it with a "barrier" at the
junction, inhibiting access to the minor highway.
Often the only clear access restrictions visible on-the-ground are on
the barrier, so these are what get represented in OSM. A minimal
distance between the barrier and the major highway is needed to map
this on OSM.
mkgmap should handle this situation correctly. I haven't tried to
understand why it didn't before, but if the patch fixes it then it
should be applied.
I've seen other examples of GPSMapEdit flagging errors like this:
WARNING: Unexpected format of input data. Unexpected NodeID=936272 in
turn restriction at (51.013083,-1.389384). The restriction will be
ignored
where there are very short section between the restriction and the
junction node and I think it is just a GPSMapEdit problem.
Ticker
On Sun, 2021-05-02 at 08:46 +, Gerd Petermann wrote:
> Hi all,
>
> the message
> "Found multiple points with equal coords as CoordPOI at
> http://www.openstreetmap.org/?mlat=56.835675=37.404949=17;
> is produced because the nodes
> https://www.osm.org/node/2924385337
> https://www.osm.org/node/2924351922
> are so close together that mkgmap could not distinguish the position.
> No idea why someone maps a lift-gate less that close to the end of
> the road, but of course mkgmap should not fail with this.
>
> The problem doesn't show up with the default style unless I add this
> line in points rules:
> barrier=*{ addaccess no;}
> after
> barrier=* & access=* {addaccess '${access|subst:private=>no}'}
> Without this change the default style doesn't create a route
> restriction for the barrier node
> https://www.openstreetmap.org/node/2924385337
>
> I've created a patch to fix this problem for good by adding a
> hashmap but GpsMapEdit doesn't like the result:
> Unexpected format of input data. Unexpected NodeID=136381 in turn
> restriction at (56.835666 37.404950). The restriction will be
> ignored.
>
> The old code didn't add the restriction, the new code does.
> Now I am unsure if the "corrected" code causes more trouble than the
> old. Maybe I should somehow detect the special case that a barrier
> is very close to an end of a way which is not connected to other
> ways? If I change the input data so that the end is a bit more away
> GpsMapEdit doesn't complain. Is it just a problem in GpsMapEdit?
>
> Gerd
>
> ____________
> Von: mkgmap-dev im Auftrag
> von Thomas Morgenstern
> Gesendet: Samstag, 1. Mai 2021 08:56
> An: Development list for mkgmap
> Betreff: [mkgmap-dev] found multiple points with equal coord.
>
> Hi ,
> yesterday mkgmap r4587 gives me following message : 'found multiple
> points with equal coord as CoordPOI at 56.835467 37.404949...
> The map seems okay. What shell I do with this message ?. Is this
> meassage only a hint for incorrect data ? Or what else ?
>
> thomas
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] found multiple points with equal coord.....
Hi Gerd & others
This is a quite common physical set-up; a highway with another, more
minor, highway/track/path leading off it with a "barrier" at the
junction, inhibiting access to the minor highway.
Often the only clear access restrictions visible on-the-ground are on
the barrier, so these are what get represented in OSM. A minimal
distance between the barrier and the major highway is needed to map
this on OSM.
mkgmap should handle this situation correctly. I haven't tried to
understand why it didn't before, but if the patch fixes it then it
should be applied.
I've seen other examples of GPSMapEdit flagging errors like this:
WARNING: Unexpected format of input data. Unexpected NodeID=936272 in
turn restriction at (51.013083,-1.389384). The restriction will be
ignored
where there are very short section between the restriction and the
junction node and I think it is just a GPSMapEdit problem.
Ticker
On Sun, 2021-05-02 at 08:46 +, Gerd Petermann wrote:
> Hi all,
>
> the message
> "Found multiple points with equal coords as CoordPOI at
> http://www.openstreetmap.org/?mlat=56.835675=37.404949=17;
> is produced because the nodes
> https://www.osm.org/node/2924385337
> https://www.osm.org/node/2924351922
> are so close together that mkgmap could not distinguish the position.
> No idea why someone maps a lift-gate less that close to the end of
> the road, but of course mkgmap should not fail with this.
>
> The problem doesn't show up with the default style unless I add this
> line in points rules:
> barrier=*{ addaccess no;}
> after
> barrier=* & access=* {addaccess '${access|subst:private=>no}'}
> Without this change the default style doesn't create a route
> restriction for the barrier node
> https://www.openstreetmap.org/node/2924385337
>
> I've created a patch to fix this problem for good by adding a
> hashmap but GpsMapEdit doesn't like the result:
> Unexpected format of input data. Unexpected NodeID=136381 in turn
> restriction at (56.835666 37.404950). The restriction will be
> ignored.
>
> The old code didn't add the restriction, the new code does.
> Now I am unsure if the "corrected" code causes more trouble than the
> old. Maybe I should somehow detect the special case that a barrier
> is very close to an end of a way which is not connected to other
> ways? If I change the input data so that the end is a bit more away
> GpsMapEdit doesn't complain. Is it just a problem in GpsMapEdit?
>
> Gerd
>
> ____
> Von: mkgmap-dev im Auftrag
> von Thomas Morgenstern
> Gesendet: Samstag, 1. Mai 2021 08:56
> An: Development list for mkgmap
> Betreff: [mkgmap-dev] found multiple points with equal coord.
>
> Hi ,
> yesterday mkgmap r4587 gives me following message : 'found multiple
> points with equal coord as CoordPOI at 56.835467 37.404949...
> The map seems okay. What shell I do with this message ?. Is this
> meassage only a hint for incorrect data ? Or what else ?
>
> thomas
>
> ___
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] found multiple points with equal coord.....
Hi all,
the message
"Found multiple points with equal coords as CoordPOI at
http://www.openstreetmap.org/?mlat=56.835675=37.404949=17;
is produced because the nodes
https://www.osm.org/node/2924385337
https://www.osm.org/node/2924351922
are so close together that mkgmap could not distinguish the position. No idea
why someone maps a lift-gate less that close to the end of the road, but of
course mkgmap should not fail with this.
The problem doesn't show up with the default style unless I add this line in
points rules:
barrier=*{ addaccess no;}
after
barrier=* & access=* {addaccess '${access|subst:private=>no}'}
Without this change the default style doesn't create a route restriction for
the barrier node https://www.openstreetmap.org/node/2924385337
I've created a patch to fix this problem for good by adding a hashmap but
GpsMapEdit doesn't like the result:
Unexpected format of input data. Unexpected NodeID=136381 in turn restriction
at (56.835666 37.404950). The restriction will be ignored.
The old code didn't add the restriction, the new code does.
Now I am unsure if the "corrected" code causes more trouble than the old. Maybe
I should somehow detect the special case that a barrier
is very close to an end of a way which is not connected to other ways? If I
change the input data so that the end is a bit more away GpsMapEdit doesn't
complain. Is it just a problem in GpsMapEdit?
Gerd
Von: mkgmap-dev im Auftrag von Thomas
Morgenstern
Gesendet: Samstag, 1. Mai 2021 08:56
An: Development list for mkgmap
Betreff: [mkgmap-dev] found multiple points with equal coord.
Hi ,
yesterday mkgmap r4587 gives me following message : 'found multiple points with
equal coord as CoordPOI at 56.835467 37.404949...
The map seems okay. What shell I do with this message ?. Is this meassage only
a hint for incorrect data ? Or what else ?
thomas
linkPOI.patch
Description: linkPOI.patch
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] found multiple points with equal coord.....
Hi Thomas, please try also if current version (r4680) shows the same message. Gerd Von: mkgmap-dev im Auftrag von Thomas Morgenstern Gesendet: Samstag, 1. Mai 2021 08:56 An: Development list for mkgmap Betreff: [mkgmap-dev] found multiple points with equal coord. Hi , yesterday mkgmap r4587 gives me following message : 'found multiple points with equal coord as CoordPOI at 56.835467 37.404949... The map seems okay. What shell I do with this message ?. Is this meassage only a hint for incorrect data ? Or what else ? thomas ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Re: [mkgmap-dev] found multiple points with equal coord.....
Hi Thomas, yes, it is a hint for wrong OSM data, but may also just be caused by the lower precision used in mkgmap. When I see that message I use JOSM, load the file for which the messages was created and check the given area. Typically there are two barrier=* or highway=* nodes at the same place, which is an OSM data error. Next step would be to check if the error still exists in the OSM database. In the current data I see no such problem around 56.835467 37.404949. Maybe it was already fixed. If this didn't help please upload the corresponding input file to https://files.mkgmap.org.uk/ Gerd Von: mkgmap-dev im Auftrag von Thomas Morgenstern Gesendet: Samstag, 1. Mai 2021 08:56 An: Development list for mkgmap Betreff: [mkgmap-dev] found multiple points with equal coord. Hi , yesterday mkgmap r4587 gives me following message : 'found multiple points with equal coord as CoordPOI at 56.835467 37.404949... The map seems okay. What shell I do with this message ?. Is this meassage only a hint for incorrect data ? Or what else ? thomas ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
[mkgmap-dev] found multiple points with equal coord.....
Hi , yesterday mkgmap r4587 gives me following message : 'found multiple points with equal coord as CoordPOI at 56.835467 37.404949... The map seems okay. What shell I do with this message ?. Is this meassage only a hint for incorrect data ? Or what else ? thomas ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk https://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
