Hey Oleksandr,
Sorry to hear that. I definitely think everything I pointed out can be
improved, but perhaps you are right that there is not time. Of course,
mlpack and ensmallen are open source, so if you do want to continue
contributing, PRs are totally welcome! I will do my best to try and
review them to get them merged (including the LMCMA PR you opened).
Thanks,
Ryan
On Tue, Apr 13, 2021 at 06:19:49PM +0200, Oleksandr Nikolskyy wrote:
> Hi Ryan,
> Thanks for the feedback. After thinking about the points you mentioned, I
> decided to withdraw my proposal, as there is no time left to make it
> stronger.
> I hope to contribute to mlpack in near future.
> Best,
> Oleksandr
--
Ryan Curtin| "Wha' happened?"
r...@ratml.org | - Mike LaFontaine
___
mlpack mailing list
mlpack@lists.mlpack.org
http://knife.lugatgt.org/cgi-bin/mailman/listinfo/mlpack
