[Mlt-devel] [PATCH] reorder frame initialization call, cleanup useless parts
Hi,
attached patch reorder mlt frame initialization to avoid additional
mlt_frame_close for some cases.
--
Maksym Veremeyenko
From 85c892311c19099189147b616ff50177988a0c97 Mon Sep 17 00:00:00 2001
From: Maksym Veremeyenko ve...@m1.tv
Date: Sun, 22 Jun 2014 17:29:32 +0300
Subject: [PATCH 2/6] reorder frame initialization call, cleanup useless parts
---
src/modules/decklink/producer_decklink.cpp | 17 -
1 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/modules/decklink/producer_decklink.cpp b/src/modules/decklink/producer_decklink.cpp
index 877c0ea..c580080 100644
--- a/src/modules/decklink/producer_decklink.cpp
+++ b/src/modules/decklink/producer_decklink.cpp
@@ -358,6 +358,7 @@ public:
IDeckLinkVideoInputFrame* video,
IDeckLinkAudioInputPacket* audio )
{
+ mlt_frame frame = NULL;
if( !m_reprio )
{
mlt_properties properties = MLT_PRODUCER_PROPERTIES( getProducer() );
@@ -402,9 +403,6 @@ public:
return S_OK;
}
- // Create mlt_frame
- mlt_frame frame = mlt_frame_init( MLT_PRODUCER_SERVICE( getProducer() ) );
-
// Copy video
if ( video )
{
@@ -446,20 +444,17 @@ public:
{
size = video-GetRowBytes() * video-GetHeight();
swab2( (char*) buffer, (char*) image + m_vancLines * video-GetRowBytes(), size );
+ frame = mlt_frame_init( MLT_PRODUCER_SERVICE( getProducer() ) );
mlt_frame_set_image( frame, (uint8_t*) image, size, mlt_pool_release );
}
else if ( image )
{
- mlt_log_verbose( getProducer(), no video\n );
+ mlt_log_verbose( getProducer(), no video image\n );
mlt_pool_release( image );
}
}
else
- {
-mlt_log_verbose( getProducer(), no signal\n );
-mlt_frame_close( frame );
-frame = 0;
- }
+mlt_log_verbose( getProducer(), frame is invalid\n );
// Get timecode
IDeckLinkTimecode* timecode = 0;
@@ -479,11 +474,7 @@ public:
}
}
else
- {
mlt_log_verbose( getProducer(), no video\n );
- mlt_frame_close( frame );
- frame = 0;
- }
// Copy audio
if ( frame audio )
--
1.7.7.6
--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing Easy Data Exploration
http://p.sf.net/sfu/hpccsystems___
Mlt-devel mailing list
Mlt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [PATCH] fix playlist items move
Hi, attached patch fix playlist item movement and setting new indexes. -- Maksym Veremeyenko From eff949aeec2ffbe5299ebd21b0163dbd1d1f1ab5 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko ve...@m1.tv Date: Sun, 22 Jun 2014 17:13:10 +0300 Subject: [PATCH 1/6] fix playlist items move --- src/framework/mlt_playlist.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/framework/mlt_playlist.c b/src/framework/mlt_playlist.c index 62a1f16..306ff93 100644 --- a/src/framework/mlt_playlist.c +++ b/src/framework/mlt_playlist.c @@ -919,7 +919,9 @@ int mlt_playlist_move( mlt_playlist self, int src, int dest ) if ( current == src ) current = dest; - else if ( current src current dest ) + else if ( src current current dest ) + current --; + else if ( dest current current src ) current ++; else if ( current == dest ) current = src; -- 1.7.7.6 -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] implement timecode barrier - skip all frames with VITC
On Sun, Jun 22, 2014 at 6:24 AM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, attached patch implement kind of timecode barrier i.e. skip frames if their timecode less then specified. this patch makes possible a frame-accurate capturing from VTR sources. I like it, but you need to document the new property in the yml file. -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] convert yuv422 image rgb24 only if left position is odd
On Sun, Jun 22, 2014 at 6:27 AM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, crop filter seems always want to convert to rgb24 but IMHO it is required only of left offset is odd, am i correct? Since we coerce the output to an even width, yes, it is correct. However, your change should include parenthesis to make more readable as the ... ... ... runs together. -- +-DRD-+ -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [mltframework/mlt] 5b05e1: Set timecode and userbits to output frame
Branch: refs/heads/master Home: https://github.com/mltframework/mlt Commit: 5b05e1954f607e3f4f02d07435eba592c105d6be https://github.com/mltframework/mlt/commit/5b05e1954f607e3f4f02d07435eba592c105d6be Author: Maksym Veremeyenko ve...@m1.tv Date: 2014-06-22 (Sun, 22 Jun 2014) Changed paths: M src/modules/decklink/consumer_decklink.cpp Log Message: --- Set timecode and userbits to output frame -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] Set timecode and userbits to output frame
On Sun, Jun 22, 2014 at 6:28 AM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, attached patch implement setting VITC timecode and userbits to output frame. Thanks, I applied this. -- +-DRD-+ -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [mltframework/mlt] a523e1: convert yuv422 image rgb24 only if left position i...
Branch: refs/heads/master Home: https://github.com/mltframework/mlt Commit: a523e1bbf69d61ffa4b9957dd3f6ea8a1b962d8c https://github.com/mltframework/mlt/commit/a523e1bbf69d61ffa4b9957dd3f6ea8a1b962d8c Author: Maksym Veremeyenko ve...@m1.tv Date: 2014-06-22 (Sun, 22 Jun 2014) Changed paths: M src/modules/core/filter_crop.c Log Message: --- convert yuv422 image rgb24 only if left position is odd -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] convert yuv422 image rgb24 only if left position is odd
On Sun, Jun 22, 2014 at 11:48 AM, Dan Dennedy d...@dennedy.org wrote: On Sun, Jun 22, 2014 at 6:27 AM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, crop filter seems always want to convert to rgb24 but IMHO it is required only of left offset is odd, am i correct? Since we coerce the output to an even width, yes, it is correct. However, your change should include parenthesis to make more readable as the ... ... ... runs together. I added the parenthesis and applied this patch. -- +-DRD-+ -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [mltframework/mlt] 9c6ae2: Fix current position adjustment when moving a play...
Branch: refs/heads/master Home: https://github.com/mltframework/mlt Commit: 9c6ae2bd2979eba6d55424b195ec88ee8f376993 https://github.com/mltframework/mlt/commit/9c6ae2bd2979eba6d55424b195ec88ee8f376993 Author: Maksym Veremeyenko ve...@m1.tv Date: 2014-06-22 (Sun, 22 Jun 2014) Changed paths: M src/framework/mlt_playlist.c Log Message: --- Fix current position adjustment when moving a playlist item. -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] fix playlist items move
On Sun, Jun 22, 2014 at 11:14 AM, Dan Dennedy d...@dennedy.org wrote: On Sun, Jun 22, 2014 at 6:19 AM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, attached patch fix playlist item movement and setting new indexes. If you want me to apply your patch with your authorship information and git-am, then please use a better commit message. fix is not good enough. I changed your message and committed it with your authorship. Please keep in mind for future to have a meaningful message. Sometimes your email body contains a better message! -- +-DRD-+ -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
