Re: [Mlt-devel] [PATCH] use INT_MAX for for default producer length ?
27.06.14 20:30, Dan Dennedy написав(ла): On Thu, Jun 26, 2014 at 11:25 PM, Maksym Veremeyenko ve...@m1stereo.tv mailto:ve...@m1stereo.tv wrote: Hi, i found that specifying in/out properties of producer (with still image) is not enough for playing it for specified time. In the attached test file logo will disappear in 10 minutes because of default length for producer was set to 15000 frames. may be we can change 15000 magic value with another large value like INT_MAX? OK, I have known about this since forever, and I have been on the fence about whether to change it. For the longest time my feeling was that apps should manage the length of image producers, and then this problem never really appears to the user. However, for the person using the command line, melted, or manually learning and authoring MLT XML, it is inconvenient to have to be reminded about this default length and not be able to simply set the out point. So, I can accept the patch after some testing in apps Shotcut, Flowblade, and Kdenlive. We have to test different kinds of producers to ensure the user does not end up accidentally adding some huge item to the timeline, potentially causing a crash due to exceeding some GUI canvas limitation. Therefore, I will apply the patch after the 0.9.2 release. that patch would definitely break Shotcut, Flowblade, and Kdenlive behaviour... may then introduce env variable to override default value? -- Maksym Veremeyenko -- Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
[Mlt-devel] [PATCH] use INT_MAX for for default producer length ?
Hi, i found that specifying in/out properties of producer (with still image) is not enough for playing it for specified time. In the attached test file logo will disappear in 10 minutes because of default length for producer was set to 15000 frames. may be we can change 15000 magic value with another large value like INT_MAX? -- Maksym Veremeyenko From 856abd2f14ba26a142a9324458775d7a358f4493 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko ve...@m1.tv Date: Fri, 27 Jun 2014 11:12:31 +0300 Subject: [PATCH] use INT_MAX for for default producer length --- src/framework/mlt_producer.c |4 ++-- src/modules/core/producer_hold.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/framework/mlt_producer.c b/src/framework/mlt_producer.c index d5c049b..6311198 100644 --- a/src/framework/mlt_producer.c +++ b/src/framework/mlt_producer.c @@ -93,8 +93,8 @@ int mlt_producer_init( mlt_producer self, void *child ) mlt_properties_set_double( properties, _frame, 0 ); mlt_properties_set_double( properties, _speed, 1.0 ); mlt_properties_set_position( properties, in, 0 ); - mlt_properties_set_position( properties, out, 14999 ); - mlt_properties_set_position( properties, length, 15000 ); + mlt_properties_set_position( properties, out, INT_MAX - 1 ); + mlt_properties_set_position( properties, length, INT_MAX ); mlt_properties_set( properties, eof, pause ); mlt_properties_set( properties, resource, producer ); diff --git a/src/modules/core/producer_hold.c b/src/modules/core/producer_hold.c index 6c888c4..c5e323c 100644 --- a/src/modules/core/producer_hold.c +++ b/src/modules/core/producer_hold.c @@ -55,7 +55,7 @@ mlt_producer producer_hold_init( mlt_profile profile, mlt_service_type type, con mlt_properties_set_position( properties, frame, 0 ); mlt_properties_set_position( properties, in, 0 ); mlt_properties_set_position( properties, out, 25 ); - mlt_properties_set_position( properties, length, 15000 ); + mlt_properties_set_position( properties, length, INT_MAX ); mlt_properties_set( properties, resource, arg ); mlt_properties_set( properties, method, onefield ); -- 1.7.7.6 ?xml version=1.0 ? mlt producer id=clip in=0 out=2 property name=resource/home/studio/Videos/TheCore/data/m-files/11.11.2000_1.avi/property property name=force_aspect_ratio@16/15/property /producer producer id=producer0 property name=force_aspect_ratio@16/15/property property name=resource/home/studio/Videos/TheCore/data/assets/m1_logo_fullHD.png/property /producer playlist id=playlist0 entry producer=producer0 in=0 out=2/ /playlist tractor multitrack track producer=clip/ track producer=playlist0/ /multitrack transition in=0 out=2 property name=valigntop/property property name=halignright/property property name=progressive1/property property name=distort0/property property name=key[0]-30/30:100%x100%:100/property property name=key[2]-30/30:100%x100%:100/property property name=mlt_servicecomposite/property property name=a_track0/property property name=b_track1/property /transition /tractor /mlt -- Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [PATCH] use INT_MAX for for default producer length ?
On Thu, Jun 26, 2014 at 11:25 PM, Maksym Veremeyenko ve...@m1stereo.tv wrote: Hi, i found that specifying in/out properties of producer (with still image) is not enough for playing it for specified time. In the attached test file logo will disappear in 10 minutes because of default length for producer was set to 15000 frames. may be we can change 15000 magic value with another large value like INT_MAX? OK, I have known about this since forever, and I have been on the fence about whether to change it. For the longest time my feeling was that apps should manage the length of image producers, and then this problem never really appears to the user. However, for the person using the command line, melted, or manually learning and authoring MLT XML, it is inconvenient to have to be reminded about this default length and not be able to simply set the out point. So, I can accept the patch after some testing in apps Shotcut, Flowblade, and Kdenlive. We have to test different kinds of producers to ensure the user does not end up accidentally adding some huge item to the timeline, potentially causing a crash due to exceeding some GUI canvas limitation. Therefore, I will apply the patch after the 0.9.2 release. -- +-DRD-+ -- Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
