Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
In my opinion to have support for 10 years old hardware is more than enough and to drop support for SDL is ok for me. SDL did the job the last years so far but GL has great potential. Absolutely smooth running with several filters applied to hd material is pretty cool. In this point I'm with Steinar. Its better to concentrate on openGL and make it perfect than to try to support all possible very old hardware. We dont have this crew to do this. And openGL is the future or already standard in pro video programs like Liteworks and co. Another point is what GL version to support. This has to be discussed. @Brian: BTW: here the patch regards eddrog 2014-03-15 19:18 GMT+01:00 Brian Matherly pez4br...@yahoo.com: Well, notwithstanding that it might work just fine with your card anyway, I'm not sure if there should be a perpetual right to upgrade. Software has increasing system demands all the time, as they add more features. As an extreme example, you can't run Linux on 386 anymore :-) It seems to come down to some core questions for you guys to decide: * Should OpenGl be a strict requirement for KDENLIVE? * If so, what version? * Should Movit be a strict requirement for KDENLIVE? I still don't understand why the build script (which does not include movit) doesn't produce a working KDENLIVE. I understand that the monitor requires OpenGL. But why does it also require Movit? Can't the monitor work with OpenGL even if Movit is not available? ~Brian From f4f0f49db379d7e6a9eccedf764409e6edcccf9b Mon Sep 17 00:00:00 2001 From: Ed Rogalsky ed.rogal...@googlemail.com Date: Sat, 15 Mar 2014 21:34:33 +0100 Subject: [PATCH] movit build added --- build/build-kdenlive.sh | 56 ++--- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git a/build/build-kdenlive.sh b/build/build-kdenlive.sh index 9ea2515..2ab3b3e 100755 --- a/build/build-kdenlive.sh +++ b/build/build-kdenlive.sh @@ -19,7 +19,7 @@ # ARGS AND GLOBALS -VERSION=20 +VERSION=21 # These are all of the configuration variables with defaults INSTALL_DIR=$HOME/kdenlive @@ -39,6 +39,9 @@ FREI0R_REVISION= ENABLE_SWFDEC=0 SWFDEC_HEAD=1 SWFDEC_REVISION= +ENABLE_MOVIT=1 +MOVIT_HEAD=1 +MOVIT_REVISION= X264_HEAD=0 X264_REVISION=d967c09cd93a230e03ec1e0f0f696975d15a01c0 LIBVPX_HEAD=1 @@ -196,6 +199,9 @@ function to_key { lame) echo 7 ;; +movit) + echo 8 +;; *) echo UNKNOWN ;; @@ -339,6 +345,9 @@ function set_globals { if test $ENABLE_FREI0R = 1 ; then SUBDIRS=frei0r $SUBDIRS fi + if test $ENABLE_MOVIT = 1 test $MOVIT_HEAD = 1 -o $MOVIT_REVISION != ; then + SUBDIRS=movit $SUBDIRS + fi if test $ENABLE_SWFDEC = 1 ; then SUBDIRS=swfdec $SUBDIRS fi @@ -362,6 +371,7 @@ function set_globals { REPOLOCS[5]=http://git.chromium.org/webm/libvpx.git; REPOLOCS[6]=git://github.com/mltframework/swfdec.git REPOLOCS[7]=http://downloads.sourceforge.net/project/lame/lame/3.99/lame-3.99.1.tar.gz; + REPOLOCS[8]=git://github.com/ddennedy/movit.git # REPOTYPE Array holds the repo types. (Yes, this might be redundant, but easy for me) REPOTYPES[0]=git @@ -372,6 +382,7 @@ function set_globals { REPOTYPES[5]=git REPOTYPES[6]=git REPOTYPES[7]=http-tgz + REPOTYPES[8]=git # And, set up the revisions REVISIONS[0]= @@ -404,6 +415,11 @@ function set_globals { REVISIONS[6]=$SWFDEC_REVISION fi REVISIONS[7]=lame-3.99.1 + REVISIONS[8]= + if test 0 = $MOVIT_HEAD -a $MOVIT_REVISION ; then +REVISIONS[8]=$MOVIT_REVISION + fi + # Figure out the install dir - we may not install, but then we know it. FINAL_INSTALL_DIR=$INSTALL_DIR @@ -515,6 +531,19 @@ function set_globals { CONFIG[7]=./configure --prefix=$FINAL_INSTALL_DIR --libdir=$FINAL_INSTALL_DIR/lib --disable-decoder --disable-frontend CFLAGS_[7]=$CFLAGS LDFLAGS_[7]=$LDFLAGS + +# + # movit + CONFIG[8]=./autogen.sh --prefix=$FINAL_INSTALL_DIR + if test $TARGET_OS = Win32 ; then +CONFIG[8]=${CONFIG[5]} --host=x86-w64-mingw32 +CFLAGS_[8]=$CFLAGS + elif test $TARGET_OS = Darwin; then +CFLAGS_[8]=$CFLAGS -I/opt/local/include + else +CFLAGS_[8]=$CFLAGS + fi + LDFLAGS_[8]=$LDFLAGS } ## @@ -658,6 +687,10 @@ function prepare_feedback { debug Adding 1 step for get frei0r NUMSTEPS=$(( $NUMSTEPS + 1 )) fi +if test 1 = $ENABLE_MOVIT ; then + debug Adding 1 step for get movit + NUMSTEPS=$(( $NUMSTEPS + 1 )) +fi if test 1 = $ENABLE_SWFDEC ; then debug Adding 1 step for get swfdec NUMSTEPS=$(( $NUMSTEPS + 1 )) @@ -679,6 +712,10 @@ function prepare_feedback { debug Adding 1 step for clean frei0r NUMSTEPS=$(( $NUMSTEPS + 1 )) fi +if test 1 = $ENABLE_MOVIT ; then + debug
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
On Sat, Mar 15, 2014 at 09:40:46AM -0700, Brian Matherly wrote: Sorry, I was off by a digit. I should have said that my laptop suports 3.1 but Shotcut requires 3.2 to use movit filters. I don't know offhand what this requirement is for. Maybe GL_ARB_sync (I added a dependency on this to MLT at some point, but it would be relatively easy to add back the glFinish() fallback if somehow there are important cards that don't support this), but you don't need the rest of 3.2 for that. In any case, I'm running Kdenlive with Movit just fine with my 5th gen Intel (OpenGL 2.1 + extensions), so I don't think you have to worry about this for Kdenlive. Have you tried the current git? As far as my own use cases, I have a capture rig in another room with a sempron processor that I use for capturing from VCRs. I keep the whole rig in another room so that I don't clutter up my office with multiple VCRs and other equipment. That's a fairly old machine (approaching the 10 year range), but it is perfectly suited for capturing DV with KDENLIVE. And I would be disappointed if one day I upgraded KDENLIVE and it stopped working. Well, notwithstanding that it might work just fine with your card anyway, I'm not sure if there should be a perpetual “right to upgrade”. Software has increasing system demands all the time, as they add more features. As an extreme example, you can't run Linux on 386 anymore :-) /* Steinar */ -- Homepage: http://www.sesse.net/ -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
On Sat, Mar 15, 2014 at 01:58:18PM +0100, Ed Rogalsky wrote: I don't know how stable it is but Steinar merged his code into kdenlive/master and dropped support for SDL what makes current HEAD unusable who use the build script. Strictly speaking, I don't have write access to the Kdenlive repository; Martin Sandsmark helped me clean things up and merged it for me. But yes, it was definitely my initiative. :-) It compiles but on starting movit is not found and kdenlive exits. Perhaps I should write to Steinar but it seems that he wants to do it stable asap. Yes, I want to release Movit 1.0 very soon, which should hopefully make things easier for packagers. I'd hoped to do it this weekend, but I hit some bugs in the new FFT convolution code that I'd really like to get out. Also, I had hoped to move from GLEW to epoxy, but it seems epoxy has a showstopper bug that won't get fixed in time for 1.0. /* Steinar */ -- Homepage: http://www.sesse.net/ -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
On Sat, Mar 15, 2014 at 06:26:25AM -0700, Brian Matherly wrote: My opinion would be that SDL support should *not* be removed. Hi! First of all, I'm grateful that you phrase this as “exciting stuff”, because I'm excited, too. :-) My laptop has an i5 with the Intel graphics. I can't use OpenGL with Shotcut because it requires OpenGl 2.2 and the chipset in my laptop only supports 2.1. I personally expect that there will be plenty of people in the world who are happily editing SD content on an older machine who will no longer be able to use KDENLIVE when they upgrade. There's no such thing as OpenGL 2.2; there's 2.1 and there's 3.0. Movit's OpenGL requirements are phrased in terms of extension support; OpenGL 3.0 contains all the features that are needed, but in almost any OpenGL 2.1 implementation will do (the extra extensions required over 2.1 are very common). What kind of chipset is this? As far as I can see, every Intel chipset since 4th generation should have the required extensions. That's 2006, so you're talking eight years ago. My main Movit developer laptop has 5th generation, and it's starting to get so old that it's hard to find spare parts if anything should break down. It seems premature to me. I think this is an interesting question; when would be late enough? Should really the needs of ten year old hardware dictate what feature the rest of the world can do? As much as people in the FOSS world seems to love the checkbox approach, unfortunately Kdenlive is not in a situation where there's manpower to do both, as far as I can see (and if so, maybe that manpower is better spent elsewhere?). There are two different questions in play here, by the way; requiring support for the OpenGL monitor (requires only OpenGL 1.1, I think?), and requiring Movit support. Maybe one could get to the point where one would go for #1 but not #2, but the answer to “is it worth it” is currently a resounding “maybe” as far as I can see. :-) /* Steinar */ -- Homepage: http://www.sesse.net/ -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
On Sat, Mar 15, 2014 at 9:49 AM, Steinar H. Gunderson sgunder...@bigfoot.com wrote: On Sat, Mar 15, 2014 at 09:40:46AM -0700, Brian Matherly wrote: Sorry, I was off by a digit. I should have said that my laptop suports 3.1 but Shotcut requires 3.2 to use movit filters. I don't know offhand what this requirement is for. Maybe GL_ARB_sync (I added a dependency on this to MLT at some point, but it would be relatively easy to add back the glFinish() fallback if somehow there are important cards that don't support this), but you don't need the rest of 3.2 for that. In any case, I'm running Kdenlive with Movit just fine with my 5th gen Intel (OpenGL 2.1 + extensions), so I don't think you have to worry about this for Kdenlive. There are 2 reasons for GL v3.2. The first one is a soft requirement - a simple way to specify what is needed without requiring one to be very knowledgable about GL extensions. Yes, the sync extension is being used, which was added in v3.2, thus the reason for stating that. The second reason creates a hard requirement on Windows only and might be due to how Qt 5 works, but I am not sure. On my Windows systems, in order to get GL to accept the usage of this and other extensions, upon requesting a context through Qt, I must specify a GL version that is high enough. So, on Windows, at least on my systems, I must request 3.2. This is not done on Linux and OS X. On those platforms, Qt creates a context, verifies extensions, and sets up function pointers suitable for a common subset of OpenGL 2.0 and GLES 2.0 for Qt Quick per its default behavior. The context is not limited to those GL versions, usage of extensions work fine, and there is no coded dependency on a specific GL version in Shotcut or MLT. -- +-DRD-+ -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
@Brian: BTW: here the patch The patch looks good. I committed it. -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel
Re: [Mlt-devel] [Kdenlive-devel] movit in kdenlive build script
My laptop has an i5 with the Intel graphics. I can't use OpenGL with Shotcut because it requires OpenGl 2.2 and the chipset in my laptop only supports 2.1. I personally expect that there will be plenty of people in the world who are happily editing SD content on an older machine who will no longer be able to use KDENLIVE when they upgrade. There's no such thing as OpenGL 2.2; there's 2.1 and there's 3.0. Movit's OpenGL requirements are phrased in terms of extension support; OpenGL 3.0 contains all the features that are needed, but in almost any OpenGL 2.1 implementation will do (the extra extensions required over 2.1 are very common). Sorry, I was off by a digit. I should have said that my laptop suports 3.1 but Shotcut requires 3.2 to use movit filters. What kind of chipset is this? As far as I can see, every Intel chipset since 4th generation should have the required extensions. That's 2006, so you're talking eight years ago. My main Movit developer laptop has 5th generation, and it's starting to get so old that it's hard to find spare parts if anything should break down. I think your comments about 8 years is a helpful data point for this discussion. There are two different questions in play here, by the way; requiring support for the OpenGL monitor (requires only OpenGL 1.1, I think?), and requiring Movit support. Maybe one could get to the point where one would go for #1 but not #2, but the answer to “is it worth it” is currently a resounding “maybe” as far as I can see. :-) That's good insight. In my opinion, it would be reasonable to require relatively new hardware in order to take advantage of the Movit features. But the monitor is fundamental to the operation of the application - and it should be supported on older hardware within reason. As far as my own use cases, I have a capture rig in another room with a sempron processor that I use for capturing from VCRs. I keep the whole rig in another room so that I don't clutter up my office with multiple VCRs and other equipment. That's a fairly old machine (approaching the 10 year range), but it is perfectly suited for capturing DV with KDENLIVE. And I would be disappointed if one day I upgraded KDENLIVE and it stopped working. Now, in this specific case, the machine has an NVIDIA chipset and supports OpenGL 2.1 - so, from the sounds of things, it should keep working with the opengl monitor for quite some time. ~Brian -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech ___ Mlt-devel mailing list Mlt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mlt-devel