Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow
Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you extract verification logic into separate method and check there that the number of collectors is equal to the hard-coded constant? Otherwise, looks good. Best regards, Vladimir Ivanov ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow
Looks good. Best regards, Vladimir Ivanov On 11/5/14, 8:22 PM, Claes Redestad wrote: Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you extract verification logic into separate method and check there that the number of collectors is equal to the hard-coded constant? Done: http://cr.openjdk.java.net/~redestad/8062180/webrev.02 I've run some tests with -ea -esa to ensure the asserts pass as they should. Otherwise, looks good. Thanks! /Claes Best regards, Vladimir Ivanov ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow
Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you extract verification logic into separate method and check there that the number of collectors is equal to the hard-coded constant? Done: http://cr.openjdk.java.net/~redestad/8062180/webrev.02 I've run some tests with -ea -esa to ensure the asserts pass as they should. Otherwise, looks good. Thanks! /Claes Best regards, Vladimir Ivanov ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
