Re: [PATCH 3/8] wavecom: ignore custom flow control handling

2017-04-18 Thread Aleksander Morgado
On 25/03/17 19:32, Aleksander Morgado wrote:
> The generic modem object already supports querying for the supported
> methods and setting the best one found.
> ---

This has been merged to git master.

>  plugins/wavecom/mm-broadband-modem-wavecom.c | 27 ---
>  1 file changed, 27 deletions(-)
> 
> diff --git a/plugins/wavecom/mm-broadband-modem-wavecom.c 
> b/plugins/wavecom/mm-broadband-modem-wavecom.c
> index 47c6b4f0..0e93e47e 100644
> --- a/plugins/wavecom/mm-broadband-modem-wavecom.c
> +++ b/plugins/wavecom/mm-broadband-modem-wavecom.c
> @@ -1242,31 +1242,6 @@ modem_after_sim_unlock (MMIfaceModem *self,
>  }
>  
>  
> /*/
> -/* Flow control (Modem interface) */
> -
> -static gboolean
> -setup_flow_control_finish (MMIfaceModem *self,
> -   GAsyncResult *res,
> -   GError **error)
> -{
> -return !!mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, 
> error);
> -}
> -
> -static void
> -setup_flow_control (MMIfaceModem *self,
> -GAsyncReadyCallback callback,
> -gpointer user_data)
> -{
> -/* Wavecom doesn't have XOFF/XON flow control, so we enable RTS/CTS */
> -mm_base_modem_at_command (MM_BASE_MODEM (self),
> -  "+IFC=2,2",
> -  3,
> -  FALSE,
> -  callback,
> -  user_data);
> -}
> -
> -/*/
>  /* Modem power up (Modem interface) */
>  
>  static gboolean
> @@ -1420,8 +1395,6 @@ iface_modem_init (MMIfaceModem *iface)
>  iface->load_access_technologies_finish = load_access_technologies_finish;
>  iface->modem_after_sim_unlock = modem_after_sim_unlock;
>  iface->modem_after_sim_unlock_finish = modem_after_sim_unlock_finish;
> -iface->setup_flow_control = setup_flow_control;
> -iface->setup_flow_control_finish = setup_flow_control_finish;
>  iface->modem_power_up = modem_power_up;
>  iface->modem_power_up_finish = modem_power_up_finish;
>  iface->modem_power_down = modem_power_down;
> 


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


[PATCH 3/8] wavecom: ignore custom flow control handling

2017-03-25 Thread Aleksander Morgado
The generic modem object already supports querying for the supported
methods and setting the best one found.
---
 plugins/wavecom/mm-broadband-modem-wavecom.c | 27 ---
 1 file changed, 27 deletions(-)

diff --git a/plugins/wavecom/mm-broadband-modem-wavecom.c 
b/plugins/wavecom/mm-broadband-modem-wavecom.c
index 47c6b4f0..0e93e47e 100644
--- a/plugins/wavecom/mm-broadband-modem-wavecom.c
+++ b/plugins/wavecom/mm-broadband-modem-wavecom.c
@@ -1242,31 +1242,6 @@ modem_after_sim_unlock (MMIfaceModem *self,
 }
 
 /*/
-/* Flow control (Modem interface) */
-
-static gboolean
-setup_flow_control_finish (MMIfaceModem *self,
-   GAsyncResult *res,
-   GError **error)
-{
-return !!mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, 
error);
-}
-
-static void
-setup_flow_control (MMIfaceModem *self,
-GAsyncReadyCallback callback,
-gpointer user_data)
-{
-/* Wavecom doesn't have XOFF/XON flow control, so we enable RTS/CTS */
-mm_base_modem_at_command (MM_BASE_MODEM (self),
-  "+IFC=2,2",
-  3,
-  FALSE,
-  callback,
-  user_data);
-}
-
-/*/
 /* Modem power up (Modem interface) */
 
 static gboolean
@@ -1420,8 +1395,6 @@ iface_modem_init (MMIfaceModem *iface)
 iface->load_access_technologies_finish = load_access_technologies_finish;
 iface->modem_after_sim_unlock = modem_after_sim_unlock;
 iface->modem_after_sim_unlock_finish = modem_after_sim_unlock_finish;
-iface->setup_flow_control = setup_flow_control;
-iface->setup_flow_control_finish = setup_flow_control_finish;
 iface->modem_power_up = modem_power_up;
 iface->modem_power_up_finish = modem_power_up_finish;
 iface->modem_power_down = modem_power_down;
-- 
2.12.0

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel