Re: [review] New key-value output in mmcli
> Thanks; looks like the main difference is long lines are intelligently > wrapped now, so code expecting one-value-per-line will break. I > haven't checked the implementation in detail, but does it hardcode the > wrapping at a certain point or determine it based on terminal size or > something? > The long line wrapping is one of the changes, yes. For now it just wraps if the line is longer that some value. Another change is that the field values are no longer given between single-quotes. Also the initial "General" section is new, I needed a way to make it report the values in a custom new group of fields. And also, the "state" output in mmcli may be colored: green if connected, red if failed, and not explicitly colored otherwise. There are probably other differences in the output, but minimal I guess (e.g. the sizes of the columns are automatically computed now based on the sections and fields that are going to be printed) -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
Re: [review] New key-value output in mmcli
On Fri, 2018-11-09 at 18:31 +0100, Aleksander Morgado wrote: > Hey, > > > > > > See this MR: https://gitlab.freedesktop.org/mobile-broadband/Mode > > > mMan > > > ager/merge_requests/51 > > > > > > This enables a new "-K" (or longer, "--output-keyvalue") that > > > allows > > > all operations that print some kind of modem info (e.g. modem > > > list, > > > modem info, sim info, bearer info, sms info, 3gpp scan...) to be > > > dumped in a simple "key-value" pair format. > > > > > > Along with these changes, I've also made some additional changes: > > > deprecating ListBearers() method and removing the redundant > > > --simple-status and --location-get-XXX actions. > > > > > > Worth noting: the original human-friendly output is more or less > > > maintained but it is NOT equal to the old one. Applications (e.g. > > > the > > > openwrt integration) that were parsing that original output > > > should > > > switch to the new key-value pair output. > > > > Do you have a before/after example of the tabular output? > > > > Attached Thanks; looks like the main difference is long lines are intelligently wrapped now, so code expecting one-value-per-line will break. I haven't checked the implementation in detail, but does it hardcode the wrapping at a certain point or determine it based on terminal size or something? Dan ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
Re: [review] New key-value output in mmcli
Hey, > > > See this MR: https://gitlab.freedesktop.org/mobile-broadband/ModemMan > > ager/merge_requests/51 > > > > This enables a new "-K" (or longer, "--output-keyvalue") that allows > > all operations that print some kind of modem info (e.g. modem list, > > modem info, sim info, bearer info, sms info, 3gpp scan...) to be > > dumped in a simple "key-value" pair format. > > > > Along with these changes, I've also made some additional changes: > > deprecating ListBearers() method and removing the redundant > > --simple-status and --location-get-XXX actions. > > > > Worth noting: the original human-friendly output is more or less > > maintained but it is NOT equal to the old one. Applications (e.g. the > > openwrt integration) that were parsing that original output should > > switch to the new key-value pair output. > > Do you have a before/after example of the tabular output? > Attached -- Aleksander https://aleksander.es $ mmcli -L /org/freedesktop/ModemManager1/Modem/0 [Fibocom Wireless Inc.] L850-GL $ mmcli -m 0 -- General | dbus path: /org/freedesktop/ModemManager1/Modem/0 | device id: 27029242494d4c7df37f1168df12e20ef796fb78 -- Hardware | manufacturer: Fibocom Wireless Inc. | model: L850-GL | revision: 18500_ATTAC00CONFIG_R02 | h/w revision: V1.0.4 | supported: gsm-umts, lte |current: gsm-umts, lte | equipment id: 863212030078742 -- System | device: /sys/devices/pci:00/:00:14.0/usb1/1-12/1-12.2 |drivers: cdc_acm, cdc_mbim | plugin: Fibocom | primary port: cdc-wdm3 | ports: ttyACM0 (at), wwan0 (net), ttyACM1 (unknown), | cdc-wdm3 (mbim), ttyACM2 (unknown) -- Status | unlock retries: sim-pin2 (3) | state: registered |power state: on |access tech: lte | signal quality: 22% (recent) -- Modes| supported: allowed: 3g; preferred: none | allowed: 4g; preferred: none | allowed: 3g, 4g; preferred: none | allowed: 3g, 4g; preferred: 3g | allowed: 3g, 4g; preferred: 4g |current: allowed: 3g, 4g; preferred: 4g -- Bands| supported: utran-1, utran-4, utran-5, utran-8, utran-2, eutran-1, | eutran-2, eutran-3, eutran-4, eutran-5, eutran-7, eutran-8, | eutran-11, eutran-12, eutran-13, eutran-17, eutran-18, eutran-19, | eutran-20, eutran-21, eutran-26, eutran-28, eutran-29, eutran-30, | eutran-38, eutran-39, eutran-40, eutran-41, eutran-66 |current: utran-1, utran-4, utran-5, utran-8, utran-2, eutran-1, | eutran-2, eutran-3, eutran-4, eutran-5, eutran-7, eutran-8, | eutran-11, eutran-12, eutran-13, eutran-17, eutran-18, eutran-19, | eutran-20, eutran-21, eutran-26, eutran-28, eutran-29, eutran-30, | eutran-38, eutran-39, eutran-40, eutran-41, eutran-66 -- IP | supported: ipv4, ipv6, ipv4v6 -- 3GPP | imei: 863212030078742 | enabled locks: fixed-dialing |operator id: 21407 | operator name: Movistar | registration: home |eps ue mode: csps-2 -- SIM | dbus path: /org/freedesktop/ModemManager1/SIM/0 $ mmcli -m 0 -K modem.dbus-path : /org/freedesktop/ModemManager1/Modem/0 modem.generic.device-identifier : 27029242494d4c7df37f1168df12e20ef796fb78 modem.generic.manufacturer: Fibocom Wireless Inc. modem.generic.model : L850-GL modem.generic.revision: 18500_ATTAC00CONFIG_R02 modem.generic.hardware-revision : V1.0.4 modem.generic.supported-capabilities.length : 1 modem.generic.supported-capabilities.value[1] : gsm-umts, lte modem.generic.current-capabilities.length : 1 modem.generic.current-capabilities.value[1] : gsm-umts, lte modem.generic.equipment-identifier: 863212030078742 modem.generic.device : /sys/devices/pci:00/:00:14.0/usb1/1-12/1-12.2 modem.generic.drivers.length : 2 modem.generic.drivers.value[1]: cdc_acm modem.generic.drivers.value[2]: cdc_mbim modem.generic.plugin : Fibocom modem.generic.primary-port:
Re: [review] New key-value output in mmcli
On Sat, 2018-11-03 at 16:04 +0100, Aleksander Morgado wrote: > Hey! > > See this MR: https://gitlab.freedesktop.org/mobile-broadband/ModemMan > ager/merge_requests/51 > > This enables a new "-K" (or longer, "--output-keyvalue") that allows > all operations that print some kind of modem info (e.g. modem list, > modem info, sim info, bearer info, sms info, 3gpp scan...) to be > dumped in a simple "key-value" pair format. > > Along with these changes, I've also made some additional changes: > deprecating ListBearers() method and removing the redundant > --simple-status and --location-get-XXX actions. > > Worth noting: the original human-friendly output is more or less > maintained but it is NOT equal to the old one. Applications (e.g. the > openwrt integration) that were parsing that original output should > switch to the new key-value pair output. Do you have a before/after example of the tabular output? Dan > Comments welcome! > > $ mmcli -L -K > modem-list.length : 2 > modem-list.value[1] : /org/freedesktop/ModemManager1/Modem/0 > modem-list.value[2] : /org/freedesktop/ModemManager1/Modem/6 > > $ mmcli -m 0 -K > modem.dbus-path : > /org/freedesktop/ModemManager1/Modem/0 > modem.generic.device-identifier : > 1a48f1180f1fb0166d91f7b139d027136b59ba63 > modem.generic.manufacturer: Sierra Wireless Inc. > modem.generic.model : Sierra Wireless > EM7345 4G LTE > modem.generic.revision: > FIH7160_V1.1_MODEM_01.1349.12 > modem.generic.hardware-revision : > XMM7160_V1.1_MBIM_GNSS_NAND_RE > modem.generic.supported-capabilities.length : 1 > modem.generic.supported-capabilities.value[1] : gsm-umts, lte > modem.generic.current-capabilities.length : 1 > modem.generic.current-capabilities.value[1] : gsm-umts, lte > modem.generic.equipment-identifier: 013937003110648 > modem.generic.device : > /sys/devices/pci:00/:00:14.0/usb2/2-4 > modem.generic.drivers.length : 1 > modem.generic.drivers.value[1]: cdc_mbim > modem.generic.plugin : Sierra > modem.generic.primary-port: cdc-wdm0 > modem.generic.ports.length: 2 > modem.generic.ports.value[1] : cdc-wdm0 (mbim) > modem.generic.ports.value[2] : wwan0 (net) > modem.generic.own-numbers : -- > modem.generic.unlock-required : -- > modem.generic.unlock-retries.length : 1 > modem.generic.unlock-retries.value[1] : sim-pin (3) > modem.generic.state : connected > modem.generic.state-failed-reason : -- > modem.generic.power-state : on > modem.generic.access-technologies.length : 1 > modem.generic.access-technologies.value[1]: lte > modem.generic.signal-quality.value: 22 > modem.generic.signal-quality.recent : no > modem.generic.supported-modes.length : 1 > modem.generic.supported-modes.value[1]: allowed: 2g, 3g, 4g; > preferred: none > modem.generic.current-modes : allowed: 2g, 3g, 4g; > preferred: none > modem.generic.supported-bands : -- > modem.generic.current-bands : -- > modem.generic.supported-ip-families.length: 3 > modem.generic.supported-ip-families.value[1] : ipv4 > modem.generic.supported-ip-families.value[2] : ipv6 > modem.generic.supported-ip-families.value[3] : ipv4v6 > modem.3gpp.imei : 013937003110222 > modem.3gpp.enabled-locks.length : 1 > modem.3gpp.enabled-locks.value[1] : fixed-dialing > modem.3gpp.operator-code : 21407 > modem.3gpp.operator-name : Movistar > modem.3gpp.registration-state : home > modem.3gpp.eps-ue-mode-operation : -- > modem.3gpp.pco: -- > modem.cdma.meid : -- > modem.cdma.esn: -- > modem.cdma.sid: -- > modem.cdma.nid: -- > modem.cdma.cdma1x-registration-state : -- > modem.cdma.evdo-registration-state: -- > modem.cdma.activation-state : -- > modem.generic.sim : > /org/freedesktop/ModemManager1/SIM/0 > modem.generic.bearers.length : 1 > modem.generic.bearers.value[1]: > /org/freedesktop/ModemManager1/Bearer/0 > > ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
[review] New key-value output in mmcli
Hey! See this MR: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/51 This enables a new "-K" (or longer, "--output-keyvalue") that allows all operations that print some kind of modem info (e.g. modem list, modem info, sim info, bearer info, sms info, 3gpp scan...) to be dumped in a simple "key-value" pair format. Along with these changes, I've also made some additional changes: deprecating ListBearers() method and removing the redundant --simple-status and --location-get-XXX actions. Worth noting: the original human-friendly output is more or less maintained but it is NOT equal to the old one. Applications (e.g. the openwrt integration) that were parsing that original output should switch to the new key-value pair output. Comments welcome! $ mmcli -L -K modem-list.length : 2 modem-list.value[1] : /org/freedesktop/ModemManager1/Modem/0 modem-list.value[2] : /org/freedesktop/ModemManager1/Modem/6 $ mmcli -m 0 -K modem.dbus-path : /org/freedesktop/ModemManager1/Modem/0 modem.generic.device-identifier : 1a48f1180f1fb0166d91f7b139d027136b59ba63 modem.generic.manufacturer: Sierra Wireless Inc. modem.generic.model : Sierra Wireless EM7345 4G LTE modem.generic.revision: FIH7160_V1.1_MODEM_01.1349.12 modem.generic.hardware-revision : XMM7160_V1.1_MBIM_GNSS_NAND_RE modem.generic.supported-capabilities.length : 1 modem.generic.supported-capabilities.value[1] : gsm-umts, lte modem.generic.current-capabilities.length : 1 modem.generic.current-capabilities.value[1] : gsm-umts, lte modem.generic.equipment-identifier: 013937003110648 modem.generic.device : /sys/devices/pci:00/:00:14.0/usb2/2-4 modem.generic.drivers.length : 1 modem.generic.drivers.value[1]: cdc_mbim modem.generic.plugin : Sierra modem.generic.primary-port: cdc-wdm0 modem.generic.ports.length: 2 modem.generic.ports.value[1] : cdc-wdm0 (mbim) modem.generic.ports.value[2] : wwan0 (net) modem.generic.own-numbers : -- modem.generic.unlock-required : -- modem.generic.unlock-retries.length : 1 modem.generic.unlock-retries.value[1] : sim-pin (3) modem.generic.state : connected modem.generic.state-failed-reason : -- modem.generic.power-state : on modem.generic.access-technologies.length : 1 modem.generic.access-technologies.value[1]: lte modem.generic.signal-quality.value: 22 modem.generic.signal-quality.recent : no modem.generic.supported-modes.length : 1 modem.generic.supported-modes.value[1]: allowed: 2g, 3g, 4g; preferred: none modem.generic.current-modes : allowed: 2g, 3g, 4g; preferred: none modem.generic.supported-bands : -- modem.generic.current-bands : -- modem.generic.supported-ip-families.length: 3 modem.generic.supported-ip-families.value[1] : ipv4 modem.generic.supported-ip-families.value[2] : ipv6 modem.generic.supported-ip-families.value[3] : ipv4v6 modem.3gpp.imei : 013937003110222 modem.3gpp.enabled-locks.length : 1 modem.3gpp.enabled-locks.value[1] : fixed-dialing modem.3gpp.operator-code : 21407 modem.3gpp.operator-name : Movistar modem.3gpp.registration-state : home modem.3gpp.eps-ue-mode-operation : -- modem.3gpp.pco: -- modem.cdma.meid : -- modem.cdma.esn: -- modem.cdma.sid: -- modem.cdma.nid: -- modem.cdma.cdma1x-registration-state : -- modem.cdma.evdo-registration-state: -- modem.cdma.activation-state : -- modem.generic.sim : /org/freedesktop/ModemManager1/SIM/0 modem.generic.bearers.length : 1 modem.generic.bearers.value[1]: /org/freedesktop/ModemManager1/Bearer/0 -- Aleksander https://aleksander.es ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
