Re: LE910 (used with qmi generic) not working anymore with 1.6-rc2

2016-04-08 Thread Aleksander Morgado
On Fri, Apr 8, 2016 at 3:35 PM, Daniele Palmas  wrote:
>> All these could very well be due to the issue fixed in this commit:
>> https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=8fee9a99f065b845bd0a9915c8777e6ac60a67b2
>>
>> That commit is 1.6-rc2 already, and you say the issue is still seen in
>> 1.6-rc2, right? Just want to make it sure.
>
> Sorry, previously I replied only to Aleksander.
>
>
> I did another log with version 1.6-rc2 (1.5.991) and le910 attached:
>
> http://pastebin.com/3pmd8sNU
>
> This version does not fail with no modem attached.

Thanks, I'm preparing a new patch now.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: LE910 (used with qmi generic) not working anymore with 1.6-rc2

2016-04-08 Thread Aleksander Morgado
On Fri, Apr 8, 2016 at 2:20 PM, Daniele Palmas  wrote:
> the error seems to appear also with no modem attached.
>
> I have the following logs:
>
> commit: 1939c5ace50240127276efacec5c7f166483bb79
> no modem attached
> http://pastebin.com/LysiMzLz
>
> commit: 1939c5ace50240127276efacec5c7f166483bb79
> le910 attached
> mm_1939c5ace50240127276efacec5c7f166483bb79_le910
> http://pastebin.com/qsLfw1st
>
> commit: d9596587e294ffde715fb2a7ef877da9f903558a (port-serial: allow
> completions not in idle)
> le910 attached
> mm_d9596587e294ffde715fb2a7ef877da9f903558a_le910
> http://pastebin.com/GQKBHZqe

All these could very well be due to the issue fixed in this commit:
https://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=8fee9a99f065b845bd0a9915c8777e6ac60a67b2

That commit is 1.6-rc2 already, and you say the issue is still seen in
1.6-rc2, right? Just want to make it sure.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: LE910 (used with qmi generic) not working anymore with 1.6-rc2

2016-04-08 Thread Daniele Palmas
Hi Aleksander,

2016-04-08 13:11 GMT+02:00 Aleksander Morgado :
> On Thu, Apr 7, 2016 at 12:57 PM, Daniele Palmas  wrote:
>> The error seems to be triggered by this:
>>
>> ModemManagere[30896]:  [1460023605.770238]
>> [mm-port-probe-at.c:43] mm_port_probe_response_processor_is_at():
>> Parsing AT got: 'Sending command failed: 'Resource temporarily
>> unavailable''
>>
>> The following patch seems to solve the issue, but I'm not sure it is
>> the right approach.
>>
>> ---
>>  src/mm-port-probe-at.c | 5 -
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mm-port-probe-at.c b/src/mm-port-probe-at.c
>> index 10cce9e..b9696f1 100644
>> --- a/src/mm-port-probe-at.c
>> +++ b/src/mm-port-probe-at.c
>> @@ -46,7 +46,10 @@ mm_port_probe_response_processor_is_at (const gchar 
>> *command,
>>   * they will just go on to the next command. */
>>  if (g_error_matches (error,
>>   MM_SERIAL_ERROR,
>> - MM_SERIAL_ERROR_RESPONSE_TIMEOUT)) {
>> + MM_SERIAL_ERROR_RESPONSE_TIMEOUT) ||
>> +g_error_matches (error,
>> + MM_SERIAL_ERROR,
>> + MM_SERIAL_ERROR_SEND_FAILED)) {
>>  return FALSE;
>>  }
>
> Any chance you can get the MM logs before commit
> 1939c5ace50240127276efacec5c7f166483bb79? That commit changed when the
> serial completion was done (idle or not in idle); I believe your patch
> is nowhere related to that issue, so that's why I ask. It is an
> important thing to fix, we should get it right.
>

the error seems to appear also with no modem attached.

I have the following logs:

commit: 1939c5ace50240127276efacec5c7f166483bb79
no modem attached
http://pastebin.com/LysiMzLz

commit: 1939c5ace50240127276efacec5c7f166483bb79
le910 attached
mm_1939c5ace50240127276efacec5c7f166483bb79_le910
http://pastebin.com/qsLfw1st

commit: d9596587e294ffde715fb2a7ef877da9f903558a (port-serial: allow
completions not in idle)
le910 attached
mm_d9596587e294ffde715fb2a7ef877da9f903558a_le910
http://pastebin.com/GQKBHZqe

Thanks,
Daniele

> --
> Aleksander
> https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: LE910 (used with qmi generic) not working anymore with 1.6-rc2

2016-04-08 Thread Aleksander Morgado
On Thu, Apr 7, 2016 at 12:57 PM, Daniele Palmas  wrote:
> The error seems to be triggered by this:
>
> ModemManagere[30896]:  [1460023605.770238]
> [mm-port-probe-at.c:43] mm_port_probe_response_processor_is_at():
> Parsing AT got: 'Sending command failed: 'Resource temporarily
> unavailable''
>
> The following patch seems to solve the issue, but I'm not sure it is
> the right approach.
>
> ---
>  src/mm-port-probe-at.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/mm-port-probe-at.c b/src/mm-port-probe-at.c
> index 10cce9e..b9696f1 100644
> --- a/src/mm-port-probe-at.c
> +++ b/src/mm-port-probe-at.c
> @@ -46,7 +46,10 @@ mm_port_probe_response_processor_is_at (const gchar 
> *command,
>   * they will just go on to the next command. */
>  if (g_error_matches (error,
>   MM_SERIAL_ERROR,
> - MM_SERIAL_ERROR_RESPONSE_TIMEOUT)) {
> + MM_SERIAL_ERROR_RESPONSE_TIMEOUT) ||
> +g_error_matches (error,
> + MM_SERIAL_ERROR,
> + MM_SERIAL_ERROR_SEND_FAILED)) {
>  return FALSE;
>  }

Any chance you can get the MM logs before commit
1939c5ace50240127276efacec5c7f166483bb79? That commit changed when the
serial completion was done (idle or not in idle); I believe your patch
is nowhere related to that issue, so that's why I ask. It is an
important thing to fix, we should get it right.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: LE910 (used with qmi generic) not working anymore with 1.6-rc2

2016-04-07 Thread Daniele Palmas
The error seems to be triggered by this:

ModemManagere[30896]:  [1460023605.770238]
[mm-port-probe-at.c:43] mm_port_probe_response_processor_is_at():
Parsing AT got: 'Sending command failed: 'Resource temporarily
unavailable''

The following patch seems to solve the issue, but I'm not sure it is
the right approach.

---
 src/mm-port-probe-at.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/mm-port-probe-at.c b/src/mm-port-probe-at.c
index 10cce9e..b9696f1 100644
--- a/src/mm-port-probe-at.c
+++ b/src/mm-port-probe-at.c
@@ -46,7 +46,10 @@ mm_port_probe_response_processor_is_at (const gchar *command,
  * they will just go on to the next command. */
 if (g_error_matches (error,
  MM_SERIAL_ERROR,
- MM_SERIAL_ERROR_RESPONSE_TIMEOUT)) {
+ MM_SERIAL_ERROR_RESPONSE_TIMEOUT) ||
+g_error_matches (error,
+ MM_SERIAL_ERROR,
+ MM_SERIAL_ERROR_SEND_FAILED)) {
 return FALSE;
 }

-- 
2.7.0


Regards,
Daniele

2016-04-07 9:24 GMT+02:00 Daniele Palmas :
> Hi all,
>
> LE910 (used with qmi generic) seems not to be working anymore with
> 1.6-rc2. Last lines of the log are:
>
> ModemManagere[21197]:  [1460013743.234084]
> [mm-plugin-manager.c:434] port_context_defer_until_suggested():
> [plugin manager] task 2,wwan0: completed, got suggested plugin
> (Generic)
> ModemManagere[21197]:  [1460013743.234090]
> [mm-plugin-manager.c:265] port_context_complete(): [plugin manager]
> task 2,wwan0: finished in '1.621374' seconds
> ModemManagere[21197]:  [1460013743.234096]
> [mm-plugin-manager.c:966] device_context_set_best_plugin(): [plugin
> manager] task 2,wwan0: best plugin matches device reported one:
> Generic
> ModemManagere[21197]:  [1460013743.234102]
> [mm-plugin-manager.c:1005] device_context_continue(): [plugin Manager]
> task 2: still 5 running probes (5 active): ttyUSB1, ttyUSB2, ttyUSB0,
> ttyUSB4, ttyUSB3
> ModemManagere[21197]:  [1460013744.112978]
> [mm-plugin-manager.c:1058] device_context_min_probing_time_elapsed():
> [plugin manager] task 2: min probing time elapsed
> ModemManagere[21197]:  [1460013744.113019]
> [mm-plugin-manager.c:1005] device_context_continue(): [plugin Manager]
> task 2: still 5 running probes (5 active): ttyUSB1, ttyUSB2, ttyUSB0,
> ttyUSB4, ttyUSB3
> ModemManagere[21197]:  [1460013744.230433]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB3): <-- '+CME
> ERROR: 100'
> ModemManagere[21197]:  [1460013744.230539]
> [mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure
> code 100: Unknown error
> ModemManagere[21197]:  [1460013744.230584]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): <-- '+CME
> ERROR: 100'
> ModemManagere[21197]:  [1460013744.230594]
> [mm-serial-parsers.c:364] mm_serial_parser_v1_parse(): Got failure
> code 100: Unknown error
> ModemManagere[21197]:  [1460013744.230627]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB3): --> 'AT'
> ModemManagere[21197]:  [1460013744.230639]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): --> 'AT'
> ModemManagere[21197]:  [1460013744.432433]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): <--
> 'OK'
> ModemManagere[21197]:  [1460013744.432588]
> [mm-port-probe.c:109] mm_port_probe_set_result_at(): (tty/ttyUSB2)
> port is AT-capable
> ModemManagere[21197]:  [1460013744.432678]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB3): <--
> 'OK'
> ModemManagere[21197]:  [1460013744.432725]
> [mm-port-probe.c:109] mm_port_probe_set_result_at(): (tty/ttyUSB3)
> port is AT-capable
> ModemManagere[21197]:  [1460013744.432808]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): --> 'AT+CGMI'
> ModemManagere[21197]:  [1460013744.432849]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB3): --> 'AT+CGMI'
> ModemManagere[21197]:  [1460013745.137141]
> [mm-port-serial-at.c:459] debug_log(): (ttyUSB2): <--
> 'TelitOK'
> ModemManagere[21197]:  [1460013745.137280]
> [mm-port-probe.c:136] mm_port_probe_set_result_at_vendor():
> (tty/ttyUSB2) vendor probing finished
> ModemManagere[21197]:  [1460013745.137347] [mm-plugin.c:479]
> apply_post_probing_filters(): (Cinterion) [ttyUSB2] filtered by vendor
> strings
> ModemManagere[21197]:  [1460013745.137367]
> [mm-plugin-manager.c:519] port_context_next(): [plugin manager] task
> 2,ttyUSB2: checking with plugin 'Generic'
> ModemManagere[21197]:  [1460013745.137397] [mm-plugin.c:804]
> mm_plugin_supports_port(): (Generic) [ttyUSB2] probe required: 'at,
> qcdm'
> ModemManagere[21197]:  [1460013745.137413]
> [mm-port-probe.c:1348] mm_port_probe_run(): (tty/ttyUSB2) port probing
> finished: no more probings needed
> ModemManagere[21197]:  [1460013745.137449]
> [mm-port-serial.c:1354] _close_internal(): (ttyUSB2) device open count
> is 0 (close)
> ModemManagere[21197]:  [1460013745.137466]
> [mm-port-serial.c:1370] _close_internal(): (ttyUSB2) closing serial
> port...
>