Re: mod_perl 1.99 and Apache::compat
On Sun, 7 Apr 2002, Dave Rolsky wrote: > On Sun, 7 Apr 2002, Dave Rolsky wrote: > > > I also found a few tiny bugs in Apache::compat. > > > > - The read() call in send_fd_length needs to be CORE::read. > > > > - In the last elsif in size_string, the size variable is missing its > > dollar sign ($). > > Here's a patch: thanks, applied. figures the 1 file we didn't have 'use strict' in. that's in there now too, which caught another bug in send_fd_length.
Re: mod_perl 1.99 and Apache::compat
On Sun, 7 Apr 2002, Dave Rolsky wrote: > I also found a few tiny bugs in Apache::compat. > > - The read() call in send_fd_length needs to be CORE::read. > > - In the last elsif in size_string, the size variable is missing its > dollar sign ($). Here's a patch: --- compat.pm.~1.35.~ Sat Mar 23 20:38:01 2002 +++ compat.pm Sun Apr 7 14:19:46 2002 @@ -259,7 +259,7 @@ $len = IOBUFSIZE; } -while (read($fh, $buff, $len)) { +while (CORE::read($fh, $buff, $len)) { $total_bytes_sent += $r->puts($buff); } @@ -369,7 +369,7 @@ elsif ($size < 1048576) { $size = sprintf "%4dk", ($size + 512) / 1024; } -elsif (size < 103809024) { +elsif ($size < 103809024) { $size = sprintf "%4.1fM", $size / 1048576.0; } else {
mod_perl 1.99 and Apache::compat
Well, here be a bug report I compiled Apache 2.0.35 with mod_perl 1.99 as a DSO. The server will start just fine with that. I'm running on GNU/Linux with Perl 5.6.1. If I add this: PerlModule Apache2 PerlModule Apache::compat The server simply will not start. If I comment out all the 'use' statements, except for mod_perl and Symbol, from Apache/compat.pm, then the server starts. If I load all the modules I just commented out via PerlModule in the config file and I _don't_ load Apache::compat, the server starts. If I load all the modules I commented out and try to load Apache::compat (with those use statements still commented out), the server will not start. I also found a few tiny bugs in Apache::compat. - The read() call in send_fd_length needs to be CORE::read. - In the last elsif in size_string, the size variable is missing its dollar sign ($). -dave /*== www.urth.org we await the New Sun ==*/