cvs commit: modperl Makefile.PL

2003-02-20 Thread randyk
randyk  2003/02/20 15:13:34

  Modified:.Makefile.PL
  Log:
  Reviewed by:  stas
  
  remove commented-out lines from previous commits.
  
  Revision  ChangesPath
  1.209 +0 -2  modperl/Makefile.PL
  
  Index: Makefile.PL
  ===
  RCS file: /home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.208
  retrieving revision 1.209
  diff -u -r1.208 -r1.209
  --- Makefile.PL   20 Feb 2003 16:42:46 -  1.208
  +++ Makefile.PL   20 Feb 2003 23:13:33 -  1.209
  @@ -792,7 +792,6 @@
"(need 1.2.0 or higher)";
   }
   
  -#$PERL_SECTIONS = $PERL_SSI = 0 if $Is_Win32;
   $PERL_SSI = 0 if $Is_Win32;
   unless ($Is_Win32) {
 for (qw(PERL_SECTIONS PERL_SSI), keys %experimental) {
  @@ -1602,7 +1601,6 @@
my $to = '$(INST_ARCHLIB)/' . "auto/Apache/include/$_";
unless ($self->{PM}->{$from}) {
$self->{PM}->{$from} = $to;
  -#system "$Config{touch} $from";
my @args = ($Config{perlpath}, '-MExtUtils::Command', 
'-e', 'touch', $from);
system(@args) == 0
  
  
  


Re: cvs commit: modperl Makefile.PL

2003-02-20 Thread Stas Bekman
[EMAIL PROTECTED] wrote:
randyk  2003/02/20 08:42:46

  Modified:.Makefile.PL
  Log:
  Reviewed by:	stas
  
  Use Perl's touch(), in case a system touch() isn't available.
  
  Revision  ChangesPath
  1.208 +5 -1  modperl/Makefile.PL
  
  Index: Makefile.PL
  ===
  RCS file: /home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.207
  retrieving revision 1.208
  diff -u -r1.207 -r1.208
  --- Makefile.PL	20 Feb 2003 16:34:35 -	1.207
  +++ Makefile.PL	20 Feb 2003 16:42:46 -	1.208
  @@ -1602,7 +1602,11 @@
   	my $to = '$(INST_ARCHLIB)/' . "auto/Apache/include/$_";
   	unless ($self->{PM}->{$from}) {
   	$self->{PM}->{$from} = $to;
  -	system "$Config{touch} $from";
  +#	system "$Config{touch} $from";
  +	my @args = ($Config{perlpath}, '-MExtUtils::Command', 
  +		'-e', 'touch', $from);
  +	system(@args) == 0
  +	or die "system @args failed: $?";
   	}
   }
since we use cvs, we don't commented out snippets of the older code that was 
replaced with the new one. If in the future we realize the the recent change 
broke something we can always revert to the previous version. So please remove 
this commented out line and the same in your other commit on PERL_SECTIONS. 
Thanks.

BTW, in case you were wondering. the style guide doesn't apply to the modperl 
(1.0) rep, since it's all a mess. We try to keep it clean for 2.0 from the 
very beginning.

__
Stas BekmanJAm_pH --> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


cvs commit: modperl Makefile.PL

2003-02-20 Thread randyk
randyk  2003/02/20 08:42:46

  Modified:.Makefile.PL
  Log:
  Reviewed by:  stas
  
  Use Perl's touch(), in case a system touch() isn't available.
  
  Revision  ChangesPath
  1.208 +5 -1  modperl/Makefile.PL
  
  Index: Makefile.PL
  ===
  RCS file: /home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.207
  retrieving revision 1.208
  diff -u -r1.207 -r1.208
  --- Makefile.PL   20 Feb 2003 16:34:35 -  1.207
  +++ Makefile.PL   20 Feb 2003 16:42:46 -  1.208
  @@ -1602,7 +1602,11 @@
my $to = '$(INST_ARCHLIB)/' . "auto/Apache/include/$_";
unless ($self->{PM}->{$from}) {
$self->{PM}->{$from} = $to;
  - system "$Config{touch} $from";
  +#system "$Config{touch} $from";
  + my @args = ($Config{perlpath}, '-MExtUtils::Command', 
  + '-e', 'touch', $from);
  + system(@args) == 0
  + or die "system @args failed: $?";
}
   }
   
  
  
  



cvs commit: modperl Makefile.PL

2003-02-20 Thread randyk
randyk  2003/02/20 08:34:35

  Modified:.Makefile.PL
  Log:
  Reviewed by:  stas
  
  Enable PERL_SECTIONS for Win32
  
  Revision  ChangesPath
  1.207 +2 -1  modperl/Makefile.PL
  
  Index: Makefile.PL
  ===
  RCS file: /home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.206
  retrieving revision 1.207
  diff -u -r1.206 -r1.207
  --- Makefile.PL   20 Feb 2003 16:28:35 -  1.206
  +++ Makefile.PL   20 Feb 2003 16:34:35 -  1.207
  @@ -792,7 +792,8 @@
"(need 1.2.0 or higher)";
   }
   
  -$PERL_SECTIONS = $PERL_SSI = 0 if $Is_Win32;
  +#$PERL_SECTIONS = $PERL_SSI = 0 if $Is_Win32;
  +$PERL_SSI = 0 if $Is_Win32;
   unless ($Is_Win32) {
 for (qw(PERL_SECTIONS PERL_SSI), keys %experimental) {
$k = $_;
  
  
  



cvs commit: modperl Makefile.PL

2003-02-20 Thread randyk
randyk  2003/02/20 08:28:35

  Modified:.Makefile.PL
  Log:
  Reviewed by:  stas
  
  Enable PERL_DIRECTIVE_HANLDERS for Win32
  
  Revision  ChangesPath
  1.206 +1 -0  modperl/Makefile.PL
  
  Index: Makefile.PL
  ===
  RCS file: /home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.205
  retrieving revision 1.206
  diff -u -r1.205 -r1.206
  --- Makefile.PL   23 Jan 2003 04:25:04 -  1.205
  +++ Makefile.PL   20 Feb 2003 16:28:35 -  1.206
  @@ -479,6 +479,7 @@
   
   if($Is_Win32) {
   $NO_HTTPD = 1;
  +$PERL_DIRECTIVE_HANDLERS = 1;
   }