Re: cvs commit: modperl STATUS
[EMAIL PROTECTED] wrote:
> geoff 2002/08/07 12:39:00
>
> Modified:.STATUS
> Log:
> added bug report for print not looking at $\
the below patch seems to work, though I need to trace through the
rwrite_neg_trace() stuff to see what it actually does :) no
guarantees here, just some fiddling.
at any rate, if somebody who knows more about the perl API and XS
wants to use this as a starting point, feel free. I'm still unsure
about whether we want to implement this at all, but I had some free
time and...
--Geoff
Index: Apache.xs
===
RCS file: /home/cvspublic/modperl/src/modules/perl/Apache.xs,v
retrieving revision 1.125
diff -u -r1.125 Apache.xs
--- Apache.xs 6 Jul 2001 20:33:35 - 1.125
+++ Apache.xs 9 Aug 2002 17:44:00 -
@@ -1160,6 +1160,7 @@
PREINIT:
int i;
+int sent = 0;
char * buffer;
STRLEN len;
@@ -1170,7 +1171,6 @@
XSRETURN_IV(0);
for(i = 1; i <= items - 1; i++) {
- int sent = 0;
SV *sv = SvROK(ST(i)) && (SvTYPE(SvRV(ST(i))) == SVt_PV) ?
(SV*)SvRV(ST(i)) : ST(i);
buffer = SvPV(sv, len);
@@ -1197,6 +1197,13 @@
RETVAL += sent;
#endif
}
+
+buffer = SvPV(GvSV(gv_fetchpv("\\", TRUE, SVt_PV)), len);
+
+if((sent = rwrite(buffer, len, r)) < 0) {
+rwrite_neg_trace(r);
+}
+RETVAL += sent;
OUTPUT:
RETVAL
cvs commit: modperl STATUS
geoff 02/05/14 11:05:34 Modified:.STATUS Log: more bug reports via stas... Revision ChangesPath 1.18 +10 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- STATUS14 May 2002 11:50:48 - 1.17 +++ STATUS14 May 2002 18:05:34 - 1.18 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/05/14 11:50:48 $] + Last modified at [$Date: 2002/05/14 18:05:34 $] Release: @@ -102,6 +102,15 @@ it would be much better if the Apache::Registry will do that Report: ? Status: + +* Apache::DProf seg-fault via Devel::DProf's prof_mark() +Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101923951812332&w=2 + Status: + +* collisions between Apache::Status and English.pm +Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=102096856215178&w=2 + Status: + Open Issues or Core Enhancements:
cvs commit: modperl STATUS
geoff 02/05/14 04:50:49 Modified:.STATUS Log: added Apache::Status enhancement request (forwarded from Stas) Revision ChangesPath 1.17 +9 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- STATUS22 Apr 2002 19:50:40 - 1.16 +++ STATUS14 May 2002 11:50:48 - 1.17 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/04/22 19:50:40 $] + Last modified at [$Date: 2002/05/14 11:50:48 $] Release: @@ -24,6 +24,14 @@ just not enough things or Registry specific things? --Geoff patch available at http://marc.theaimsgroup.com/?l=apache-modperl&m=101862462900504&w=2 + +* Apache::Status allows standard keys to be overridden +Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2 + Status: + I'm not sure I understand this one, since the patch seems to do + the opposite of what the user is asking for --Geoff + patch available at + http://marc.theaimsgroup.com/?l=apache-modperl&m=101559176217056&w=2 Needs Patch or Further Investigation
cvs commit: modperl STATUS
geoff 02/04/22 12:50:40
Modified:.STATUS
Log:
add notes('error-notes') enhancement report and patch to STATUS
Revision ChangesPath
1.16 +10 -1 modperl/STATUS
Index: STATUS
===
RCS file: /home/cvs/modperl/STATUS,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- STATUS14 Apr 2002 17:25:03 - 1.15
+++ STATUS22 Apr 2002 19:50:40 - 1.16
@@ -1,5 +1,5 @@
mod_perl 1.3 STATUS:
- Last modified at [$Date: 2002/04/14 17:25:03 $]
+ Last modified at [$Date: 2002/04/22 19:50:40 $]
Release:
@@ -16,6 +16,15 @@
patch available at
http://marc.theaimsgroup.com/?l=apache-modperl&m=101729204503165&w=2
+* implement notes('error-notes') in Registry a la mod_cgo
+Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101862462900504&w=2
+ Status:
+ I haven't had the chance to investigate this thoroughly, but
+ mod_perl does seem to be setting error-notes for some things. maybe
+ just not enough things or Registry specific things? --Geoff
+ patch available at
+ http://marc.theaimsgroup.com/?l=apache-modperl&m=101862462900504&w=2
+
Needs Patch or Further Investigation
cvs commit: modperl STATUS
stas02/04/14 10:25:03 Modified:.STATUS Log: need to resolve the URI/LWP bad combinations issue. Revision ChangesPath 1.15 +10 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- STATUS2 Apr 2002 15:10:02 - 1.14 +++ STATUS14 Apr 2002 17:25:03 - 1.15 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/04/02 15:10:02 $] + Last modified at [$Date: 2002/04/14 17:25:03 $] Release: @@ -18,6 +18,15 @@ Needs Patch or Further Investigation + +* make test fails when a wrong combination of URI and LWP are + installed. (e.g. lwp 5.64 and URI 1.09). LWP's Makefile.PL + requires the right URI version, but certain binary distributors + miss this requirement and distribute LWP without making a + dependency on the right version of the URI package +Report: many reports in the last year. +Status: ??? +Suggestion: require libwww-perl 5.64 and URI 1.1 * two identical directives in configuration Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97449481013350&w=2
cvs commit: modperl STATUS
geoff 02/04/02 07:10:02 Modified:.STATUS Log: add Win32 specific build problem, with a pointer to Randy's patch Revision ChangesPath 1.14 +8 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- STATUS24 Mar 2002 23:54:32 - 1.13 +++ STATUS2 Apr 2002 15:10:02 - 1.14 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/24 23:54:32 $] + Last modified at [$Date: 2002/04/02 15:10:02 $] Release: @@ -9,6 +9,13 @@ Available Patches: + +* Win32 build problems with spaces in shell arguments +Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101681938513575&w=2 + Status: + patch available at + http://marc.theaimsgroup.com/?l=apache-modperl&m=101729204503165&w=2 + Needs Patch or Further Investigation
cvs commit: modperl STATUS
dougm 02/03/24 15:54:32
Modified:.STATUS
Log:
various updates
Revision ChangesPath
1.13 +127 -98 modperl/STATUS
Index: STATUS
===
RCS file: /home/cvs/modperl/STATUS,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- STATUS24 Mar 2002 23:01:33 - 1.12
+++ STATUS24 Mar 2002 23:54:32 - 1.13
@@ -1,59 +1,28 @@
mod_perl 1.3 STATUS:
- Last modified at [$Date: 2002/03/24 23:01:33 $]
+ Last modified at [$Date: 2002/03/24 23:54:32 $]
Release:
- 1.26-dev: In development.
- 1.25: Released July 11, 2001.
+ 1.27-dev: In development.
+ 1.26: Released July 11, 2001.
Available Patches:
-* $r->args parsing of one=&two=2
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98018719907031&w=2
- Status:
- patch available at
- http://marc.theaimsgroup.com/?l=apache-modperl&m=98048943129379&w=2
+Needs Patch or Further Investigation
* two identical directives in configuration
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97449481013350&w=2
Status:
doc patch at
http://marc.theaimsgroup.com/?l=apache-modperl&m=97450363501652&w=2
-
-* $r->finfo problem with HTML::Mason::ApacheHandler
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=96854561311519&w=2
- Status:
- may be fixed with
- http://marc.theaimsgroup.com/?l=apache-modperl&m=96869790426565&w=2
-
-* get/set handlers issues
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=95721313917562&w=2
- Status:
- patch available
- http://perl.apache.org/~dougm/set_handlers.pat
-
-* Apache::test
-Report:
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=98278446807561&w=2
- Status:
- patch available
-
-Needs Patch or Further Investigation
+ however: this documented feature should be supported.
* readdir() broken on linux with glibc 2.2
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98824089613574&w=2
Status:
+does anybody have an example to reproduce the bug?
-* SERVER_MERGE and DIR_MERGE
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97351976714878&w=2
- Status:
- The require() part may be legitimate. personally, I never
- understood the DIR_CREATE happening before SERVER_CREATE
- either, but it doesn't seem to affect anything. the double
- DIR_MERGE is just a misunderstanding on Andy's part and is
- a result of how Apache handles before and
- after translation. --Geoff
-
* warn() going to the wrong log
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98190005604037&w=2
Status:
@@ -61,6 +30,15 @@
in a vhost when the vhost relies on the ErrorLog from the main
server --Geoff
+ s->error_fname == NULL is expected, see ap_open_logs(), only
+ s->error_log is inherited.
+
+ i would expect stderr to only ever be opened to the main
+ server log at startup. otherwise, we'd need to redirect stderr at the
+ start of every request and restore it at the end. seems expensive.
+ i would be suprised if this every worked as matt expected it
+ to. -dougm
+
* segfaults with DBI->connect (mysql)
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=96392180616185&w=2
Status:
@@ -69,10 +47,6 @@
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99063926111686&w=2
Status:
-* Apache->server->register_cleanup
-Report: ?
- Status:
-
* Apache->request(bless {r => $r}, 'My::Apache')
Report:
http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=98600785703290&w=2
Status:
@@ -81,10 +55,6 @@
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=94792974200198&w=2
Status:
-* recursion triggered by internal_redirect() called by a pushed handler
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=94792974200198&w=2
- Status:
-
* IPC::Open3 issues
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98839218229712&w=2
Status:
@@ -93,43 +63,6 @@
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97934624332223&w=2
Status:
-* Apache::Status problems?..CGI::Cookie, (dont want no CGI.pm)
-Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97913833521354&w=2
- Status:
-
-* Gerald's report of Embperl/sub-request/print breakage
-Repor
cvs commit: modperl STATUS
dougm 02/03/24 13:00:21 Modified:.STATUS Log: remove win32 item Revision ChangesPath 1.8 +1 -6 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- STATUS24 Mar 2002 20:53:41 - 1.7 +++ STATUS24 Mar 2002 21:00:20 - 1.8 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/24 20:53:41 $] + Last modified at [$Date: 2002/03/24 21:00:20 $] Release: @@ -20,11 +20,6 @@ Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97449481013350&w=2 Status: doc patch at http://marc.theaimsgroup.com/?l=apache-modperl&m=97450363501652&w=2 - -* mod_perl.h issues for Win32 -Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=101253855721619&w=2 - Status: - patch available * Apache::Utils::escape_html issues Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101180404809059&w=2
cvs commit: modperl STATUS
dougm 02/03/24 12:53:41 Modified:.STATUS Log: address the print() dereferencing issue Revision ChangesPath 1.7 +14 -7 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- STATUS24 Mar 2002 20:45:17 - 1.6 +++ STATUS24 Mar 2002 20:53:41 - 1.7 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/24 20:45:17 $] + Last modified at [$Date: 2002/03/24 20:53:41 $] Release: @@ -21,12 +21,6 @@ Status: doc patch at http://marc.theaimsgroup.com/?l=apache-modperl&m=97450363501652&w=2 -* PVIV issues -Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99905070209305&w=2 - Status: - patch available -http://marc.theaimsgroup.com/?l=apache-modperl&m=9116330145&w=2 - * mod_perl.h issues for Win32 Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=101253855721619&w=2 Status: @@ -231,3 +225,16 @@ production environment, as it adds quite a bit of bloat * docs: update CREDITS, cleanup install docs + +Patches unlikely to be applied: + +* print() dereferencing issues +Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99905070209305&w=2 + Status: + patch available +http://marc.theaimsgroup.com/?l=apache-modperl&m=9116330145&w=2 + + the feature of print() dereferencing scalars should be deprecated. + therefor, i don't think this patch should be applied as it + would introduce overhead to support a deprecated feature. + user should simply dereference themselves, print $$foo; -dougm
cvs commit: modperl STATUS
geoff 02/03/22 12:03:34 Modified:.STATUS Log: add reference to PERL5LIB patch Revision ChangesPath 1.2 +6 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- STATUS2 Mar 2002 18:09:54 - 1.1 +++ STATUS22 Mar 2002 20:03:34 - 1.2 @@ -1,5 +1,5 @@ mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/02 18:09:54 $] + Last modified at [$Date: 2002/03/22 20:03:34 $] Release: @@ -78,6 +78,11 @@ * Apache::test Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=98278446807561&w=2 Status: + patch available + +* PERL5LIB should unshift @INC instead of push +Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=100434522809036&w=2 +Status: patch available
cvs commit: modperl STATUS ToDo
geoff 02/03/02 10:09:54 Added: .STATUS Removed: .ToDo Log: exchanged the old ToDo for the new STATUS file Reviewed by: dougm Revision ChangesPath 1.1 modperl/STATUS Index: STATUS === mod_perl 1.3 STATUS: Last modified at [$Date: 2002/03/02 18:09:54 $] Release: 1.26-dev: In development. 1.25: Released July 11, 2001. Available Patches: * $r->args parsing of one=&two=2 Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98018719907031&w=2 Status: patch available at http://marc.theaimsgroup.com/?l=apache-modperl&m=98048943129379&w=2 * two identical directives in configuration Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97449481013350&w=2 Status: doc patch at http://marc.theaimsgroup.com/?l=apache-modperl&m=97450363501652&w=2 * PerlSetEnv scoping Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99148497206388&w=2 Status: may be fixed here http://marc.theaimsgroup.com/?l=apache-modperl&m=99473571809129&w=2 but that patch has this issue (I think) http://marc.theaimsgroup.com/?l=apache-modperl&m=99565226811557&w=2 --Geoff * %LocationMatch bug Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98260537428737&w=2 Status: may be fixed here http://marc.theaimsgroup.com/?l=apache-modperl&m=101366182205497&w=2 * PVIV issues Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99905070209305&w=2 Status: patch available http://marc.theaimsgroup.com/?l=apache-modperl&m=9116330145&w=2 * mod_perl.h issues for Win32 Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=101253855721619&w=2 Status: patch available * Apache::Utils::escape_html issues Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=101180404809059&w=2 Status: "patch" available http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=101188287032621&w=2 * Apache::RegistryNG issues Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=101240123609773&w=2 Status: patch available * vanishing symbol tables Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=100820262006934&w=2 Status: patch available * $r->finfo problem with HTML::Mason::ApacheHandler Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=96854561311519&w=2 Status: may be fixed with http://marc.theaimsgroup.com/?l=apache-modperl&m=96869790426565&w=2 * get/set handlers issues Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=95721313917562&w=2 Status: patch available http://perl.apache.org/~dougm/set_handlers.pat * Apache::test Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=98278446807561&w=2 Status: patch available Needs Patch or Further Investigation * readdir() broken on linux with glibc 2.2 Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98824089613574&w=2 Status: * SERVER_MERGE and DIR_MERGE Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=97351976714878&w=2 Status: The require() part may be legitimate. personally, I never understood the DIR_CREATE happening before SERVER_CREATE either, but it doesn't seem to affect anything. the double DIR_MERGE is just a misunderstanding on Andy's part and is a result of how Apache handles before and after translation. --Geoff * warn() going to the wrong log Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98190005604037&w=2 Status: coincidentially, I've noticed that s->error_fname is not populated in a vhost when the vhost relies on the ErrorLog from the main server --Geoff * segfaults with DBI->connect (mysql) Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=96392180616185&w=2 Status: * revisit send_http_header and r->status Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99063926111686&w=2 Status: * Apache->server->register_cleanup Report: ? Status: * bleedperl TIEHANDLE issues? Report: http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=99909095916498&w=2 Status: * bleedperl AUTOLOAD XSUB issues Report: htt
