Re: cvs commit: modperl Makefile.PL

2003-07-10 Thread Philippe M. Chiasson
If it fixes a reported bug, it should get logged in Changes, IMO

On Wed, 2003-07-09 at 09:16, [EMAIL PROTECTED] wrote:
> randyk  2003/07/08 18:16:53
> 
>   Modified:.Makefile.PL
>   Log:
>   For Win32,
>   - copy mod_perl.lib into Apache/libexec directory, if it exists
>   - keep drive letter in dsp (fixes bug reported by DH <[EMAIL PROTECTED]>)
>   
>   Revision  ChangesPath
>   1.215 +7 -2  modperl/Makefile.PL
>   
>   Index: Makefile.PL
>   ===
>   RCS file: /home/cvs/modperl/Makefile.PL,v
>   retrieving revision 1.214
>   retrieving revision 1.215
>   diff -u -r1.214 -r1.215
>   --- Makefile.PL 2 Jul 2003 15:57:53 -   1.214
>   +++ Makefile.PL 9 Jul 2003 01:16:52 -   1.215
>   @@ -370,7 +370,7 @@
>(-d "$fixed_apsrc/src/include" ? $fixed_apsrc . '/src' :
> die "Cannot find the Apache include directory under $fixed_apsrc");
>  $win32_auto = 1;
>   -  if (not defined $win32_args{INSTALL_DLL}) {
>   +  unless ($win32_args{INSTALL_DLL}) {
>my $w32_ap_mod = $fixed_apsrc . '/modules';
>$win32_args{INSTALL_DLL} = $w32_ap_mod if -d $w32_ap_mod;
>  }
>   @@ -1371,6 +1371,12 @@
>   $win32_args{INSTALL_DLL} .
> ($win32_args{APACHE_VERS} < 1315 ?
>  '/ApacheModulePerl.dll' : '/mod_perl.so');
>   +if (-d "$win32_args{APACHE_SRC}/libexec") {
>   +  my $libexec = win32_fix_path($win32_args{APACHE_SRC}) . '/libexec';
>   +  $string .= sprintf qq{\n\t\$(CP) "%s" "%s"}, 
>   +"$win32_path{MODPERL_LIB}/mod_perl.lib", 
>   +  $libexec . '/mod_perl.lib';
>   +}
>  }
>  return $string;
>}
>   @@ -2236,7 +2242,6 @@
>sub win32_fix_path_dsp {
>  local $_ = shift;
>  tr!/!\\!;
>   -  s!^\w:!!;
>  return $_;
>}
>
>   
>   
>   
> 


signature.asc
Description: This is a digitally signed message part


cvs commit: modperl Changes

2003-07-10 Thread randyk
randyk  2003/07/10 10:07:18

  Modified:.Changes
  Log:
  Record recent Makefile.PL change to keep drive letters in dsp file.
  
  Revision  ChangesPath
  1.675 +4 -0  modperl/Changes
  
  Index: Changes
  ===
  RCS file: /home/cvs/modperl/Changes,v
  retrieving revision 1.674
  retrieving revision 1.675
  diff -u -r1.674 -r1.675
  --- Changes   6 Jul 2003 14:12:29 -   1.674
  +++ Changes   10 Jul 2003 17:07:18 -  1.675
  @@ -10,6 +10,10 @@
   
   =item 1.28_01-dev
   
  +For Win32, keep drive letters in mod_perl.dsp to fix bug, reported 
  +by DH <[EMAIL PROTECTED]>, when compiling mod_perl in
  +cases where Apache and Perl are on different drives [Randy Kobes]. 
  +
   Add workaround to define statcache in Apache.xs so that
   one can build on Win32 ActivePerl 8xx with LARGE_FILES
   support [Randy Kobes]