Re: Module-Starter's t/module-starter.t has skip_all

2008-07-26 Thread Ricardo SIGNES
* Shlomi Fish [EMAIL PROTECTED] [2008-07-25T15:50:12]
 {{
 use Test::More;
 plan skip_all = these tests must be completely rewritten;
 }}
 
 It also seems none of them test for the contents of the files, but only for 
 their existence.

These tests have *never* been used and were added by a patch that added other
features.  They are a total catastrophe, and saying that they need to be fixed
is missing the point.

We should have end-to-end tests, but do not.

 What can be done about it and when will it be fixed? I wanted to improve the 
 M-S support for software licences, but now it seems that I cannot add 
 regression tests for this task easily.

You can write end-to-end tests prior to adding that feature.  I realize this is
non-trivial.

For my part, I think the chances of my doing this work in the next year is
nearly zero.

-- 
rjbs


Module-Starter's t/module-starter.t has skip_all

2008-07-25 Thread Shlomi Fish
Hi all!

As can be seen here:

* http://module-starter.googlecode.com/svn/trunk/t/module-starter.t

Module::Starter's t/module-starter.t has the following lines:

{{
use Test::More;
plan skip_all = these tests must be completely rewritten;
}}

It also seems none of them test for the contents of the files, but only for 
their existence.

What can be done about it and when will it be fixed? I wanted to improve the 
M-S support for software licences, but now it seems that I cannot add 
regression tests for this task easily.

Regards,

Shlomi Fish

-
Shlomi Fish   http://www.shlomifish.org/
The Case for File Swapping - http://xrl.us/bjn7i

I met a guy in the bar, talked to her and she gave me her phone number.


Re: Module-Starter's t/module-starter.t has skip_all

2008-07-25 Thread Ken Williams
On Fri, Jul 25, 2008 at 2:50 PM, Shlomi Fish [EMAIL PROTECTED] wrote:
 What can be done about it and when will it be fixed?

Sounds like a bummer, but I'm not sure what you want the
module-authors list to do about it.

 -Ken