[Mono-dev] [PATCH] InternalsVisibleTo for MoonAtkBridge
This patch adds InternalsVisibleTo on the 2_1 profile, but using an env var for now until we assure that this is not a security threat. May I commit? Thanks. Andrés -- Index: class/corlib/Makefile === --- class/corlib/Makefile (revision 131333) +++ class/corlib/Makefile (working copy) @@ -25,6 +25,12 @@ corlib_flags = -unsafe -nostdlib LOCAL_MCS_FLAGS = -nowarn:612,618 -d:INSIDE_CORLIB +# this hack will be dropped once we get this working: +# http://www.mono-project.com/Moonlight/SecurityStatus#Assembly_Loading +ifdef MOON_A11Y_INTERNAL_HACK + MCS_FLAGS += -define:MOON_A11Y_INTERNAL_HACK +endif + # System.IO/DirectoryInfoTest.cs needs Mono.Posix TEST_MCS_FLAGS = -debug+ -debug:full -nowarn:168,219,618,672 -unsafe -r:$(topdir)/class/lib/$(PROFILE)/Mono.Posix.dll -define:MONO_DATACONVERTER_STATIC_METHODS Index: class/corlib/Assembly/AssemblyInfo.cs === --- class/corlib/Assembly/AssemblyInfo.cs (revision 131333) +++ class/corlib/Assembly/AssemblyInfo.cs (working copy) @@ -92,3 +92,12 @@ [assembly: InternalsVisibleTo (System.Net, PublicKey=00240480940006020024525341310004010001008D56C76F9E8649383049F383C44BE0EC204181822A6C31CF5EB7EF486944D032188EA1D3920763712CCB12D75FB77E9811149E6148E5D32FBAAB37611C1878DDC19E20EF135D0CB2CFF2BFEC3D115810C3D9069638FE4BE215DBF795861920E5AB6F7DB2E2CEEF136AC23D5DD2BF031700AEC232F6C6B1C785B4305C123B37AB)] [assembly: InternalsVisibleTo (System.Runtime.Serialization, PublicKey=00240480940006020024525341310004010001008D56C76F9E8649383049F383C44BE0EC204181822A6C31CF5EB7EF486944D032188EA1D3920763712CCB12D75FB77E9811149E6148E5D32FBAAB37611C1878DDC19E20EF135D0CB2CFF2BFEC3D115810C3D9069638FE4BE215DBF795861920E5AB6F7DB2E2CEEF136AC23D5DD2BF031700AEC232F6C6B1C785B4305C123B37AB)] #endif + +#if NET_2_1 + +// this hack will be dropped once we get this working: +// http://www.mono-project.com/Moonlight/SecurityStatus#Assembly_Loading + MOON_A11Y_INTERNAL_HACK + + [assembly: InternalsVisibleTo (MoonAtkBridge, PublicKey=002404809400060200245253413100040100010071eb6c5575529cbf7244f7a6ea056284f9eae03bcff2cc132c9c490ab309eab0b56bce449df503d9c0a81e520585cdbe70e2fb90434bac04fa6222a80098b7a1a7b3af991a412324bb4325f6b865bb64ebf6d1c206d5732ddfbc70a7389ee53e0c246e3279741ad00503e49842e19bf37b198b402126cb3689c2ea6496a47cb4)] +#endif ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] InternalsVisibleTo for MoonAtkBridge
Andrés G. Aragoneses wrote: This patch adds InternalsVisibleTo on the 2_1 profile, but using an env var for now until we assure that this is not a security threat. May I commit? Thanks. Patch updated. Index: class/corlib/Makefile === --- class/corlib/Makefile (revision 131333) +++ class/corlib/Makefile (working copy) @@ -25,6 +25,12 @@ corlib_flags = -unsafe -nostdlib LOCAL_MCS_FLAGS = -nowarn:612,618 -d:INSIDE_CORLIB +# this hack will be dropped once we get this working: +# http://www.mono-project.com/Moonlight/SecurityStatus#Assembly_Loading +ifdef MOON_A11Y_INTERNAL_HACK + MCS_FLAGS += -define:MOON_A11Y_INTERNAL_HACK +endif + # System.IO/DirectoryInfoTest.cs needs Mono.Posix TEST_MCS_FLAGS = -debug+ -debug:full -nowarn:168,219,618,672 -unsafe -r:$(topdir)/class/lib/$(PROFILE)/Mono.Posix.dll -define:MONO_DATACONVERTER_STATIC_METHODS Index: class/corlib/Assembly/AssemblyInfo.cs === --- class/corlib/Assembly/AssemblyInfo.cs (revision 131333) +++ class/corlib/Assembly/AssemblyInfo.cs (working copy) @@ -91,4 +91,12 @@ [assembly: InternalsVisibleTo (System.Windows, PublicKey=00240480940006020024525341310004010001008D56C76F9E8649383049F383C44BE0EC204181822A6C31CF5EB7EF486944D032188EA1D3920763712CCB12D75FB77E9811149E6148E5D32FBAAB37611C1878DDC19E20EF135D0CB2CFF2BFEC3D115810C3D9069638FE4BE215DBF795861920E5AB6F7DB2E2CEEF136AC23D5DD2BF031700AEC232F6C6B1C785B4305C123B37AB)] [assembly: InternalsVisibleTo (System.Net, PublicKey=00240480940006020024525341310004010001008D56C76F9E8649383049F383C44BE0EC204181822A6C31CF5EB7EF486944D032188EA1D3920763712CCB12D75FB77E9811149E6148E5D32FBAAB37611C1878DDC19E20EF135D0CB2CFF2BFEC3D115810C3D9069638FE4BE215DBF795861920E5AB6F7DB2E2CEEF136AC23D5DD2BF031700AEC232F6C6B1C785B4305C123B37AB)] [assembly: InternalsVisibleTo (System.Runtime.Serialization, PublicKey=00240480940006020024525341310004010001008D56C76F9E8649383049F383C44BE0EC204181822A6C31CF5EB7EF486944D032188EA1D3920763712CCB12D75FB77E9811149E6148E5D32FBAAB37611C1878DDC19E20EF135D0CB2CFF2BFEC3D115810C3D9069638FE4BE215DBF795861920E5AB6F7DB2E2CEEF136AC23D5DD2BF031700AEC232F6C6B1C785B4305C123B37AB)] + +// this hack will be dropped once we get this working: +// http://www.mono-project.com/Moonlight/SecurityStatus#Assembly_Loading +#if MOON_A11Y_INTERNAL_HACK + [assembly: InternalsVisibleTo (MoonAtkBridge, PublicKey=002404809400060200245253413100040100010071eb6c5575529cbf7244f7a6ea056284f9eae03bcff2cc132c9c490ab309eab0b56bce449df503d9c0a81e520585cdbe70e2fb90434bac04fa6222a80098b7a1a7b3af991a412324bb4325f6b865bb64ebf6d1c206d5732ddfbc70a7389ee53e0c246e3279741ad00503e49842e19bf37b198b402126cb3689c2ea6496a47cb4)] #endif + +#endif + ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] InternalsVisibleTo for MoonAtkBridge
Andrés G. Aragoneses wrote: Andrés G. Aragoneses wrote: This patch adds InternalsVisibleTo on the 2_1 profile, but using an env var for now until we assure that this is not a security threat. May I commit? Thanks. Patch updated. As already explained in moon-list, this is needed because glib-sharp and atk-sharp (which will now be merged in one assembly called MoonAtkBridge) access some Marshaling API which is not public anymore in the 2.1 profile. We're also looking at generating spec files for the monolinker to consume, in order for it to not strip the API we need, but this will come later. Andrés -- ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
