Re: [Mono-dev] Test Suite Failures, Revision 2
On Mon, 2010-04-05 at 14:28 +0900, Atsushi Eno wrote:
-- test-System_ServiceModel --
6 sporadic timeouts
started in r154243 (Gonzalo)
http://build.mono-project.com/GetFile.aspx?id=2257888
Gonzalo, tell me if you got some fixes. I'll stick to r154237 so far
(after updating my repo it was blocking nunit test run there, so I have
reverted to older version).
These is fixed now.
I'm attaching a patch for HttpRequestChannel.cs that avoids creating the
ManualResetEvent when nobody needs it. Ok to commit?
-Gonzalo
Index: HttpRequestChannel.cs
===
--- HttpRequestChannel.cs (revision 154794)
+++ HttpRequestChannel.cs (working copy)
@@ -317,16 +317,15 @@
AsyncCallback callback;
ManualResetEvent wait;
Exception error;
+ object locker = new object ();
+ bool is_completed;
public HttpChannelRequestAsyncResult (Message message, TimeSpan timeout, AsyncCallback callback, object state)
{
-CompletedSynchronously = true;
Message = message;
Timeout = timeout;
this.callback = callback;
AsyncState = state;
-
-wait = new ManualResetEvent (false);
}
public Message Response {
@@ -334,7 +333,13 @@
}
public WaitHandle AsyncWaitHandle {
-get { return wait; }
+get {
+ lock (locker) {
+ if (wait == null)
+ wait = new ManualResetEvent (is_completed);
+ }
+ return wait;
+}
}
public object AsyncState {
@@ -355,7 +360,6 @@
error = error ?? ex;
IsCompleted = true;
-wait.Set ();
if (callback != null)
callback (this);
}
@@ -365,7 +369,14 @@
}
public bool IsCompleted {
-get; private set;
+get { return is_completed; }
+set {
+ is_completed = value;
+ lock (locker) {
+ if (is_completed wait != null)
+ wait.Set ();
+ }
+}
}
public void WaitEnd ()
@@ -376,9 +387,9 @@
// exception to the Complete () method and allow the result to complete 'normally'.
#if NET_2_1
// neither Moonlight nor MonoTouch supports contexts (WaitOne default to false)
- bool result = wait.WaitOne (Timeout);
+ bool result = AsyncWaitHandle.WaitOne (Timeout);
#else
- bool result = wait.WaitOne (Timeout, true);
+ bool result = AsyncWaitHandle.WaitOne (Timeout, true);
#endif
if (!result)
throw new TimeoutException ();
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Test Suite Failures, Revision 2
Thanks! It's looking good and working fine, so please go ahead and commit the change. Atsushi Eno On 2010/04/06 6:35, Gonzalo Paniagua Javier wrote: On Mon, 2010-04-05 at 14:28 +0900, Atsushi Eno wrote: -- test-System_ServiceModel -- 6 sporadic timeouts started in r154243 (Gonzalo) http://build.mono-project.com/GetFile.aspx?id=2257888 Gonzalo, tell me if you got some fixes. I'll stick to r154237 so far (after updating my repo it was blocking nunit test run there, so I have reverted to older version). These is fixed now. I'm attaching a patch for HttpRequestChannel.cs that avoids creating the ManualResetEvent when nobody needs it. Ok to commit? -Gonzalo ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Test Suite Failures, Revision 2
Hey Jonathan, Thanks for heads up. On 2010/04/02 2:26, Jonathan Pobst wrote: -- test-System_ServiceModel -- 6 sporadic timeouts started in r154243 (Gonzalo) http://build.mono-project.com/GetFile.aspx?id=2257888 Gonzalo, tell me if you got some fixes. I'll stick to r154237 so far (after updating my repo it was blocking nunit test run there, so I have reverted to older version). -- test-System_ServiceModel_Web -- 1 timeout started in r154243 (Gonzalo) 1 json failure since test suite added: r154188 (Atsushi) http://build.mono-project.com/GetFile.aspx?id=2257906 I'll have a look at JSON issue. Atsushi Eno ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Test Suite Failures, Revision 2
[Updated list of test failures since last week] Hey guys! We have accumulated many test suite failures in the past month. If you commit to mono, please take the time to regularly check the buildbots to ensure you are not breaking things. The buildbot results are available here: http://wrench.mono-project.com/builds Our new buildbots build every revision, so it's easy to track down where something regressed. Current Regressions (all on SLE11 32 bit) --- -- test-compiler-2.0 -- test-454.cs http://build.mono-project.com/GetFile.aspx?id=2257661 -- test-corlib-2.0 -- http://build.mono-project.com/GetFile.aspx?id=2257690 MonoTests.System.Reflection.Emit.AssemblyBuilderTest.GetType : #1 regressed in r154231 (Kumpera) MonoTests.System.Reflection.Emit.ModuleBuilderTest.DefineType_Name_Null : #5 regressed in r154486 (Zoltan) MonoTests.System.Reflection.Emit.ModuleBuilderTest.TestGlobalMethods regressed in r154592 (Kumpera) -- test-System_Xml_Linq-3.5 -- castdatetimes Caused by DST time change http://build.mono-project.com/GetFile.aspx?id=2257798 -- test-System_ServiceModel -- 6 sporadic timeouts started in r154243 (Gonzalo) http://build.mono-project.com/GetFile.aspx?id=2257888 -- test-System_ServiceModel_Web -- 1 timeout started in r154243 (Gonzalo) 1 json failure since test suite added: r154188 (Atsushi) http://build.mono-project.com/GetFile.aspx?id=2257906 Thanks for your help in keeping Mono from regressing! Jonathan ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Test Suite Failures, Revision 2
On Thu, Apr 1, 2010 at 2:26 PM, Jonathan Pobst mon...@jpobst.com wrote: [Updated list of test failures since last week] Hey guys! We have accumulated many test suite failures in the past month. If you commit to mono, please take the time to regularly check the buildbots to ensure you are not breaking things. The buildbot results are available here: http://wrench.mono-project.com/builds Our new buildbots build every revision, so it's easy to track down where something regressed. Current Regressions (all on SLE11 32 bit) --- -- test-compiler-2.0 -- test-454.cs http://build.mono-project.com/GetFile.aspx?id=2257661 -- test-corlib-2.0 -- http://build.mono-project.com/GetFile.aspx?id=2257690 MonoTests.System.Reflection.Emit.AssemblyBuilderTest.GetType : #1 regressed in r154231 (Kumpera) MonoTests.System.Reflection.Emit.ModuleBuilderTest.DefineType_Name_Null : #5 regressed in r154486 (Zoltan) MonoTests.System.Reflection.Emit.ModuleBuilderTest.TestGlobalMethods regressed in r154592 (Kumpera) I'm working on the whole v2 and v4 regressions for corlib. Zoltan's regression is already fixed. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
