Re: [Mono-dev] atomic.h
On Mon, 2007-07-16 at 11:52 +0200, Andreas Färber wrote: Hello, With the growing number of supported architectures wouldn't it make sense to split up atomic.h like the mini files into atomic-ppc.h etc.? The whole file is a series of mutually exclusive conditional sections. I don't have a problem with this, apart from losing svn history in the chunks that are split out. - Dick signature.asc Description: This is a digitally signed message part ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] atomic.h
Am 24.07.2007 um 15:15 schrieb Dick Porter: On Mon, 2007-07-16 at 11:52 +0200, Andreas Färber wrote: Hello, With the growing number of supported architectures wouldn't it make sense to split up atomic.h like the mini files into atomic-ppc.h etc.? The whole file is a series of mutually exclusive conditional sections. I don't have a problem with this, apart from losing svn history in the chunks that are split out. I planned to do an svn copy for each new file to not loose it. :-) Andreas ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] atomic.h
On 07/24/07 Andreas Färber wrote: On Mon, 2007-07-16 at 11:52 +0200, Andreas Färber wrote: Hello, With the growing number of supported architectures wouldn't it make sense to split up atomic.h like the mini files into atomic-ppc.h etc.? The whole file is a series of mutually exclusive conditional sections. I don't have a problem with this, apart from losing svn history in the chunks that are split out. I planned to do an svn copy for each new file to not loose it. :-) I don't see any problem with the file as it is, it's small and eveytime I made changes to it it was useful to have the other arch code right there as quick reference. Please don't change it. Thanks. lupus -- - [EMAIL PROTECTED] debian/rules [EMAIL PROTECTED] Monkeys do it better ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] atomic.h
Am 24.07.2007 um 15:48 schrieb Paolo Molaro: I don't see any problem with the file as it is, it's small and eveytime I made changes to it it was useful to have the other arch code right there as quick reference. Please don't change it. Thanks. Like I pointed out: It's growing and won't stay as small (there are both shorter and longer files). Having multiple files will exactly improve the direct comparison of two architectures' implementations as a *quick* reference, without the need for lengthy scrolling and searching. For example currently ppc is next to s390 which seem pretty much unrelated, whereas multiple files allow you to easily peek into any architecture you see fit as a reference. But nice that you're answering at all, thanks. Andreas ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] atomic.h
Hello, With the growing number of supported architectures wouldn't it make sense to split up atomic.h like the mini files into atomic-ppc.h etc.? The whole file is a series of mutually exclusive conditional sections. My suggestion would be to do e.g. #if ... #elif defined(__ppc__) || ... #include mono/io-layer/atomic-ppc.h #elif ... #else // keep the fallback definitions in here #endif Would that be okay? Andreas ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
