Re: [Mono-dev] mono/mini/driver.c patch for RHEL3 compatability

2007-12-20 Thread Paolo Molaro 
On 12/19/07 C.J. Adams-Collier wrote:
 Zoltan asked that I make a change to configure.in as well, but I wanted
 to send this before I forgot about it.

The configure.in change is what is more important as you need to make
sure you won't break the correct systems in your quest for supporting
an old and broken distribution.

 --- mono/mini/driver.c  2007-12-19 15:04:53.0 -0800
 +++ mono/mini/patched-driver.c  2007-12-19 15:05:20.0 -0800
 @@ -706,8 +706,16 @@
  
  #if HAVE_SCHED_SETAFFINITY
 if (getenv (MONO_NO_SMP)) {
 +#  ifdef GLIBC_RHEL3_SCHED_SETAFFINITY

Use HAVE_BROKEN_SCHED_SETAFFINITY here.

lupus

-- 
-
[EMAIL PROTECTED] debian/rules
[EMAIL PROTECTED] Monkeys do it better
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] mono/mini/driver.c patch for RHEL3 compatability

2007-12-20 Thread Paolo Molaro 
On 12/20/07 C S Vadiraj wrote:
  --- mono/mini/driver.c  2007-12-19 15:04:53.0 -0800
  +++ mono/mini/patched-driver.c  2007-12-19 15:05:20.0 -0800
  @@ -706,8 +706,16 @@
   
   #if HAVE_SCHED_SETAFFINITY
  if (getenv (MONO_NO_SMP)) {
  +#  ifdef GLIBC_RHEL3_SCHED_SETAFFINITY
  +cpu_set_t proc_mask;
  +CPU_ZERO(proc_mask);
  +CPU_SET(0, proc_mask);
  +
  +sched_setaffinity (getpid(), proc_mask);
 
 You sure sched_setaffinity takes only two parameters. I feel the issue is not 
 in here but in 
 glibc.

Older Red Hat shipped with a broken sched_setaffinity() interface.

lupus

-- 
-
[EMAIL PROTECTED] debian/rules
[EMAIL PROTECTED] Monkeys do it better
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] mono/mini/driver.c patch for RHEL3 compatability

2007-12-19 Thread C S Vadiraj 
 --- mono/mini/driver.c  2007-12-19 15:04:53.0 -0800
 +++ mono/mini/patched-driver.c  2007-12-19 15:05:20.0 -0800
 @@ -706,8 +706,16 @@
  
  #if HAVE_SCHED_SETAFFINITY
 if (getenv (MONO_NO_SMP)) {
 +#  ifdef GLIBC_RHEL3_SCHED_SETAFFINITY
 +cpu_set_t proc_mask;
 +CPU_ZERO(proc_mask);
 +CPU_SET(0, proc_mask);
 +
 +sched_setaffinity (getpid(), proc_mask);

You sure sched_setaffinity takes only two parameters. I feel the issue is not 
in here but in 
glibc.

Man page point to 3 parameters and /usr/include/sched.h has a wrong declaration.




Thanks,
Vadiraj




___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list