Re: [Mono-dev] [PATCH] Winx64 stack cleanup for calls
Hi, It might be easier to define IS_STDCALL as FALSE on windows, since afaik there is no stdcall calling convention on winx64. Zoltan 2008/7/7 Bill Holmes [EMAIL PROTECTED]: Hello All, Attached (cleanStack_08_07_07.diff) is a small patch that should be specific to Winx64 only that will cleanup the stack after each call emitted from mono_arch_output_basic_block. The calling convention on Winx64 requires that the caller always cleans the stack. (At least as far as I am aware.) Also I have some tests (unitTests_404729.diff ) that tests bug #404729 on Winx64. -bill ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] Winx64 stack cleanup for calls
Zoltan, Agreed. I have attached an update. -bill On Mon, Jul 7, 2008 at 3:03 PM, Zoltan Varga [EMAIL PROTECTED] wrote: Hi, It might be easier to define IS_STDCALL as FALSE on windows, since afaik there is no stdcall calling convention on winx64. Zoltan 2008/7/7 Bill Holmes [EMAIL PROTECTED]: Hello All, Attached (cleanStack_08_07_07.diff) is a small patch that should be specific to Winx64 only that will cleanup the stack after each call emitted from mono_arch_output_basic_block. The calling convention on Winx64 requires that the caller always cleans the stack. (At least as far as I am aware.) Also I have some tests (unitTests_404729.diff ) that tests bug #404729 on Winx64. -bill ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list cleanStack_08_07_07.diff Description: Binary data ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] [PATCH] Winx64 stack cleanup for calls
Hi, This is ok to check in. Zoltan On Mon, Jul 7, 2008 at 9:22 PM, Bill Holmes [EMAIL PROTECTED] wrote: Zoltan, Agreed. I have attached an update. -bill On Mon, Jul 7, 2008 at 3:03 PM, Zoltan Varga [EMAIL PROTECTED] wrote: Hi, It might be easier to define IS_STDCALL as FALSE on windows, since afaik there is no stdcall calling convention on winx64. Zoltan 2008/7/7 Bill Holmes [EMAIL PROTECTED]: Hello All, Attached (cleanStack_08_07_07.diff) is a small patch that should be specific to Winx64 only that will cleanup the stack after each call emitted from mono_arch_output_basic_block. The calling convention on Winx64 requires that the caller always cleans the stack. (At least as far as I am aware.) Also I have some tests (unitTests_404729.diff ) that tests bug #404729 on Winx64. -bill ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
