Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

I did fix for the warnings in commit 5aa6640.

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Glad you like it!

In last commit was added focusedlinecolor.
This is the color of the focused line-fixed column (high-light fixed row
where is the carret).
Of course if you dont like this feature, just set the color as cl_default.

So, to resume, there is now 8 color values.

editorcolors = [fontcolor [backgroundcolor [statementcolor
[pairmarkbackgroundcolor, 
 [fontlinecolor [backgroundlinecolor [focusedlinecolor [selectedcolor]]]

And in sdef file, something like this:

# COLORS font/paper/statement/pairmark/fontline/line/focusline/selected
COLORS $93a1a1 $002b36 cl_default cl_default $93a1a1 $002b36 $5E0078 $5E0078


Have fun.

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 16/02/2020 3:48 am, fredvs wrote:
> I did commit all this in official mse-org.

Awesome, thank you very much! :-)

Regards,
  Graeme



___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

Sorry, I could not resist.
It is done, and was very easy.

3 new parameters are added in msesyntaxpainter : [fontlinecolor
[backgroundlinecolor [selectedcolor

So now in the sdef file, for example for your pascal_solarized_dark.sdef,
the code is this:

# COLORS font/paper/statement/pairmark/fontcolline/colline/selected
  COLORS $93a1a1 $002b36 cl_default cl_default $93a1a1 $002b36 $5E0078

 

Note that in Martin code, each color is dependent of the precedent and is
initialized like this:
cl_default cl_default cl_default cl_default cl_default cl_default cl_default

If you want to change only the selected color, you need to add all the 6
precedent cl_default.
If you only want to change the font/paper color, you may omit all the
cl_default that follow.

I did add a little line in procedurelist.pas to enable the selection-color
feature.

Also, your pascal_solarized_dark.sdef what updated with those new colors.
It is backward compatible with all old .sdef, of course.

I did commit all this in official mse-org.

Have fun.

Fre;D







--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

> And to complete all the look that sdef can give, maybe add also a parameter
> for the color of the first row.
> (The one that contain the line number). 

grid.fixcols[-1].color := cl_yourcolor;

Ok, I go.

Have a perfect and polychrome WE.

Fre;D





--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

And to complete all the look that sdef can give, maybe add also a parameter
for the color of the first row.
(The one that contain the line number).

 

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

> f the sdef definition/implementation doesn't currently support that color
item,

Imho, after fast check, it is not currently supported.

OK, I let you play with it.

;)

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 15/02/2020 1:46 pm, fredvs wrote:
> Or better, re-code syntax def file (.sdef) file to add a parameter to set
> the color of datacols[1].colorselected.

If the sdef definition/implementation doesn't currently support that
color item, than yes, that would be the best solution - extend the
implementation so the sdef theme can control that value too.

Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

>This will be added in ideU as extra-option : color of focused row and maybe
> other color-custom that are missing. 

Or better, re-code syntax def file (.sdef) file to add a parameter to set
the color of datacols[1].colorselected.

Fre;D




--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

If you want to change it hard-coded, it is in sourcepage.pas, with Object
Inspector on grid,
change the color of datacols[1].colorselected := cl_yourcolor.

see picture:
 

 

This will be added in ideU as extra-option : color of focused row and maybe
other color-custom that are missing.

Fre;D




--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

>I tried that, but it had horrible results on my side, with my color
> scheme. See attached screenshots and the file name explaining what you
> see. 

Ha, you did choose nearly the same color for font than the color of the row
focused.
So in the syntax definition file it should have also a "focused row color"
parameter or code that take care about the color already used.

I did not jump deeply yet in sdef code, maybe it is possible to do it
already.
Or maybe add it?

Fre;D 




--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 15/02/2020 11:41 am, fredvs wrote:
> There is a very little problem in tprocedurelistfo.JumpToSelectedLine;
> The line jumped is 1 line too much.

Well spotted. Seems the 0-based indexing into the source editor caught
me there.  ;-)


> Also may I propose to change the color of the line jumped, so it is more
> easy to see.

I tried that, but it had horrible results on my side, with my color
scheme. See attached screenshots and the file name explaining what you see.


Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

Many thanks!

There is a very little problem in tprocedurelistfo.JumpToSelectedLine;
The line jumped is 1 line too much.

Also may I propose to change the color of the line jumped, so it is more
easy to see.

Here the code:

procedure tprocedurelistfo.JumpToSelectedLine;
var
  int1: int32;
  lGotoLine: integer;
  c,c2: gridcoordty; // c2 is for the grid-editor
begin
  c.row := grdProcedures.Row;
  c.col := 3;
  lGotoLine := StrToInt(grdProcedures.Items[c]);
  c2.row := lGotoLine-1; // for color line jumped
  c2.col := 1;
  int1 := sourcefo.activepage.source_editor.rowwindowpos;
  sourcefo.activepage.source_editor.row := lGotoLine-1;// change this
  sourcefo.activepage.source_editor.rowwindowpos := int1-1; // change this
  sourcefo.activepage.source_editor.selectcell(c2, csm_select, False); //
change color focused
end;
 
Fre;D




--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 14/02/2020 6:30 pm, Graeme Geldenhuys wrote:
> Thanks for the code, I'll add that functionality back in.

I've made the change and merged it into official repository.

Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 13/02/2020 11:36 pm, fredvs wrote:
> Maybe you may add a oncellevent() method that jump into the source editor to
> the line of the method that you 2xcliked.

Ah, that was there - double checked with some old MSEide build I had. It
must have gotten lost somewhere during the rebase or something.

Thanks for the code, I'll add that functionality back in.


Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

It was the only feature from Geany that was missing.
And works very well.

I did add a 2xclik in mouse event the ideU version, for those that have a
broken keyboard.

Hum, in your code:

procedure tprocedurelistfo.AddProcedure(...)
...
case Language of
ltPas: 
...
ltCpp:// code ommitted - we don't need C++ support
... 
end; //case Language

If, by any chance, you cannot stop your fingers to write the code for Java,
C++ or Python, it does not matter, ideU will be very happy to welcome those
code.

(Ho, bad Fred...)

Thanks and wow Graeme.

Fre;D

 



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[Graeme Geldenhuys]

On 14/02/2020 3:12 am, fredvs wrote:
> It works **very** well.
> I could not resist too to commit it to ideU.
> 
> Many wow and many thanks.


Glad you liked it. :-) I implemented the same feature into Lazarus IDE
some 14 years ago (wow, time flies!) as a add-on, and soon after it
became standard with Lazarus. It seems to be a popular way of
navigating/jumping to code in a unit.

https://wiki.lazarus.freepascal.org/New_IDE_features_since#procedure_list

Both Eclipse IDE and IntelliJ has the same feature, though their dialogs
look slightly different. But importantly, they are also very keyboard
friendly (no need to use the mouse).


Regards,
  Graeme

-- 
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Re-hello Graeme.

It works **very** well.
I could not resist too to commit it to ideU.

Many wow and many thanks.

 

Fre;D




--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

Sorry I cannot resist...

So, add msegridsglob in uses section of procedurelistform unit.

Then assign that procedure to grdProcedures.oncellevent():

procedure tprocedurelistfo.oncellev(const sender: TObject;
   var info: celleventinfoty);
begin
 if info.eventkind = cek_buttonrelease then
 if info.mouseeventinfopo^.shiftstate = [ss_double] then 
begin
  { Jump to the line of code for the procedure we selected. }
  JumpToSelectedLine;
  Close;
end;
 end;

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Excellent Graeme.

And so out-of-the-box, load the prj compile and run without any problems.

Very useful indeed, Geany has that feature, nice to see it back.

Maybe you may add a oncellevent() method that jump into the source editor to
the line of the method that you 2xcliked.

As usual, "if you want I may do it for you".

;)

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk

Re: [MSEide-MSEgui-talk] Procedure List add-on for MSEide

[fredvs]

Hello Graeme.

I will study you mail deeper but all seems excellent!

Write you later.

Fre;D



--
Sent from: http://mseide-msegui-talk.13964.n8.nabble.com/


___
mseide-msegui-talk mailing list
mseide-msegui-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mseide-msegui-talk