Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
It's good usability, as close buttons on tab bars are rather standard (and the first place a user would look to close the tab). ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
It's not a big issue to make such a custom tabbar. We can add one shortly before the 1.0 release when everything is finished. It's just about looking pretty, isnt it :) Eldar Erathis schrieb: > Just wanted to note that this is something I don't think I'll have the > time to patch myself; my experience with Qt is still fairly minimal. > Sorry. I think I'm realizing now why most Qt apps don't seem to have > close buttons on individual tabs but lots of GTK+ ones do :-) > > -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
True that :) ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
[Mudlet-makers] [Bug 376285] Re: Close button not working correctly
Just wanted to note that this is something I don't think I'll have the time to patch myself; my experience with Qt is still fairly minimal. Sorry. I think I'm realizing now why most Qt apps don't seem to have close buttons on individual tabs but lots of GTK+ ones do :-) -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
No, it's on 4.5, but not everybody is on Jaunty. http://packages.ubuntu.com/search?suite=default§ion=all&arch=any&searchon=names&keywords=libqtcore ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
[Mudlet-makers] [Bug 376285] Re: Close button not working correctly
Well here's the patch I built on Qt4.5 if you want to look at it, but I'll see if I can find some time this afternoon to make one built on 4.4, too. Maybe it would be a good idea to check what version is being packaged with other distros. I'm on Fedora 10 and it's using Qt4.5 in it's repositories. I think Archlinux is, too, but I don't have my other machine hooked up yet since I just moved back home from my university last weekend. Is Ubuntu still on 4.4.x in Jaunty? ** Attachment added: "Adds close buttons to tabs (depends on Qt4.5)" http://launchpadlibrarian.net/26775487/mudlet-bugfix376285.patch -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
I'm using qt4.5 to build the windows binaries. However, using qt4.5 in general would get us into huge problems with Linux distributions as it's unlikely that most distros get qt4.5 packages - and Mudlet is still primarily a Linux project although most users are on windows. We can get those close icons in the tabs in 4.4 by making a custom tab bar that uses a custom draw routine. Would you be interested in making such a patch? Eldar Erathis schrieb: > This can be done very easily provided you're willing to build against > Qt4.5 instead of Qt4.4, but all of the compile instructions would need > to be updated - especially the Windows build instructions. They added > some new class methods to QTabBar, and I've got close buttons added to > the tabs and (as far as I can tell) working properly on my machine. > > Relevant portions of the Qt4.5 docs: http://doc.trolltech.com/main- > snapshot/qtabbar.html#tabsClosable-prop > > and > > http://doc.trolltech.com/main-snapshot/qtabbar.html#tabCloseRequested > > -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
Re: [Mudlet-makers] [Bug 376285] Re: Close button not working correctly
Qt 4.4 only wouldn't be a nice option, but conditional compilation for qt 4.5 would be fine. Eldar, think you can maek teh patch? -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
[Mudlet-makers] [Bug 376285] Re: Close button not working correctly
This can be done very easily provided you're willing to build against Qt4.5 instead of Qt4.4, but all of the compile instructions would need to be updated - especially the Windows build instructions. They added some new class methods to QTabBar, and I've got close buttons added to the tabs and (as far as I can tell) working properly on my machine. Relevant portions of the Qt4.5 docs: http://doc.trolltech.com/main- snapshot/qtabbar.html#tabsClosable-prop and http://doc.trolltech.com/main-snapshot/qtabbar.html#tabCloseRequested -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
[Mudlet-makers] [Bug 376285] Re: Close button not working correctly
Right, it seems to close the sessions, not the whole Mudlet. To which I agree with - tabs with a close button inside them like this: http://www.ubuntu-pics.de/bild/14308/screenshot_99_mQ1fL8.png Make more sense. -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
[Mudlet-makers] [Bug 376285] Re: Close button not working correctly
Checked on my Windows version of this build and the same thing happens, I guess the Close button is only supposed to close the active mud window, and do nothing if no active mud window? Would probably make more sense to attach a mini-close to the bar for each mud window inside of Mudlet. -- Close button not working correctly https://bugs.launchpad.net/bugs/376285 You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. Status in Mudlet the MUD client: New Bug description: Latest GIT, 5/13/2009, 9:12pm Eastern, Ubuntu 64-bit. Closing with the X at the window works properly, but pressing the CLOSE button on the menu bar does not. It seems to do absolutely nothing. ___ Mailing list: https://launchpad.net/~mudlet-makers Post to : mudlet-makers@lists.launchpad.net Unsubscribe : https://launchpad.net/~mudlet-makers More help : https://help.launchpad.net/ListHelp
