Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi, On Tue, 04 Dec 2001 Cedric [EMAIL PROTECTED] spewed into the ether: * Prahlad Vaidyanathan [EMAIL PROTECTED] [11/30/01 17:39]: Or wait a little... I will rewrite the patch so that it can work along with the new threading code. Done. I'll take the latter option. Thanks ! You'll find the patch updated for the new threading implementation at http://cedricduval.free.fr/mutt/ Works like a charm ! Thanks ! pv. -- Prahlad Vaidyanathan [EMAIL PROTECTED]What, me worry ? http://www.symonds.net/~prahladv/Don't Panic ! -- msg21098/pgp0.pgp Description: PGP signature
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi Prahlad, You'll find the patch updated for the new threading implementation at http://cedricduval.free.fr/mutt/ Works like a charm ! Thanks ! I'm afraid that's not entirely true: there was a nasty bug in patch-1.3.24.cd.edit_threads.7 This is fixed in edit_threads.8, that I've just uploaded at http://cedricduval.free.fr/download/patch-1.3.24.cd.edit_threads.8 Sorry for the inconvenience, -- Cedric msg21101/pgp0.pgp Description: PGP signature
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi, * Cedric Duval [EMAIL PROTECTED] [01-12-05 20:19]: This is fixed in edit_threads.8 I have just patched in all three of your changes in 1.3.24i. While patching, I got one error each (with different line numbers): - - - Schnipp - - - can't find file to patch at input line 715 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |--- PATCHES~ Sun Dec 3 08:54:50 2000 |+++ PATCHES Sun Dec 2 01:07:35 2001 -- - - - Schnapp - - - Unfazed, I continued. Configure (./configure --prefix=/usr --with-homespool=Mail/in) runs fine, make gives one warning, probably not yours: - - - Schnipp - - - pager.c: In function `format_line': pager.c:1118: warning: implicit declaration of function `wcwidth' - - - Schnapp - - - The linking fails, however: - - - Schnipp - - - mx.o: In function `trash_append': /home/hde/work/mail/mutt/mutt-1.3.24/mx.c:825: undefined reference to `TrashPath' /home/hde/work/mail/mutt/mutt-1.3.24/mx.c:838: undefined reference to `TrashPath' signature.o: In function `mutt_signature': /home/hde/work/mail/mutt/mutt-1.3.24/signature.c:485: undefined reference to `SigDirectory' /home/hde/work/mail/mutt/mutt-1.3.24/signature.c:491: undefined reference to `SigDirectory' - - - Schnapp - - - So is it the patching that went wrong? Thorsten -- Nichts ist schwerer und erfordert mehr Charakter, als sich in offenem Gegensatz zu seiner Zeit zu befinden und zu sagen: Nein! - Kurt Tucholsky
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi Thorsten, I have just patched in all three of your changes in 1.3.24i. While patching, I got one error each (with different line numbers): - - - Schnipp - - - can't find file to patch at input line 715 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |--- PATCHES~ Sun Dec 3 08:54:50 2000 |+++ PATCHES Sun Dec 2 01:07:35 2001 -- - - - Schnapp - - - Weird. How did you apply the patches? Did you, as the error message suggest, use the right -p option? From the good directory? Sample of what you should have done: $ wget http://cedricduval.free.fr/download/patch-1.3.24.cd.edit_threads.8 $ tar xvzf mutt-1.3.24i.tar.gz $ cd mutt-1.3.24 $ patch -p1 ../patch-1.3.24.cd.edit_threads.8 patching file `thread.c' patching file `OPS' patching file `copy.c' patching file `curs_main.c' patching file `doc/manual.sgml.head' patching file `functions.h' patching file `mutt.h' patching file `mx.c' patching file `pager.c' patching file `parse.c' patching file `protos.h' patching file `recvcmd.c' patching file `send.c' patching file `PATCHES' So is it the patching that went wrong? I suspect you applied the patches at the wrong place, because other peoples have had no problem. If not, maybe we should continue off-list to see what's wrong. Cheers, -- Cedric
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
On Tue, Dec 04, 2001 at 07:19:28AM, Cedric Duval wrote: You'll find the patch updated for the new threading implementation at http://cedricduval.free.fr/mutt/ Why doesn't it work with Maildir ? Cedric ---end quoted text--- binny -- J'aimerais savoir quels sont les différences majeurs entre FreeBSD, OpenBSD et NetBSD ? man diff -- Unknown °v° Benjamin Michotte[EMAIL PROTECTED] _o_ web : http://www.baby-linux.net
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
* Prahlad Vaidyanathan [EMAIL PROTECTED] [11/30/01 17:39]: Or wait a little... I will rewrite the patch so that it can work along with the new threading code. Done. I'll take the latter option. Thanks ! You'll find the patch updated for the new threading implementation at http://cedricduval.free.fr/mutt/ Regards, -- Cedric
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi, On Fri, 30 Nov 2001 Cedric [EMAIL PROTECTED] spewed into the ether: Hi Prahlad, Any clues as to why this is happening ? This patch could be _very_ useful ... if only I can get it to work :-( this patch is closely tied to the threading code. Ahhh - that explains it ! In the 1.3.23.1 release, this part of the Mutt code has been almost completely rewritten by Daniel Eisenbud in an effort to improve its efficiency. Thus the edit_threads patch won't apply anymore. If you want to use it, you should use Mutt 1.3.23. Or wait a little... I will rewrite the patch so that it can work along with the new threading code. I'll take the latter option. Thanks ! pv. -- Prahlad Vaidyanathan [EMAIL PROTECTED]What, me worry ? http://www.symonds.net/~prahladv/Don't Panic ! -- msg20852/pgp0.pgp Description: PGP signature
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
On 2001-11-30 10:32:23 +0530, Prahlad Vaidyanathan wrote: User-Agent: Mutt/1.3.23.2i [...] Any clues as to why this is happening ? This patch could be _very_ useful ... if only I can get it to work :-( I suppose that's because you're applying this patch to a version of mutt with the new threading implementation included. -- Thomas Roesslerhttp://log.does-not-exist.org/ msg20818/pgp00010.pgp Description: PGP signature
Re: patch-1.3.23.cd.edit_threads-6[.CYA] not working
Hi Prahlad, Any clues as to why this is happening ? This patch could be _very_ useful ... if only I can get it to work :-( this patch is closely tied to the threading code. In the 1.3.23.1 release, this part of the Mutt code has been almost completely rewritten by Daniel Eisenbud in an effort to improve its efficiency. Thus the edit_threads patch won't apply anymore. If you want to use it, you should use Mutt 1.3.23. Or wait a little... I will rewrite the patch so that it can work along with the new threading code. -- Cedric
