Re: [Nagios-users] [Nagios-devel] Nagios development moving forward
On 05/27/2010 03:33 PM, Michael Friedrich wrote: > Hi, > > just some feedback from my side on your patches. > > Original Message > Subject: [Nagios-devel] Nagios development moving forward > From: Andreas Ericsson > To: nagios-devel , > Nagios-users@lists.sourceforge.net > Date: 2010-04-29 20:46 > >> So for those of you who wish to try out a revamped Nagios with a >> bunch of bugfixes and code improvements, clone your repo from me >> or Ton today and build Nagios from source. > > I've taken all your commits and applied them manually onto the current > Icinga Core (we changed things, Nagios did not, and next to that, I'd > like to understand what you and Toon hacked there ;-) > Primarily code reduction and simplification. The diffstat between my dev branch and the upstream master looks like this: 47 files changed, 1563 insertions(+), 4272 deletions(-) Quite a few bugfixes too ofcourse. > Your hackings are very very nice, and it's a real good start in fixing > things and getting rid of old grown code and workarounds. > Yup. More can be done so object code only has to be compiled once for both cgi's and core for quite a small tradeoff in memory usage. This would mean simpler code and quite a lot simpler build-system, along with the possibility of installing nagios-devel header files for us eventmodule hackers. > This commit is just WOW :-) > > http://git.op5.org/git/?p=nagios.git;a=commit;h=555b4b72aae54e65ba923093ef469c3aa5a0edb9 > > Glad you like it. Macro voodoo is something of a fetish for me. > > Regarding taking over commits, kudos have been kept both within commit > subjects and changelog for our next release including your patches next > to ours. > Thanks. Always nice to be appreciated. > From the testing arena, everything runs fine. Although the sync > retention feature is only one half of the good, the other would be > opsview or some nifty hacking on distributed monitoring :) Everything > else resolves as it should be. > > > By chance, get these changes into a revamped tar.gz and hand that to > packagers, if it does not get into current CVS head. Or at least the > patch set :) > I'll poke Ethan about releasing 3.2.2 from git so we can get more people onto the latest and greatest. -- Andreas Ericsson andreas.erics...@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. -- ___ Nagios-users mailing list Nagios-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nagios-users ::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null
Re: [Nagios-users] [Nagios-devel] Nagios development moving forward
Hi, just some feedback from my side on your patches. Original Message Subject: [Nagios-devel] Nagios development moving forward From: Andreas Ericsson To: nagios-devel , Nagios-users@lists.sourceforge.net Date: 2010-04-29 20:46 > So for those of you who wish to try out a revamped Nagios with a > bunch of bugfixes and code improvements, clone your repo from me > or Ton today and build Nagios from source. I've taken all your commits and applied them manually onto the current Icinga Core (we changed things, Nagios did not, and next to that, I'd like to understand what you and Toon hacked there ;-) Your hackings are very very nice, and it's a real good start in fixing things and getting rid of old grown code and workarounds. This commit is just WOW :-) http://git.op5.org/git/?p=nagios.git;a=commit;h=555b4b72aae54e65ba923093ef469c3aa5a0edb9 Regarding taking over commits, kudos have been kept both within commit subjects and changelog for our next release including your patches next to ours. From the testing arena, everything runs fine. Although the sync retention feature is only one half of the good, the other would be opsview or some nifty hacking on distributed monitoring :) Everything else resolves as it should be. By chance, get these changes into a revamped tar.gz and hand that to packagers, if it does not get into current CVS head. Or at least the patch set :) Kind regards, Michael > > To clone a repository with git, use >git clone > > This will get you all latest sources. For further info about git, > see http://www.git-scm.org > > My repo: >clone url: > git://git.op5.org/nagios.git >gitweb url's: > http://git.op5.org/git/?p=nagios.git > http://git.op5.org/git/?p=nagios.git;a=shortlog;h=refs/heads/dev >branches: > masterSame as the still-official Nagios CVS repo > dev My changes on top of CVS import > ae-tonThe merged state between me and Ton > > Ton's repo: >clone url: > git://github.com/tonvoon/opsview-nagios.git >gitweb url: > http://github.com/tonvoon/opsview-nagios.git >branches: > masterTon's and my changes on top of CVS import > > > Those of you who have reported bugs to tracker.nagios.org should > log into the tracker again and see if your bug has been closed or > resolved, and if so try out my dev branch, which should contain > the proper fix. > > Those of you who are git-savvy since before can try > >git log -p --grep="fix.*#$bug_id_without_leading_zeroes" dev > > in a repo cloned from mine and it'll show you the commits that > are responsible for fixing your problem. > -- DI (FH) Michael Friedrich michael.friedr...@univie.ac.at Tel: +43 1 4277 14359 Vienna University Computer Center Universitaetsstrasse 7 A-1010 Vienna, Austria -- ___ Nagios-users mailing list Nagios-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nagios-users ::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null
Re: [Nagios-users] [Nagios-devel] Nagios development moving forward
Hi, Original Message Subject: Re: [Nagios-devel] Nagios development moving forward From: Andreas Ericsson To: Nagios Developers List Date: 2010-04-30 10:04 > The problem is that Ethan is too swamped to learn a new SCM at the > moment. Since that most likely means he's also too swamped to do any > development work on the Nagios core and CVS is quite unusable by me > and Ton, we decided to move forward with development anyway. Well I understand what he is doing right know, and I also understand that Ton and you would like to get things going with GIT. I basically did the same for some NDOUtils patches recently, I don't like to work on CVS when I get my hands on GIT :) > We're using one git repository each, and expect to be able to send pull > requests to Ethan (or whoever takes the part of integrator) when > Ethan takes the time to learn enough of git to join in. Hmmm I was coming from CVS/SVN about a year ago, and it was hard at the first time, but after a while, it was rather easy. I wrote several notes, and summarized this into our wiki lately. Maybe it will help Ethan since its focus is on the core within GIT. https://dev.icinga.org/wiki/icinga-development > It's meant to be an announcement that there are repositories where > core developers are stashing bugfixes and enhancements. What people > choose to do with that information is quite up to themselves. Ok, will start testing and applying then. > > Personally, I'd love it if people used my 'dev' branch for testing > and, if it solves a real problem they're having, for production use > too. All the changes I've done so far are bugfixes and performance > and maintainability improvements that shouldn't change any previously > working behaviour. Maybe several patches and fixes will get into rpm/deb packages then if they are resolving major issues and no new official release happens in time. Thanks for pointing this out, this will ease applying and testing. > Yes and no. Hendrik Baecker wrote an email to me, Ton and Ethan a > few weeks ago stating he no longer has the time to maintain NDOutils. > That means that NDOUtils currently stands without a maintainer. Ah ok. Thanks for the official info, thought about that a while ago. Well, difficult situation then. Maybe time for Merlin to become an official Core addon? :) > I won't be picking up that flag, since I'm also the Merlin maintainer > and wouldn't want to sit in a position where I'm maintaining two > similar modules. Especially since op5 won't be paying me to maintain > a more or less competing product. Maybe Ton or Ethan will take care > of it, or we'll announce that we're looking for a new maintainer > sometime soon. If anyone's interested in wearing the NDOUtils hat, > let us know. A while ago, I would have said yes (I also told Hendrik that he should send Ethan my application, but I got on hold never having sent any patches or sth like that). Right know my company will step over to Icinga and I will be maintaining this direction into the future, mainly regarding Postgres/Oracle support in combination with the new API/Web. So basically there's no time left for NDOUtils - it's basically competing with IDOUtils as a matter of fact, but only IDOUtils has Postgres/Oracle support and extended housekeeping etc. Overall NDOUtils needs to be kind of rewritten/improved as we did in Icinga - by someone who'll take the hat. Furthermore there are signifcant issues on the code of NDOUtils which need to be fixed asap (imho) - just for the community who uses it right now. Some of them are mentioned on the lists, some on the tracker and some are also within the patch collection of Opsera (talked to Ton on IRC about taking some of them into IDOUtils). Regarding NagVis, mk-livestatus (nice approach getting to know on the couches next to OSMC 2009) get's more and more important and people are moving over. At least the german speaking community is really into that, maybe others will catch up too. http://mathias-kettner.de/checkmk_livestatus.html So the basic need of NDOUtils is not there anymore regarding NagVis - also if using Merlin/Ninja. For other addons e.g. reporting tools development must not stop though. There are 2 other guys on the NDOUtils team - how about them to get things going? Or maybe a decision by Ethan, because currently the Nagios XI Enterprise version also ships with a buggy, not patched version of NDOUtils. And I suspect, for business needs, that's not really a good choice offering that. Anyways, I am happy to see that something's going on on the Nagios dev side of life :-) Kind regards, Michael -- DI (FH) Michael Friedrich michael.friedr...@univie.ac.at Tel: +43 1 4277 14359 Vienna University Computer Center Universitaetsstrasse 7 A-1010 Vienna, Austria -- ___ Nagios-users mailing list Nagios-users@lis
Re: [Nagios-users] [Nagios-devel] Nagios development moving forward
On 04/29/2010 09:15 PM, Michael Friedrich wrote: > Hi, > >> >> As most of you know, talk has been going on for quite some time >> to move the official Nagios repository to git. While this hasn't >> happened yet, everything that has so far been coded for Nagios >> has been done that way, in my own and Ton's public repositories >> which are cross-pollinated with changes from both of us. >> >> So for those of you who wish to try out a revamped Nagios with a >> bunch of bugfixes and code improvements, clone your repo from me >> or Ton today and build Nagios from source. > > Thanks for the update. Although it would be nice to get the official > repositories onto GIT - where exactly is the problem? > The problem is that Ethan is too swamped to learn a new SCM at the moment. Since that most likely means he's also too swamped to do any development work on the Nagios core and CVS is quite unusable by me and Ton, we decided to move forward with development anyway. We're using one git repository each, and expect to be able to send pull requests to Ethan (or whoever takes the part of integrator) when Ethan takes the time to learn enough of git to join in. > And regarding the revamped Nagios - is this meant to be an invitation > for testing, or for using those versions? When will all those fixes be > merged back in to the CVS HEAD > It's meant to be an announcement that there are repositories where core developers are stashing bugfixes and enhancements. What people choose to do with that information is quite up to themselves. Personally, I'd love it if people used my 'dev' branch for testing and, if it solves a real problem they're having, for production use too. All the changes I've done so far are bugfixes and performance and maintainability improvements that shouldn't change any previously working behaviour. >>branches: >> masterSame as the still-official Nagios CVS repo >> dev My changes on top of CVS import >> ae-tonThe merged state between me and Ton > > Sounds good, will give it a try. A bunch of nice improvements, and > bugfixes next to those where I've already applied the patches and tested > them over here :) > >>gitweb url: >> http://github.com/tonvoon/opsview-nagios.git > > Minor note - remove the .git then it works > http://github.com/tonvoon/opsview-nagios > Ah, thanks. > >> Those of you who have reported bugs to tracker.nagios.org should >> log into the tracker again and see if your bug has been closed or >> resolved, and if so try out my dev branch, which should contain >> the proper fix. > > Any news on NDOUtils and other Core addons? Next to the Core it would be > nice to know what's going on with them. > Yes and no. Hendrik Baecker wrote an email to me, Ton and Ethan a few weeks ago stating he no longer has the time to maintain NDOutils. That means that NDOUtils currently stands without a maintainer. I won't be picking up that flag, since I'm also the Merlin maintainer and wouldn't want to sit in a position where I'm maintaining two similar modules. Especially since op5 won't be paying me to maintain a more or less competing product. Maybe Ton or Ethan will take care of it, or we'll announce that we're looking for a new maintainer sometime soon. If anyone's interested in wearing the NDOUtils hat, let us know. -- Andreas Ericsson andreas.erics...@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. -- ___ Nagios-users mailing list Nagios-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nagios-users ::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null
Re: [Nagios-users] [Nagios-devel] Nagios development moving forward
Hi, Original Message Subject: [Nagios-devel] Nagios development moving forward From: Andreas Ericsson To: nagios-devel , Nagios-users@lists.sourceforge.net Date: 2010-04-29 20:46 > Hey all. Sorry for cross-posting, but I suppose this announce > interests quite a lot of the users too, and not just developers. > > I'm just writing to inform you all that Nagios (core and cgi's) > development is once again moving forward. We've previously been > stalled by technical issues on how we should work with the code > now that we're a distributed team. > > As most of you know, talk has been going on for quite some time > to move the official Nagios repository to git. While this hasn't > happened yet, everything that has so far been coded for Nagios > has been done that way, in my own and Ton's public repositories > which are cross-pollinated with changes from both of us. > > So for those of you who wish to try out a revamped Nagios with a > bunch of bugfixes and code improvements, clone your repo from me > or Ton today and build Nagios from source. Thanks for the update. Although it would be nice to get the official repositories onto GIT - where exactly is the problem? And regarding the revamped Nagios - is this meant to be an invitation for testing, or for using those versions? When will all those fixes be merged back in to the CVS HEAD > branches: > masterSame as the still-official Nagios CVS repo > dev My changes on top of CVS import > ae-tonThe merged state between me and Ton Sounds good, will give it a try. A bunch of nice improvements, and bugfixes next to those where I've already applied the patches and tested them over here :) > gitweb url: > http://github.com/tonvoon/opsview-nagios.git Minor note - remove the .git then it works http://github.com/tonvoon/opsview-nagios > Those of you who have reported bugs to tracker.nagios.org should > log into the tracker again and see if your bug has been closed or > resolved, and if so try out my dev branch, which should contain > the proper fix. Any news on NDOUtils and other Core addons? Next to the Core it would be nice to know what's going on with them. Kind regards, Michael -- DI (FH) Michael Friedrich michael.friedr...@univie.ac.at Tel: +43 1 4277 14359 Vienna University Computer Center Universitaetsstrasse 7 A-1010 Vienna, Austria -- ___ Nagios-users mailing list Nagios-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nagios-users ::: Please include Nagios version, plugin version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null